From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f69.google.com (mail-io1-f69.google.com [209.85.166.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B4EDD41C79 for ; Thu, 19 Dec 2024 08:44:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.69 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734597846; cv=none; b=tolkwB9Ft67lXR647sZU7z520DYykH5aORO98U+h0H/fA3gwTgCbZodYNQNvQ5yRgDK/0ZGAE02xjhNlrb1/zqnj9OC79+1WkzrMBXZsV1sjED8A+D6IZGYEdF9l8PdUVNsrtWnBOzIfdgPVdszuTTOKk5SItQuMHFwmXjgxKcY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734597846; c=relaxed/simple; bh=1wzjCmeUNbvITjm1RXMj87+eOnK3AfIoprawWk9seI4=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=bReIOCndUScWXSXb5Nd9J3aR07FrZHMJDDLxd1Y2v0liFhJNa02dtN3n/Tt4epWk8Q0hUk0wGy101Kr9tao6Fa6Z8oSx6gKE2v1bx8iW/4Un/1Yo7261YinHw06fixSu6xAyzw7oF/BMxhC4XHzLV9s4sR0dlI9gXg5myq8EB68= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.166.69 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-io1-f69.google.com with SMTP id ca18e2360f4ac-844dadd9bdcso95557239f.2 for ; Thu, 19 Dec 2024 00:44:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1734597844; x=1735202644; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Evjmwd6Xl/u+qID2uAsTxi+NJrWO2Xv3PUrwqp7r7hY=; b=fuMAptIZRczSBIzg3moAQfvK4BSoXqNhIf7Nbrppd2MiYEh8bRDahS/EYq70JJRsSl Y8w+lY05WUFfMbIK4GTJxcionbIHgcGUHBI94xH32ByBYXvfcWwo7Vcl/prjYaAq07C2 KXqg7XXz3sd1ojw5JsqdQgP7gnCAn8S7cQj37J47c7dPqVnh/ovxGt4TS0fLVWT4tXWG qOjE+O9KtQTnSqDJwbkRPJh0TPQZN9Pkc0/H32tVAQMEOLSyaajyrjIWhd9m139Erl8s olvLgYTLjl3Iau6Z7KblLcc1q3FKtijuYh463pERa2God7aLW96kSskjmZTy6y7tauIl rzRg== X-Gm-Message-State: AOJu0YzDCLPi3xaA2JDhqjndFEfYYwsNsk/HmP6EnTEpV6MBJHGk8Zhc tVfAUPpz0d6s5XYOprN8Mg4481BM0pVMrS9OsiZZZy4OA9x/fWptrQv8bP4yB9qlnRh9J+2mRhm 31gj8uu8EthcQ6VscJZ4m2vdaJ48uK8ldPGikiKlvbv9kcpX3YQnCmlI= X-Google-Smtp-Source: AGHT+IHUi8Tq1bTOBYwxvwMXHx+zNLY7okjjYr1fBG8tXDLUKYZJOZL+CSa/IJ8zbFIGcNqjXYVORuIC5+eheAkEjZK1K15FKnDj Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6e02:3cc5:b0:3a7:c072:c69a with SMTP id e9e14a558f8ab-3c010629e2amr29190725ab.3.1734597843769; Thu, 19 Dec 2024 00:44:03 -0800 (PST) Date: Thu, 19 Dec 2024 00:44:03 -0800 In-Reply-To: <20241219082441.969816-1-lizhi.xu@windriver.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <6763dcd3.050a0220.3157ee.0013.GAE@google.com> Subject: Re: [syzbot] [jfs?] possible deadlock in diFree (2) From: syzbot To: linux-kernel@vger.kernel.org, lizhi.xu@windriver.com, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" Hello, syzbot has tested the proposed patch but the reproducer is still triggering an issue: possible deadlock in diFree ERROR: (device loop0): remounting filesystem as read-only ERROR: (device loop0): duplicateIXtree: ====================================================== WARNING: possible circular locking dependency detected 6.13.0-rc3-syzkaller-geabcdba3ad40-dirty #0 Not tainted ------------------------------------------------------ syz.0.15/5813 is trying to acquire lock: ffff8880397c0920 (&(imap->im_aglock[index])){+.+.}-{4:4}, at: diFree+0x37c/0x2fb0 fs/jfs/jfs_imap.c:889 but task is already holding lock: ffff8880397c0890 (&imap->im_freelock){+.+.}-{4:4}, at: diNewIAG fs/jfs/jfs_imap.c:2460 [inline] ffff8880397c0890 (&imap->im_freelock){+.+.}-{4:4}, at: diAllocExt fs/jfs/jfs_imap.c:1905 [inline] ffff8880397c0890 (&imap->im_freelock){+.+.}-{4:4}, at: diAllocAG+0x49b/0x1f00 fs/jfs/jfs_imap.c:1669 which lock already depends on the new lock. the existing dependency chain (in reverse order) is: -> #1 (&imap->im_freelock){+.+.}-{4:4}: lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 diNewIAG fs/jfs/jfs_imap.c:2460 [inline] diAllocExt fs/jfs/jfs_imap.c:1905 [inline] diAllocAG+0x49b/0x1f00 fs/jfs/jfs_imap.c:1669 diAlloc+0x1d2/0x1630 fs/jfs/jfs_imap.c:1590 ialloc+0x8f/0x900 fs/jfs/jfs_inode.c:56 jfs_mkdir+0x1c5/0xba0 fs/jfs/namei.c:225 vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4311 do_mkdirat+0x264/0x3a0 fs/namei.c:4334 __do_sys_mkdirat fs/namei.c:4349 [inline] __se_sys_mkdirat fs/namei.c:4347 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4347 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f -> #0 (&(imap->im_aglock[index])){+.+.}-{4:4}: check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 diFree+0x37c/0x2fb0 fs/jfs/jfs_imap.c:889 jfs_evict_inode+0x32d/0x440 fs/jfs/inode.c:156 evict+0x4e8/0x9a0 fs/inode.c:796 diFreeSpecial fs/jfs/jfs_imap.c:552 [inline] duplicateIXtree+0x3c6/0x550 fs/jfs/jfs_imap.c:3026 diNewIAG fs/jfs/jfs_imap.c:2599 [inline] diAllocExt fs/jfs/jfs_imap.c:1905 [inline] diAllocAG+0x180f/0x1f00 fs/jfs/jfs_imap.c:1669 diAlloc+0x1d2/0x1630 fs/jfs/jfs_imap.c:1590 ialloc+0x8f/0x900 fs/jfs/jfs_inode.c:56 jfs_mkdir+0x1c5/0xba0 fs/jfs/namei.c:225 vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4311 do_mkdirat+0x264/0x3a0 fs/namei.c:4334 __do_sys_mkdirat fs/namei.c:4349 [inline] __se_sys_mkdirat fs/namei.c:4347 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4347 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f other info that might help us debug this: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&imap->im_freelock); lock(&(imap->im_aglock[index])); lock(&imap->im_freelock); lock(&(imap->im_aglock[index])); *** DEADLOCK *** 3 locks held by syz.0.15/5813: #0: ffff88801e2fa420 (sb_writers#13){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:515 #1: ffff888043c1b390 (&type->i_mutex_dir_key#8/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:853 [inline] #1: ffff888043c1b390 (&type->i_mutex_dir_key#8/1){+.+.}-{4:4}, at: filename_create+0x260/0x540 fs/namei.c:4080 #2: ffff8880397c0890 (&imap->im_freelock){+.+.}-{4:4}, at: diNewIAG fs/jfs/jfs_imap.c:2460 [inline] #2: ffff8880397c0890 (&imap->im_freelock){+.+.}-{4:4}, at: diAllocExt fs/jfs/jfs_imap.c:1905 [inline] #2: ffff8880397c0890 (&imap->im_freelock){+.+.}-{4:4}, at: diAllocAG+0x49b/0x1f00 fs/jfs/jfs_imap.c:1669 stack backtrace: CPU: 0 UID: 0 PID: 5813 Comm: syz.0.15 Not tainted 6.13.0-rc3-syzkaller-geabcdba3ad40-dirty #0 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_circular_bug+0x13a/0x1b0 kernel/locking/lockdep.c:2074 check_noncircular+0x36a/0x4a0 kernel/locking/lockdep.c:2206 check_prev_add kernel/locking/lockdep.c:3161 [inline] check_prevs_add kernel/locking/lockdep.c:3280 [inline] validate_chain+0x18ef/0x5920 kernel/locking/lockdep.c:3904 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5226 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5849 __mutex_lock_common kernel/locking/mutex.c:585 [inline] __mutex_lock+0x1ac/0xee0 kernel/locking/mutex.c:735 diFree+0x37c/0x2fb0 fs/jfs/jfs_imap.c:889 jfs_evict_inode+0x32d/0x440 fs/jfs/inode.c:156 evict+0x4e8/0x9a0 fs/inode.c:796 diFreeSpecial fs/jfs/jfs_imap.c:552 [inline] duplicateIXtree+0x3c6/0x550 fs/jfs/jfs_imap.c:3026 diNewIAG fs/jfs/jfs_imap.c:2599 [inline] diAllocExt fs/jfs/jfs_imap.c:1905 [inline] diAllocAG+0x180f/0x1f00 fs/jfs/jfs_imap.c:1669 diAlloc+0x1d2/0x1630 fs/jfs/jfs_imap.c:1590 ialloc+0x8f/0x900 fs/jfs/jfs_inode.c:56 jfs_mkdir+0x1c5/0xba0 fs/jfs/namei.c:225 vfs_mkdir+0x2f9/0x4f0 fs/namei.c:4311 do_mkdirat+0x264/0x3a0 fs/namei.c:4334 __do_sys_mkdirat fs/namei.c:4349 [inline] __se_sys_mkdirat fs/namei.c:4347 [inline] __x64_sys_mkdirat+0x87/0xa0 fs/namei.c:4347 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f35b537e719 Code: ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 0f 1f 40 00 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 a8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007f35b6113038 EFLAGS: 00000246 ORIG_RAX: 0000000000000102 RAX: ffffffffffffffda RBX: 00007f35b5535f80 RCX: 00007f35b537e719 RDX: 0000000000000000 RSI: 00000000200005c0 RDI: ffffffffffffff9c RBP: 00007f35b53f175e R08: 0000000000000000 R09: 0000000000000000 R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 R13: 0000000000000000 R14: 00007f35b5535f80 R15: 00007ffe3b78dd48 ERROR: (device loop0): diFree: wmap shows inode already free Tested on: commit: eabcdba3 Merge tag 'for-6.13-rc3-tag' of git://git.ker.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17ea77e8580000 kernel config: https://syzkaller.appspot.com/x/.config?x=f339dc38531e69a7 dashboard link: https://syzkaller.appspot.com/bug?extid=355da3b3a74881008e8f compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 patch: https://syzkaller.appspot.com/x/patch.diff?x=17054cf8580000