From: David Howells <dhowells@redhat.com>
To: Bryan Schumaker <bjschuma@netapp.com>
Cc: dhowells@redhat.com, Trond.Myklebust@netapp.com,
linux-nfs@vger.kernel.org, steved@redhat.com, jlayton@redhat.com
Subject: Re: [PATCH 2/2] NFS: Combine the idmapper key types
Date: Tue, 31 Jul 2012 15:45:46 +0100 [thread overview]
Message-ID: <6767.1343745946@warthog.procyon.org.uk> (raw)
In-Reply-To: <501037B6.9080800@netapp.com>
Bryan Schumaker <bjschuma@netapp.com> wrote:
> > + /* Use the non-legacy route unless given auxiliary data */
> > + if (!aux)
> > + return call_sbin_request_key(cons, op, aux);
>
> struct idmap-s are created when the server is mounted, so I don't think "aux" will ever be null here.
I've posted a new version of the patches with this fixed and with
nfs_idmap_upcall() restructured a bit so as not to do the allocations if we
don't have to.
David
next prev parent reply other threads:[~2012-07-31 14:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-25 15:53 [PATCH 1/2] NFS: Fix a number of bugs in the idmapper David Howells
2012-07-25 15:53 ` [PATCH 2/2] NFS: Combine the idmapper key types David Howells
2012-07-25 15:57 ` David Howells
2012-07-25 18:15 ` Bryan Schumaker
2012-07-31 14:45 ` David Howells [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-07-31 14:42 [PATCH 1/2] NFS: Fix a number of bugs in the idmapper David Howells
2012-07-31 14:42 ` [PATCH 2/2] NFS: Combine the idmapper key types David Howells
2012-07-31 14:54 ` Myklebust, Trond
2012-07-31 15:05 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6767.1343745946@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=Trond.Myklebust@netapp.com \
--cc=bjschuma@netapp.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=steved@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.