From mboxrd@z Thu Jan 1 00:00:00 1970 From: Boris Derzhavets Subject: Re: Build vmlinuz-2.6.29-rc5-tip Date: Fri, 20 Feb 2009 11:59:56 -0800 (PST) Message-ID: <677945.4902.qm@web56102.mail.re3.yahoo.com> References: Reply-To: bderzhavets@yahoo.com Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0457679639==" Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: Jeremy Fitzhardinge , Andrew Lyon Cc: "xen-devel@lists.xensource.com" , "Marc - A. Dahlhaus [ Administration | Westermann GmbH ]" List-Id: xen-devel@lists.xenproject.org --===============0457679639== Content-Type: multipart/alternative; boundary="0-1599482399-1235159996=:4902" --0-1599482399-1235159996=:4902 Content-Type: text/plain; charset=us-ascii >I have checked the ioemu-remote source that is downloaded when >building xen unstable, it seems to be missing this patch: > > This patch fixes the segmentation fault on assigning device without > Power Management Capability Structure. ************************************************ Where to get for patching Xen Unstable ? Boris. ************************************************ > Please apply this patch after applying the following patch I have > submitted. [PATCH] ioemu: Cleanup the code of PCI passthrough. Thanks, -- Yuji Shimada. Signed-off-by: Yuji Shimada diff --git a/hw/pass-through.c b/hw/pass-through.c index 855f69c..305ea59 100644 --- a/hw/pass-through.c +++ b/hw/pass-through.c @@ -1165,7 +1165,7 @@ static void pt_pci_write_config(PCIDevice *d, uint32_t address, uint32_t val, } /* check power state transition flags */ - if (pm_state->flags & PT_FLAG_TRANSITING) + if (pm_state != NULL && pm_state->flags & PT_FLAG_TRANSITING) /* can't accept untill previous power state transition is completed. * so finished previous request here. */ @@ -1280,7 +1280,7 @@ out: if (!ret) PT_LOG("Error: pci_write_block failed. return value[%d].\n", ret); - if (pm_state->flags & PT_FLAG_TRANSITING) + if (pm_state != NULL && pm_state->flags & PT_FLAG_TRANSITING) /* set QEMUTimer */ qemu_mod_timer(pm_state->pm_timer, (qemu_get_clock(rt_clock) + pm_state->pm_delay)); @@ -1337,7 +1337,7 @@ static uint32_t pt_pci_read_config(PCIDevice *d, uint32_t address, int len) } /* check power state transition flags */ - if (pm_state->flags & PT_FLAG_TRANSITING) + if (pm_state != NULL && pm_state->flags & PT_FLAG_TRANSITING) /* can't accept untill previous power state transition is completed. * so finished previous request here. */ From where ? --0-1599482399-1235159996=:4902 Content-Type: text/html; charset=us-ascii 

>I have checked the ioemu-remote source that is downloaded when
>building xen unstable, it seems to be missing this patch:

> <snip>

> This patch fixes the segmentation fault on assigning device without
> Power Management Capability Structure.
************************************************
Where to get <snip> for patching Xen Unstable ?

Boris.
************************************************
> Please apply this patch after applying the following patch I have
> submitted.

   [PATCH] ioemu: Cleanup the code of P
 CI passthrough.

Thanks,
--
Yuji Shimada.


Signed-off-by: Yuji Shimada <shimada-yxb@necst.nec.co.jp>


diff --git
 a/hw/pass-through.c b/hw/pass-through.c
index 855f69c..305ea59 100644
--- a/hw/pass-through.c
+++ b/hw/pass-through.c
@@ -1165,7 +1165,7 @@ static void pt_pci_write_config(PCIDevice *d,
uint32_t address, uint32_t val,
    }

    /* check power state transition flags */
-    if (pm_state->flags & PT_FLAG_TRANSITING)
+    if (pm_state != NULL && pm_state->flags &
PT_FLAG_TRANSITING)
        /* can't accept untill previous power state transition is
completed.
         * so finished previous request here.
         */
@@ -1280,7 +1280,7 @@ out:
    if (!ret)
        PT_LOG("Error: pci_write_block failed. return
value[%d].\n", ret);

-    if (pm_state->flags & PT_FLAG_TRANSITING)
+    if (pm_state != 
 NULL && pm_state->flags &
PT_FLAG_TRANSITING)
        /* set QEMUTimer */
        qemu_mod_timer(pm_state->pm_timer,
           
 (qemu_get_clock(rt_clock) + pm_state->pm_delay));
@@ -1337,7 +1337,7 @@ static uint32_t pt_pci_read_config(PCIDevice *d,
uint32_t address, int len)
    }

    /* check power state transition flags */
-    if (pm_state->flags & PT_FLAG_TRANSITING)
+    if (pm_state != NULL && pm_state->flags &
PT_FLAG_TRANSITING)
        /* can't accept untill previous power state transition is
completed.
         * so finished previous request here.
         */

 From where ? <snip>



--0-1599482399-1235159996=:4902-- --===============0457679639== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xensource.com http://lists.xensource.com/xen-devel --===============0457679639==--