From: Paolo Bonzini <pbonzini@redhat.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Ashok Raj <ashok.raj@intel.com>,
seabios@seabios.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [SeaBIOS] [PATCH v3] fw/msr_feature_control: add support to set MSR_IA32_FEATURE_CONTROL
Date: Thu, 7 Jul 2016 08:12:06 -0400 (EDT) [thread overview]
Message-ID: <678512723.4663298.1467893526100.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <4421d34d-e318-b1c6-08bc-3cd7800e5dd8@redhat.com>
> I've worried that if I only *call* these interfaces to set the MSR, then
> the next (independent) use of the same interfaces would clear the MSR
> through the INIT-SIPI-SIPI. That would have forced me to modify the
> protocol / PPI implementations so that any use of them would reprogram
> the MSR every time, after the INIT-SIPI-SIPI.
>
> This way however (hopefully) it should suffice to call the PPI only --
> the results should survive from PEI to DXE to the runtime OS on the
> normal boot path, and from PEI to the runtime OS on the S3 resume path.
This is correct (for what I understand). Out of curiosity, why is
it not enough to just add the MSR to the ACPI_CPU_DATA? Or is it
what you're doing, but OVMF was not restoring MTRRs at S3 resume
time either?
Paolo
next prev parent reply other threads:[~2016-07-07 12:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 6:53 [Qemu-devel] [PATCH v3] fw/msr_feature_control: add support to set MSR_IA32_FEATURE_CONTROL Haozhong Zhang
2016-07-01 12:02 ` [Qemu-devel] [SeaBIOS] " Gerd Hoffmann
2016-07-05 22:19 ` Laszlo Ersek
2016-07-06 1:26 ` Haozhong Zhang
2016-07-06 6:18 ` Paolo Bonzini
2016-07-06 6:28 ` Haozhong Zhang
2016-07-06 6:42 ` Laszlo Ersek
2016-07-06 6:49 ` Haozhong Zhang
2016-07-06 7:44 ` Laszlo Ersek
2016-07-06 8:48 ` Haozhong Zhang
2016-07-06 9:00 ` Laszlo Ersek
2016-07-06 9:05 ` Laszlo Ersek
2016-07-06 9:07 ` Haozhong Zhang
2016-07-06 9:13 ` Laszlo Ersek
2016-07-06 11:04 ` Laszlo Ersek
2016-07-06 12:18 ` Paolo Bonzini
2016-07-06 15:43 ` Laszlo Ersek
2016-07-07 12:12 ` Paolo Bonzini [this message]
2016-07-07 12:44 ` Laszlo Ersek
2016-07-07 13:19 ` [Qemu-devel] " Paolo Bonzini
2016-07-06 13:03 ` [Qemu-devel] [SeaBIOS] " Haozhong Zhang
2016-07-06 15:32 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=678512723.4663298.1467893526100.JavaMail.zimbra@redhat.com \
--to=pbonzini@redhat.com \
--cc=ashok.raj@intel.com \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.