Re: [PATCH for-4.22 v2 1/4] riscv/irq: define a per-arch irq_to_desc()

[Jan Beulich <jbeulich@suse.com>]

On 29.06.2026 11:45, Roger Pau Monne wrote:
> --- a/xen/arch/riscv/include/asm/irq.h
> +++ b/xen/arch/riscv/include/asm/irq.h
> @@ -35,6 +35,10 @@ struct arch_irq_desc {
>      unsigned int type;
>  };
>  
> +struct irq_desc;

Nit: You don't need this here, as ...

> +struct irq_desc *irq_to_desc(unsigned int irq);

... it's the function return type, not a parameter one.

> --- a/xen/arch/riscv/irq.c
> +++ b/xen/arch/riscv/irq.c
> @@ -19,6 +19,11 @@
>  
>  static irq_desc_t irq_desc[NR_IRQS];
>  
> +struct irq_desc *irq_to_desc(unsigned int irq)
> +{
> +    return &irq_desc[irq];
> +}

Maybe better assert that the incoming number is in range? By this not
(possibly, in the current arrangements) being an inline function, the
compiler can't assist.

Jan