From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from fanzine2.igalia.com (fanzine.igalia.com [178.60.130.6]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 24D691EE7A3 for ; Wed, 8 Jan 2025 08:46:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=178.60.130.6 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736325990; cv=none; b=LWXn/7SqFPUCc97FAsO+GbRGuEE+etqmgniugQkxj5fYHPU8Y8QJUyDlsBP+6RdSv2nSMlZJkNiyIAHCym15p2UXebMDmItHUuHRomElp06BXm3gUyliJvZfMlF+b4VmKiRuRiaCCYLiGKlllo8g6Zy/Iz4DoqYOlNxARw/s1Nk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736325990; c=relaxed/simple; bh=Lbdew5GfHUVPv1/p5Bxbiy9XiJtB9fjSGieVCLvSb2E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=n68t4ZHDptRqKTNAmgRtl0EMimvkxC10CvDIBhLSFJvmhzRdReyurvyY9Z4jf0SgG8BmUwjtPJI2twjC8+PlaIBURXKx/L7Rx3H3XaR9Slos/Fxvz69qoneFjDoVo0l734EFTH/71+goyAnQQRpxP+C8MqgxfDq39jy+tQW1WkM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com; spf=pass smtp.mailfrom=igalia.com; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b=SWi78Zsf; arc=none smtp.client-ip=178.60.130.6 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=igalia.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=igalia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=igalia.com header.i=@igalia.com header.b="SWi78Zsf" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:From: References:Cc:To:Subject:MIME-Version:Date:Message-ID:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=bzzmZCi2l0gidBfMPTiu/z+w1otlyHbbqOaLKcxbbSU=; b=SWi78Zsf2ctlhDeJm7IGQG3aQ6 6KKKUgOULwQZkY8ysxWIz/ZqTugPdt4ENYtwLGUWCYkxwEqBwjsK2SoFMyhFhhKjeSK4ZW0DD4qBs kNIq3BwOHSU6YLBF4nApH4ZBh+DBrbUgKRvqWVh76zNQpGz9ydwYum0LYXHSToCg3CLTUe35Ttmki 4KCf8NHb4U+ueXBSRVybDcg3pjZNjfijXtBbRain/8xbX1+2h2dIo6iFVSJ4Y5y2QAxGdU1PORlk1 6Y37B2MlrJ1QczXN/gpt1D2wvmQJQ63T0BL0uf2QDuchE4B4Uvy98fLg2iHRodM7nJfL4mFBUTp8q Ol/+0AbA==; Received: from [58.29.143.236] (helo=[192.168.1.6]) by fanzine2.igalia.com with esmtpsa (Cipher TLS1.3:ECDHE_X25519__RSA_PSS_RSAE_SHA256__AES_128_GCM:128) (Exim) id 1tVRhh-00D3kt-QR; Wed, 08 Jan 2025 09:46:18 +0100 Message-ID: <67a26bd1-e7de-40eb-9545-2d8f815c30aa@igalia.com> Date: Wed, 8 Jan 2025 17:46:10 +0900 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] sched_ext: Replace rq_lock() to raw_spin_rq_lock() in scx_ops_bypass() To: Andrea Righi Cc: tj@kernel.org, void@manifault.com, kernel-dev@igalia.com, linux-kernel@vger.kernel.org References: <20250108083307.74220-1-changwoo@igalia.com> From: Changwoo Min Content-Language: en-US, ko-KR, en-US-large, ko In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hello again, On 25. 1. 8. 17:42, Andrea Righi wrote: >> This change fixes: 0e7ffff1b811 ("scx: Fix raciness in scx_ops_bypass()") > > We should use the `Fixes:` tag, put this right before your SoB line: > > Fixes: 0e7ffff1b811 ("scx: Fix raciness in scx_ops_bypass()") Ah! My bad! >> >> Without this change, we observe the following warnings: > > Maybe report only the first warning, or even something small like this > should be sufficient to identify the issue I think: > > [ 6.615205] rq->balance_callback && rq->balance_callback != &balance_push_callback > [ 6.615208] WARNING: CPU: 2 PID: 0 at kernel/sched/sched.h:1730 __schedule+0x1130/0x1c90 Sure. Will fix it. Regards, Changwoo Min