From: Mitchell Levy <levymitchell0@gmail.com>
To: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Cc: "Boqun Feng" <boqun.feng@gmail.com>,
"Miguel Ojeda" <ojeda@kernel.org>,
"Alex Gaynor" <alex.gaynor@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
"Alice Ryhl" <aliceryhl@google.com>,
"Trevor Gross" <tmgross@umich.edu>,
"Andreas Hindborg" <a.hindborg@kernel.org>,
linux-block@vger.kernel.org, rust-for-linux@vger.kernel.org,
linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH v3 1/2] rust: lockdep: Remove support for dynamically allocated LockClassKeys
Date: Fri, 7 Feb 2025 15:11:58 -0800 [thread overview]
Message-ID: <67a6933f.630a0220.137520.f9b8@mx.google.com> (raw)
In-Reply-To: <CANiq72kawfy3YYyo7ANYrKVjkh0n53Jt_d0=bHqHfirHCxe6_Q@mail.gmail.com>
On Fri, Feb 07, 2025 at 12:27:58AM +0100, Miguel Ojeda wrote:
> On Wed, Feb 5, 2025 at 8:59 PM Mitchell Levy <levymitchell0@gmail.com> wrote:
> >
> > Currently, dynamically allocated LockCLassKeys can be used from the Rust
> > side without having them registered. This is a soundness issue, so
> > remove them.
> >
> > Suggested-by: Alice Ryhl <aliceryhl@google.com>
> > Link: https://lore.kernel.org/rust-for-linux/20240815074519.2684107-3-nmi@metaspace.dk/
> > Cc: stable@vger.kernel.org
> > Signed-off-by: Mitchell Levy <levymitchell0@gmail.com>
>
> I imagine we should have:
>
> Fixes: 6ea5aa08857a ("rust: sync: introduce `LockClassKey`")
>
> Is that right?
That's correct. Thank you for catching this! I will include this on a
resend.
Mitchell
> Thanks!
>
> Cheers,
> Miguel
next prev parent reply other threads:[~2025-02-07 23:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-05 19:59 [PATCH v3 0/2] rust: lockdep: Fix soundness issue affecting LockClassKeys Mitchell Levy
2025-02-05 19:59 ` [PATCH v3 1/2] rust: lockdep: Remove support for dynamically allocated LockClassKeys Mitchell Levy
2025-02-06 23:27 ` Miguel Ojeda
2025-02-07 23:11 ` Mitchell Levy [this message]
2025-02-07 0:23 ` Benno Lossin
2025-02-05 19:59 ` [PATCH v3 2/2] rust: lockdep: Use Pin for all LockClassKey usages Mitchell Levy
2025-02-05 20:30 ` Benno Lossin
2025-02-06 21:27 ` Boqun Feng
2025-02-07 0:22 ` Benno Lossin
2025-02-07 23:09 ` Mitchell Levy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67a6933f.630a0220.137520.f9b8@mx.google.com \
--to=levymitchell0@gmail.com \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=gary@garyguo.net \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=stable@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.