From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-il1-f207.google.com (mail-il1-f207.google.com [209.85.166.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0563F197A92 for ; Sat, 8 Feb 2025 09:14:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.207 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739006066; cv=none; b=h1rVzNF++ixItwkk67oc16vO0z5S0Bx0MouP3O10RCCNZquRzFrdzrhv598EXszMraoTi6CQOodf18lKw7t8p5ZMCCqh1rv7jmQcbJIGZIZyUOR9iNAdkx+94PPEQT0fVLnydq3AJd5S/9Hkw/imFp7xKAmo+d6UnFfMRV1aog0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739006066; c=relaxed/simple; bh=n6fptjxBHrz85jUk6eIQqKIsmDKaYKzCFFYl+I+rExI=; h=MIME-Version:Date:In-Reply-To:Message-ID:Subject:From:To: Content-Type; b=HmEAEdjWDkBWhcIVVFnt+jXKt7pg3byk6HxKLKaAZoh1lplbSM8g2Wo20UPgWVhpz4Jf3giwjMe2//eju6kn2lauVZoiTbknb/9pAe0SsUbQddhEhDlcvzA0I9tZlvnC9fTWUOK4EoDCzBGYje1dvD4EVrVa4tv1muZMjDAosro= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com; arc=none smtp.client-ip=209.85.166.207 Authentication-Results: smtp.subspace.kernel.org; dmarc=fail (p=none dis=none) header.from=syzkaller.appspotmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=M3KW2WVRGUFZ5GODRSRYTGD7.apphosting.bounces.google.com Received: by mail-il1-f207.google.com with SMTP id e9e14a558f8ab-3d054d79dacso50495605ab.2 for ; Sat, 08 Feb 2025 01:14:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739006064; x=1739610864; h=to:from:subject:message-id:in-reply-to:date:mime-version :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Z8uPZ/v3ZQp/gDPQ1FLSdSp6+MDO7HLj3XWRzPD2xDY=; b=s2BG7r1gTYctrcaiZbXIUhovU+FQI3JM/Vk0XKrikxtMHTWPS1uZqFG1F3YSSMphty SEwJbR+5mOwECu/XLo/aiLc5oEGCuW7foXJcqg5AmUkYx3MX55KL2a1JlZjexDQTavFP wjpsWzkoqqYwARjLqBYsF3CMTW6+GBEGMrKBBZR6ErylB/97O/GJJ4NhcTX1+FPkcIT8 WAegHCpJFZy8cdjKYJV0PDUXBkxq3PDpK5Ql838EsXWDmsDdrSgUgvFmAgENoHxIxSFv Ziz5UlA/+aOkl3toGuBGYX0qCYLYZOeXlDcKjyIIoEEXHYD0x3a4Nr7Jd8Rj3BD50UnJ xd5g== X-Forwarded-Encrypted: i=1; AJvYcCXMGkLCOG5o53KSVDuhUFdM3Pr/6i/Lfg9+i5snQ9USmyuoQcnHKir+Ulmyi1K2TIvpj78/LgGI4M4JcoWMRQ==@vger.kernel.org X-Gm-Message-State: AOJu0Yy5q/V5DAKyU6fHt3YJY19TEv5oOJo+4HDxbPxgDMWyzFTXGt9n 8RFf4oaC8HXQxDX+1vy80p5L9DYBWbmgAkUsmuDqwUTTi7NRdaIws2CL6Y+UwfyFF5WtipifpPF 06azSQ0yYikaoCI6mMe5OY1BTZZ8CkPvHrNdk6L+t/NgSBRWkB02vNe4= X-Google-Smtp-Source: AGHT+IHXWZnOnBt6UZeko8QiTA5a/vt4KTNoeWbDqvFNTpI+NaKHNscpiK0Mi8mJwl/Bmuvc2NK7mCDMAaQ8Tr5WbOE4J2Nzd1ii Precedence: bulk X-Mailing-List: linux-bcachefs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-Received: by 2002:a05:6e02:2163:b0:3d0:4b06:def3 with SMTP id e9e14a558f8ab-3d13dd645efmr49165885ab.10.1739006064152; Sat, 08 Feb 2025 01:14:24 -0800 (PST) Date: Sat, 08 Feb 2025 01:14:24 -0800 In-Reply-To: <66f9024f.050a0220.aab67.0010.GAE@google.com> X-Google-Appengine-App-Id: s~syzkaller X-Google-Appengine-App-Id-Alias: syzkaller Message-ID: <67a72070.050a0220.3d72c.0022.GAE@google.com> Subject: Re: [syzbot] [bcachefs?] possible deadlock in bch2_symlink From: syzbot To: kent.overstreet@linux.dev, linux-bcachefs@vger.kernel.org, linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com Content-Type: text/plain; charset="UTF-8" syzbot has found a reproducer for the following issue on: HEAD commit: 7ee983c850b4 Merge tag 'drm-fixes-2025-02-08' of https://g.. git tree: upstream console output: https://syzkaller.appspot.com/x/log.txt?x=17375ca4580000 kernel config: https://syzkaller.appspot.com/x/.config?x=1909f2f0d8e641ce dashboard link: https://syzkaller.appspot.com/bug?extid=7836a68852a10ec3d790 compiler: Debian clang version 15.0.6, GNU ld (GNU Binutils for Debian) 2.40 syz repro: https://syzkaller.appspot.com/x/repro.syz?x=14e0cca4580000 C reproducer: https://syzkaller.appspot.com/x/repro.c?x=155361b0580000 Downloadable assets: disk image (non-bootable): https://storage.googleapis.com/syzbot-assets/7feb34a89c2a/non_bootable_disk-7ee983c8.raw.xz vmlinux: https://storage.googleapis.com/syzbot-assets/f2f78699fc41/vmlinux-7ee983c8.xz kernel image: https://storage.googleapis.com/syzbot-assets/ca55e6e8dd01/bzImage-7ee983c8.xz mounted in repro: https://storage.googleapis.com/syzbot-assets/aa79c539b21d/mount_0.gz IMPORTANT: if you fix the issue, please add the following tag to the commit: Reported-by: syzbot+7836a68852a10ec3d790@syzkaller.appspotmail.com bcachefs (loop0): reading snapshots table bcachefs (loop0): reading snapshots done bcachefs (loop0): done starting filesystem ============================================ WARNING: possible recursive locking detected 6.14.0-rc1-syzkaller-00181-g7ee983c850b4 #0 Not tainted -------------------------------------------- syz-executor294/5305 is trying to acquire lock: ffff888044775078 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline] ffff888044775078 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: bch2_symlink+0x176/0x310 fs/bcachefs/fs.c:839 but task is already holding lock: ffff888044774148 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline] ffff888044774148 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: ovl_copy_up_workdir fs/overlayfs/copy_up.c:782 [inline] ffff888044774148 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: ovl_do_copy_up fs/overlayfs/copy_up.c:1001 [inline] ffff888044774148 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: ovl_copy_up_one fs/overlayfs/copy_up.c:1202 [inline] ffff888044774148 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: ovl_copy_up_flags+0x19cb/0x47c0 fs/overlayfs/copy_up.c:1257 other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(&sb->s_type->i_mutex_key#16); lock(&sb->s_type->i_mutex_key#16); *** DEADLOCK *** May be due to missing lock nesting notation 7 locks held by syz-executor294/5305: #0: ffff88801df94420 (sb_writers#10){.+.+}-{0:0}, at: mnt_want_write+0x3f/0x90 fs/namespace.c:547 #1: ffff88804470de50 (&ovl_i_mutex_dir_key[depth]/1){+.+.}-{4:4}, at: inode_lock_nested include/linux/fs.h:912 [inline] #1: ffff88804470de50 (&ovl_i_mutex_dir_key[depth]/1){+.+.}-{4:4}, at: lock_rename fs/namei.c:3217 [inline] #1: ffff88804470de50 (&ovl_i_mutex_dir_key[depth]/1){+.+.}-{4:4}, at: do_renameat2+0x62c/0x13f0 fs/namei.c:5161 #2: ffff88804470e418 (&ovl_i_mutex_key[depth]){+.+.}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline] #2: ffff88804470e418 (&ovl_i_mutex_key[depth]){+.+.}-{4:4}, at: lock_two_nondirectories+0xe1/0x170 fs/inode.c:1281 #3: ffff88804470e9e0 (&ovl_i_mutex_key[depth]/4){+.+.}-{4:4}, at: vfs_rename+0x6a2/0xf00 fs/namei.c:5040 #4: ffff88804470e7d0 (&ovl_i_lock_key[depth]){+.+.}-{4:4}, at: ovl_inode_lock_interruptible fs/overlayfs/overlayfs.h:650 [inline] #4: ffff88804470e7d0 (&ovl_i_lock_key[depth]){+.+.}-{4:4}, at: ovl_copy_up_start+0x53/0x310 fs/overlayfs/util.c:727 #5: ffff8880477b0420 (sb_writers#9){.+.+}-{0:0}, at: ovl_copy_up_workdir fs/overlayfs/copy_up.c:781 [inline] #5: ffff8880477b0420 (sb_writers#9){.+.+}-{0:0}, at: ovl_do_copy_up fs/overlayfs/copy_up.c:1001 [inline] #5: ffff8880477b0420 (sb_writers#9){.+.+}-{0:0}, at: ovl_copy_up_one fs/overlayfs/copy_up.c:1202 [inline] #5: ffff8880477b0420 (sb_writers#9){.+.+}-{0:0}, at: ovl_copy_up_flags+0x19b4/0x47c0 fs/overlayfs/copy_up.c:1257 #6: ffff888044774148 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: inode_lock include/linux/fs.h:877 [inline] #6: ffff888044774148 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: ovl_copy_up_workdir fs/overlayfs/copy_up.c:782 [inline] #6: ffff888044774148 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: ovl_do_copy_up fs/overlayfs/copy_up.c:1001 [inline] #6: ffff888044774148 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: ovl_copy_up_one fs/overlayfs/copy_up.c:1202 [inline] #6: ffff888044774148 (&sb->s_type->i_mutex_key#16){++++}-{4:4}, at: ovl_copy_up_flags+0x19cb/0x47c0 fs/overlayfs/copy_up.c:1257 stack backtrace: CPU: 0 UID: 0 PID: 5305 Comm: syz-executor294 Not tainted 6.14.0-rc1-syzkaller-00181-g7ee983c850b4 #0 Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.3-debian-1.16.3-2~bpo12+1 04/01/2014 Call Trace: __dump_stack lib/dump_stack.c:94 [inline] dump_stack_lvl+0x241/0x360 lib/dump_stack.c:120 print_deadlock_bug+0x483/0x620 kernel/locking/lockdep.c:3039 check_deadlock kernel/locking/lockdep.c:3091 [inline] validate_chain+0x15e2/0x5920 kernel/locking/lockdep.c:3893 __lock_acquire+0x1397/0x2100 kernel/locking/lockdep.c:5228 lock_acquire+0x1ed/0x550 kernel/locking/lockdep.c:5851 down_write+0x99/0x220 kernel/locking/rwsem.c:1577 inode_lock include/linux/fs.h:877 [inline] bch2_symlink+0x176/0x310 fs/bcachefs/fs.c:839 vfs_symlink+0x137/0x2e0 fs/namei.c:4671 ovl_do_symlink+0x85/0xd0 fs/overlayfs/overlayfs.h:267 ovl_create_real+0x346/0x550 fs/overlayfs/dir.c:206 ovl_copy_up_workdir fs/overlayfs/copy_up.c:783 [inline] ovl_do_copy_up fs/overlayfs/copy_up.c:1001 [inline] ovl_copy_up_one fs/overlayfs/copy_up.c:1202 [inline] ovl_copy_up_flags+0x19fe/0x47c0 fs/overlayfs/copy_up.c:1257 ovl_rename+0x62a/0x1760 fs/overlayfs/dir.c:1150 vfs_rename+0xbdb/0xf00 fs/namei.c:5069 do_renameat2+0xd94/0x13f0 fs/namei.c:5226 __do_sys_rename fs/namei.c:5273 [inline] __se_sys_rename fs/namei.c:5271 [inline] __x64_sys_rename+0x82/0x90 fs/namei.c:5271 do_syscall_x64 arch/x86/entry/common.c:52 [inline] do_syscall_64+0xf3/0x230 arch/x86/entry/common.c:83 entry_SYSCALL_64_after_hwframe+0x77/0x7f RIP: 0033:0x7f0d8dddad19 Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 17 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 RSP: 002b:00007ffd9dbea2d8 EFLAGS: 00000246 ORIG_RAX: 0000000000000052 RAX: ffffffffffffffda RBX: 0031656c69662f2e RCX: 00007f0d8dddad19 RDX: 00007f0d8dddad19 RSI: 0000400000000840 RDI: 0000400000000800 RBP: 0031656c69662f2e R08: 000055558454d4c0 R09: 000055558454d4c0 R10: 000055558454d4c0 R11: 0000000000000246 R12: 00007ffd9dbea300 R13: 00007ffd9dbea528 R14: 431bde82d7b634db R15: 00007f0d8de2303b syz-executor294 (5305) used greatest stack depth: 10768 bytes left --- If you want syzbot to run the reproducer, reply with: #syz test: git://repo/address.git branch-or-commit-hash If you attach or paste a git patch, syzbot will apply it before testing.