Re: [PATCH v4 1/1] ARM: dts: aspeed: Add device tree for Nvidia's GB200 UT3.0b platform BMC

[Andrew Jeffery <andrew@codeconstruct.com.au>]

Hi Donald,

In addition to addressing Krzysztof's comments regarding checkpatch:

On Tue, 2025-06-10 at 18:30 -0700, Donald Shannon wrote:
> The GB200NVL UT3.0b BMC is an Aspeed Ast2600 based BMC
> for Nvidia Blackwell GB200NVL platform.

Can you add some words contrasting this platform to the one submitted
by Willie?

https://lore.kernel.org/all/20250401153955.314860-3-wthai@nvidia.com/


> Reference to Ast2600 SOC [1].
> Reference to Blackwell GB200NVL Platform [2].
> 
> Link: https://www.aspeedtech.com/server_ast2600/ [1]
> Link:
> https://nvdam.widen.net/s/wwnsxrhm2w/blackwell-datasheet-3384703 [2]
> 

Please omit the blank line here so the Link: tags are part of the
trailer.

> Signed-off-by: Donald Shannon <donalds@nvidia.com>
> ---
> Changes v1 -> v2:
>   - Changed phy-mode to rgmii-id [Lunn]
>   - Removed redundant max-speed for mac0 [Lunn]
>   - Fixed typo from gb200nvl to gb200 in Makefile
> Changes v2 -> v3:
>   - Fixed whitespace issues [Krzysztof]
>   - Fixed schema validation issues from my end ( there are still
> issues with the aspeed dtsi file that are not related to this new
> dts) [Herring]
>   - Reordered to follow style guide [Krzysztof]
>   - Removed redundant status okays
>   - Changed vcc to vdd for the power gating on the gpio expanders
> Changes v3 -> v4:
>   - Added changelog [Krzysztof]
>   - Added nvidia,gb200-ut30b board binding [Krzysztof]
>   - Removed unused imports
>   - Reordered a couple other style guide violations
>   - Added back in a couple needed "status okay"s
> ---
>  .../bindings/arm/aspeed/aspeed.yaml           |    1 +
>  arch/arm/boot/dts/aspeed/Makefile             |    1 +
>  .../aspeed/aspeed-bmc-nvidia-gb200-ut30b.dts  | 1154
> +++++++++++++++++
>  3 files changed, 1156 insertions(+)
>  create mode 100644 arch/arm/boot/dts/aspeed/aspeed-bmc-nvidia-gb200-
> ut30b.dts
> 
> diff --git a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> index a3736f134130..420fabf05b24 100644
> --- a/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> +++ b/Documentation/devicetree/bindings/arm/aspeed/aspeed.yaml
> @@ -98,6 +98,7 @@ properties:
>                - inventec,starscream-bmc
>                - inventec,transformer-bmc
>                - jabil,rbp-bmc
> +              - nvidia,gb200-ut30b

For what it's worth, checkpatch reports at least the following:

   167: WARNING: DT binding docs and includes should be a separate patch. See: Documentation/devicetree/bindings/submitting-patches.rst
   180: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
   193: WARNING: DT compatible string "nvidia,gb200-ut30b" appears un-documented -- check ./Documentation/devicetree/bindings/

Thanks,

Andrew