From: Christian Marangi <ansuelsmth@gmail.com>
To: Daniel Golle <daniel@makrotopia.org>
Cc: Jens Axboe <axboe@kernel.dk>, Al Viro <viro@zeniv.linux.org.uk>,
Douglas Anderson <dianders@google.com>,
Christian Brauner <brauner@kernel.org>,
Riyan Dhiman <riyandhiman14@gmail.com>,
Konstantin Khlebnikov <koct9i@gmail.com>,
Li Lingfeng <lilingfeng3@huawei.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] block: allow setting partition of_node
Date: Tue, 1 Apr 2025 03:39:09 +0200 [thread overview]
Message-ID: <67eb43c1.050a0220.142b98.3224@mx.google.com> (raw)
In-Reply-To: <8cfbf225bcda906df0c89dd18ba07ecfa17123c2.1741107851.git.daniel@makrotopia.org>
On Tue, Mar 04, 2025 at 05:06:01PM +0000, Daniel Golle wrote:
> Allow partition parsers to set the Device Tree node for a partition by
> introducing of_put_partition() and extending struct parsed_partitions
> accordingly.
>
> As the partition information is preallocated independently of the actual
> number of partitions the additional pointer takes about 2 kiB of allocated
> memory which is worth avoiding in case CONFIG_OF is not set. This is
> achieved by only adding the corresponding field to the struct in case
> CONFIG_OF is set using #ifdef'ery.
>
> Signed-off-by: Daniel Golle <daniel@makrotopia.org>
I also think ifdef for OF is a necessity in this case to prevent the struct
size to explode.
Reviewed-by: Christian Marangi <ansuelsmth@gmail.com>
--
Ansuel
prev parent reply other threads:[~2025-04-01 1:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-04 17:06 [PATCH 1/2] block: allow setting partition of_node Daniel Golle
2025-03-04 17:06 ` [PATCH 2/2] block: partitions: of: assign Device Tree node to partition Daniel Golle
2025-04-01 1:40 ` Christian Marangi
2025-04-01 1:39 ` Christian Marangi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67eb43c1.050a0220.142b98.3224@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=daniel@makrotopia.org \
--cc=dianders@google.com \
--cc=koct9i@gmail.com \
--cc=lilingfeng3@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=riyandhiman14@gmail.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.