From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E539C32771 for ; Wed, 22 Jan 2020 22:51:26 +0000 (UTC) Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D38512253D for ; Wed, 22 Jan 2020 22:51:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=alsa-project.org header.i=@alsa-project.org header.b="XOM9p9KH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D38512253D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=alsa-devel-bounces@alsa-project.org Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id CB8261686; Wed, 22 Jan 2020 23:50:33 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz CB8261686 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1579733484; bh=iqR2fYWTDShJQ29A79dL0YHxXuMx44p64KRLTSuQhtc=; h=To:References:From:Date:In-Reply-To:Cc:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=XOM9p9KHCAv4YVVTLYy9JIq4JYwApt41aWb6zKwDJ0AtVlJYi3Gt3KnKdjrKdwFMr QnjWnZ2+uXRoDZYFBVo1/dUVFB5ljmRK6UwQQes+UmLcS2hNaMLUiargHw7Fo9Vqst aXARtaSmIxsp0eCYnB0G8tY+8xt1+Mdk02YA8jjk= Received: from alsa1.perex.cz (localhost.localdomain [127.0.0.1]) by alsa1.perex.cz (Postfix) with ESMTP id 09E73F8020C; Wed, 22 Jan 2020 23:50:33 +0100 (CET) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 276F2F80217; Wed, 22 Jan 2020 23:50:31 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id B39A8F800BA for ; Wed, 22 Jan 2020 23:50:26 +0100 (CET) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz B39A8F800BA X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2020 14:50:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,351,1574150400"; d="scan'208";a="229541509" Received: from jovercas-mobl1.amr.corp.intel.com (HELO [10.254.105.26]) ([10.254.105.26]) by orsmga006.jf.intel.com with ESMTP; 22 Jan 2020 14:50:22 -0800 To: Jaroslav Kysela , Mark Brown References: <20200122190752.3081016-1-perex@perex.cz> <26ae4dbd-b1b8-c640-0dc0-d8c2bbe666e2@linux.intel.com> <20200122202530.GG3833@sirena.org.uk> <045401f5-8d4c-cdc3-12fb-cf35148411e5@perex.cz> From: Pierre-Louis Bossart Message-ID: <67f2a1cf-fe62-76fa-ccdb-869e2b0daee2@linux.intel.com> Date: Wed, 22 Jan 2020 15:47:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <045401f5-8d4c-cdc3-12fb-cf35148411e5@perex.cz> Content-Language: en-US Cc: Dragos Tarcatu , Sasha Levin , ALSA development , Takashi Iwai , Greg Kroah-Hartman , Ranjani Sridharan , stable@vger.kernel.org Subject: Re: [alsa-devel] [PATCH] ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order X-BeenThere: alsa-devel@alsa-project.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: alsa-devel-bounces@alsa-project.org Sender: "Alsa-devel" >>> I am not following. Is this a fix for linux-5.4-y only, or is it >>> needed on >>> Mark's tree? In the latter case, what is broken? We've been using Mark's >>> tree without issues, wondering what we missed? >> >> He's saying it's a fix for stable but it's just a cleanup and robustness >> improvement in current kernels - when the patch 76d270364932 (ASoC: >> topology: Check return value for snd_soc_add_dai_link()) was backported >> by the bot the bot missed some other context which triggered bugs. > > Exactly. It's because the commit > 237d19080cd37e1ccf5462e63d8577d713f6da46 ("ASoC: soc-core: remove > topology specific operation") removed the link->dobj checks, but this > commit was not picked to the stable kernels. > > The initialization reordering is fine for all kernels (and makes sense), > so I would like to apply it everywhere. ok, thanks for the precisions. _______________________________________________ Alsa-devel mailing list Alsa-devel@alsa-project.org https://mailman.alsa-project.org/mailman/listinfo/alsa-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6083C32771 for ; Wed, 22 Jan 2020 22:50:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7FF0B2253D for ; Wed, 22 Jan 2020 22:50:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725933AbgAVWuZ (ORCPT ); Wed, 22 Jan 2020 17:50:25 -0500 Received: from mga12.intel.com ([192.55.52.136]:7331 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725884AbgAVWuZ (ORCPT ); Wed, 22 Jan 2020 17:50:25 -0500 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Jan 2020 14:50:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,351,1574150400"; d="scan'208";a="229541509" Received: from jovercas-mobl1.amr.corp.intel.com (HELO [10.254.105.26]) ([10.254.105.26]) by orsmga006.jf.intel.com with ESMTP; 22 Jan 2020 14:50:22 -0800 Subject: Re: [alsa-devel] [PATCH] ASoC: topology: fix soc_tplg_fe_link_create() - link->dobj initialization order To: Jaroslav Kysela , Mark Brown Cc: Dragos Tarcatu , Sasha Levin , ALSA development , Takashi Iwai , Greg Kroah-Hartman , Ranjani Sridharan , stable@vger.kernel.org References: <20200122190752.3081016-1-perex@perex.cz> <26ae4dbd-b1b8-c640-0dc0-d8c2bbe666e2@linux.intel.com> <20200122202530.GG3833@sirena.org.uk> <045401f5-8d4c-cdc3-12fb-cf35148411e5@perex.cz> From: Pierre-Louis Bossart Message-ID: <67f2a1cf-fe62-76fa-ccdb-869e2b0daee2@linux.intel.com> Date: Wed, 22 Jan 2020 15:47:34 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <045401f5-8d4c-cdc3-12fb-cf35148411e5@perex.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org >>> I am not following. Is this a fix for linux-5.4-y only, or is it >>> needed on >>> Mark's tree? In the latter case, what is broken? We've been using Mark's >>> tree without issues, wondering what we missed? >> >> He's saying it's a fix for stable but it's just a cleanup and robustness >> improvement in current kernels - when the patch 76d270364932 (ASoC: >> topology: Check return value for snd_soc_add_dai_link()) was backported >> by the bot the bot missed some other context which triggered bugs. > > Exactly. It's because the commit > 237d19080cd37e1ccf5462e63d8577d713f6da46 ("ASoC: soc-core: remove > topology specific operation") removed the link->dobj checks, but this > commit was not picked to the stable kernels. > > The initialization reordering is fine for all kernels (and makes sense), > so I would like to apply it everywhere. ok, thanks for the precisions.