All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Dhanavanthri, Swathi" <swathi.dhanavanthri@intel.com>
To: "Roper, Matthew D" <matthew.d.roper@intel.com>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/dg2: Print PHY name properly on calibration error
Date: Tue, 15 Feb 2022 22:56:51 +0000	[thread overview]
Message-ID: <6803827db66d48078de9284f1c935ef3@intel.com> (raw)
In-Reply-To: <20220215163545.2175730-1-matthew.d.roper@intel.com>

Acked-by: Swathi Dhanavanthri <swathi.dhanavanthri@intel.com>
 
-----Original Message-----
From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Matt Roper
Sent: Tuesday, February 15, 2022 8:36 AM
To: intel-gfx@lists.freedesktop.org
Subject: [Intel-gfx] [PATCH] drm/i915/dg2: Print PHY name properly on calibration error

We need to use phy_name() to convert the PHY value into a human-readable character in the error message.

Fixes: a6a128116e55 ("drm/i915/dg2: Wait for SNPS PHY calibration during display init")
Signed-off-by: Matt Roper <matthew.d.roper@intel.com>
---
 drivers/gpu/drm/i915/display/intel_snps_phy.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_snps_phy.c b/drivers/gpu/drm/i915/display/intel_snps_phy.c
index 8573a458811a..8fd00de981fc 100644
--- a/drivers/gpu/drm/i915/display/intel_snps_phy.c
+++ b/drivers/gpu/drm/i915/display/intel_snps_phy.c
@@ -35,7 +35,7 @@ void intel_snps_phy_wait_for_calibration(struct drm_i915_private *i915)
 		if (intel_de_wait_for_clear(i915, ICL_PHY_MISC(phy),
 					    DG2_PHY_DP_TX_ACK_MASK, 25))
 			drm_err(&i915->drm, "SNPS PHY %c failed to calibrate after 25ms.\n",
-				phy);
+				phy_name(phy));
 	}
 }
 
--
2.34.1


  reply	other threads:[~2022-02-15 22:56 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15 16:35 [Intel-gfx] [PATCH] drm/i915/dg2: Print PHY name properly on calibration error Matt Roper
2022-02-15 22:56 ` Dhanavanthri, Swathi [this message]
2022-02-16 20:52   ` Dhanavanthri, Swathi
2022-02-17 13:20 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: Print PHY name properly on calibration error (rev3) Patchwork
2022-02-17 13:49 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-02-17 23:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-02-21  9:42 ` [Intel-gfx] [PATCH] drm/i915/dg2: Print PHY name properly on calibration error Tvrtko Ursulin
2022-02-22 16:00   ` Matt Roper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6803827db66d48078de9284f1c935ef3@intel.com \
    --to=swathi.dhanavanthri@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=matthew.d.roper@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.