From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AEAA1C02 for ; Thu, 22 Jun 2023 04:25:22 +0000 (UTC) Received: from mail-lf1-f47.google.com (mail-lf1-f47.google.com [209.85.167.47]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2D79AE65; Wed, 21 Jun 2023 21:25:21 -0700 (PDT) Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-4f86bc35f13so6761493e87.1; Wed, 21 Jun 2023 21:25:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687407919; x=1689999919; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A5vC2aRsA2WDjAiqv/C0BR7ctU6hTo76uwUZaC8vGUs=; b=e6F8fko4BYJFHTF4on103Lcgb1pv1rWWncx67Q87nXomutGCc2pmjmtRcq+HHAh9Zz ZpOfpKMXjZ5A5GK/V4Sj7hoEWTtlUshbuobnWXs1v9qjH0mVTHjn5E44xfF6ArK+GHG2 4LAGMtr4Du0kfH+s229E70KmOTZTdNq62TY2nkwIL1IStpIehH05Zz/AmUx3xc792l8P 6QuGTft1UDM9RqGhdh4w1/BVGz9bFyuhmbKL/JuXXrtncgCplVAoow4MOdDTEDwM3twO vGB5w82asHvBwBUmHTlsPRwj9V2Td0xiZXyNK1FdyXhszsP+kSUr3hHKh/Xwx/pGw+ey CnDQ== X-Gm-Message-State: AC+VfDzQ7XoMC5Kzk1ecAIBAUosvB073D3vZJXRekIjTD2rU/ey6Gyo4 UD6ac+JRZ6jlvILL8Yzbo6k= X-Google-Smtp-Source: ACHHUZ6mLLpZ2jzgBbisqW8BsQ34AJIZtXtyRLGlK/Pv18m3vLOsDnG3vORq9yee5CR+W4060ihrFA== X-Received: by 2002:a05:6512:313c:b0:4f9:566f:1aab with SMTP id p28-20020a056512313c00b004f9566f1aabmr3597524lfd.29.1687407919067; Wed, 21 Jun 2023 21:25:19 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id y7-20020a1c4b07000000b003f17848673fsm6553494wma.27.2023.06.21.21.25.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 21:25:18 -0700 (PDT) Message-ID: <68038b83-3221-e351-909c-7f2722b612df@kernel.org> Date: Thu, 22 Jun 2023 06:25:15 +0200 Precedence: bulk X-Mailing-List: bpf@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init Content-Language: en-US To: Joel Granados Cc: mcgrof@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Theodore Ts'o , "Jason A. Donenfeld" , Greg Kroah-Hartman , Juergen Gross , Stefano Stabellini , Benjamin LaHaise , Alexander Viro , Christian Brauner , Jeff Layton , Chuck Lever , Jan Kara , Kees Cook , Iurii Zaikin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Peter Zijlstra , Will Deacon , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" , "H. Peter Anvin" , Oleksandr Tyshchenko , Amir Goldstein , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Waiman Long , Boqun Feng , John Ogness , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andy Lutomirski , Will Drewry , Mark Rutland , Miaohe Lin , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, kexec@lists.infradead.org, linux-trace-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org References: <20230621091000.424843-1-j.granados@samsung.com> <20230621091000.424843-9-j.granados@samsung.com> <36fae2b0-4cd2-58b5-cc12-9abdd5ce235b@kernel.org> <20230621131147.c3jegl4hgjplcrpu@localhost> From: Jiri Slaby In-Reply-To: <20230621131147.c3jegl4hgjplcrpu@localhost> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS, NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE, SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 21. 06. 23, 15:11, Joel Granados wrote: > On Wed, Jun 21, 2023 at 11:56:03AM +0200, Jiri Slaby wrote: >> On 21. 06. 23, 11:09, Joel Granados wrote: >>> In order to remove the end element from the ctl_table struct arrays, we >>> explicitly define the size when registering the targes. We add a size >>> argument to the register_sysctl_init call and pass an ARRAY_SIZE for all >>> the callers. >> >> Hi, I am missing here (or in 00/00) _why_ you are doing that. Is it by a > Not sure what happened. I used the kernels get_maintainers.pl script > together with git-send-email. These are my settings: > > " > tocmd ="`pwd`/scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --m --nol --nor" > cccmd ="`pwd`/scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --l --r --nom" > " > > Could it be that there is an error in MAINTAINERS? Sorry, I don't see what you are asking about. I was asking about motivation behind the series. That is a must in commit logs. thanks, -- js suse labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3F556EB64DC for ; Wed, 28 Jun 2023 15:16:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=1I+cBUX0uBxETIVbw69fbKdfYSXMD9reEO3JmPD3YFQ=; b=3HSHDdPl9V+IJ3 ySK22MFQheejiJ4pxsYoVIS2wZQ5TWGHyr52Ap8zfd6Orq7YDH0chOCerH7PzmEsQ0wVCz9oJ6ktQ OlJ2JHixXaFnY/i9a7aLABxxnSQtw0vINazAhYUSjx+a8UTNkmvSjFwINo9gHwlIUDR0MwBuREMEJ 8wvC7o+bOTX+8fE+qxC3C/v2UNpT707HiKu4Xb2YSf2YyAyRnZ6Wc2UKjWuatlmPLXZvG+3pZm/DH KGDePaVFreq9gYVVIYf4Faj+OKQmsm9bovf5dLcENyPNfRq3UJq27HWKAzSirQ6FDxXxZ6XAGM0Qr 4ij5EyV8IbiG0acqXx9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qEWua-00FxLg-1o; Wed, 28 Jun 2023 15:16:52 +0000 Received: from mail-lf1-f49.google.com ([209.85.167.49]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qCBsn-00Gmgq-1s for kexec@lists.infradead.org; Thu, 22 Jun 2023 04:25:22 +0000 Received: by mail-lf1-f49.google.com with SMTP id 2adb3069b0e04-4f76a0a19d4so9225398e87.2 for ; Wed, 21 Jun 2023 21:25:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687407919; x=1689999919; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=A5vC2aRsA2WDjAiqv/C0BR7ctU6hTo76uwUZaC8vGUs=; b=PScI4sTPdQCIv0tU01sYyjGpfzxJTy5KJSlMclRN0k/zRnxqgSRhZXjP5oBKghLoZq 6uChsyYjeNRd9f2ByvqYZRhT/qvXAOFoxaGMroKoK4Zb54+HDOpkbuYS5xrSpgK/kS3h H33pMc1jSw37SGEP4YjdlgGxvQVGJapYYonreUUKlydomBscwLjiHjDdFqqjI5TDJ/xF LUwecjxkgny6eGieuZgfgc4CfJxvT74gXbNBacOqqoiqbYrNeASj+f+tWTXjKfPdYB1w sUDAbxPWO3ZFCxANyFOvGTSzg7zegNK3CDNm7tZUUCEP+Q5U0qJrKh+Ydjuv568PkfpA 4YiA== X-Gm-Message-State: AC+VfDyn+Navbr9l5GnnJQPwH3EYRj+iVYn5WkQQtJvsQnbdiBk8Lcq9 vqd1EtUGdDNxcsAckUpXwFM= X-Google-Smtp-Source: ACHHUZ6mLLpZ2jzgBbisqW8BsQ34AJIZtXtyRLGlK/Pv18m3vLOsDnG3vORq9yee5CR+W4060ihrFA== X-Received: by 2002:a05:6512:313c:b0:4f9:566f:1aab with SMTP id p28-20020a056512313c00b004f9566f1aabmr3597524lfd.29.1687407919067; Wed, 21 Jun 2023 21:25:19 -0700 (PDT) Received: from ?IPV6:2a0b:e7c0:0:107::aaaa:59? ([2a0b:e7c0:0:107::aaaa:59]) by smtp.gmail.com with ESMTPSA id y7-20020a1c4b07000000b003f17848673fsm6553494wma.27.2023.06.21.21.25.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jun 2023 21:25:18 -0700 (PDT) Message-ID: <68038b83-3221-e351-909c-7f2722b612df@kernel.org> Date: Thu, 22 Jun 2023 06:25:15 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH 08/11] sysctl: Add size to register_sysctl_init Content-Language: en-US To: Joel Granados Cc: mcgrof@kernel.org, Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, Theodore Ts'o , "Jason A. Donenfeld" , Greg Kroah-Hartman , Juergen Gross , Stefano Stabellini , Benjamin LaHaise , Alexander Viro , Christian Brauner , Jeff Layton , Chuck Lever , Jan Kara , Kees Cook , Iurii Zaikin , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Balbir Singh , Eric Biederman , "Naveen N. Rao" , Anil S Keshavamurthy , "David S. Miller" , Masami Hiramatsu , Peter Zijlstra , Will Deacon , Petr Mladek , Sergey Senozhatsky , Juri Lelli , Vincent Guittot , Steven Rostedt , Andrew Morton , Mike Kravetz , Muchun Song , Naoya Horiguchi , "Matthew Wilcox (Oracle)" , David Howells , Jarkko Sakkinen , Paul Moore , James Morris , "Serge E. Hallyn" , "H. Peter Anvin" , Oleksandr Tyshchenko , Amir Goldstein , John Fastabend , Martin KaFai Lau , Song Liu , Yonghong Song , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , Waiman Long , Boqun Feng , John Ogness , Dietmar Eggemann , Ben Segall , Mel Gorman , Daniel Bristot de Oliveira , Valentin Schneider , Andy Lutomirski , Will Drewry , Mark Rutland , Miaohe Lin , linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org, linux-aio@kvack.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, kexec@lists.infradead.org, linux-trace-kernel@vger.kernel.org, keyrings@vger.kernel.org, linux-security-module@vger.kernel.org References: <20230621091000.424843-1-j.granados@samsung.com> <20230621091000.424843-9-j.granados@samsung.com> <36fae2b0-4cd2-58b5-cc12-9abdd5ce235b@kernel.org> <20230621131147.c3jegl4hgjplcrpu@localhost> From: Jiri Slaby In-Reply-To: <20230621131147.c3jegl4hgjplcrpu@localhost> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230621_212521_641080_37ECCC6C X-CRM114-Status: GOOD ( 18.18 ) X-Mailman-Approved-At: Wed, 28 Jun 2023 08:16:38 -0700 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org On 21. 06. 23, 15:11, Joel Granados wrote: > On Wed, Jun 21, 2023 at 11:56:03AM +0200, Jiri Slaby wrote: >> On 21. 06. 23, 11:09, Joel Granados wrote: >>> In order to remove the end element from the ctl_table struct arrays, we >>> explicitly define the size when registering the targes. We add a size >>> argument to the register_sysctl_init call and pass an ARRAY_SIZE for all >>> the callers. >> >> Hi, I am missing here (or in 00/00) _why_ you are doing that. Is it by a > Not sure what happened. I used the kernels get_maintainers.pl script > together with git-send-email. These are my settings: > > " > tocmd ="`pwd`/scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --m --nol --nor" > cccmd ="`pwd`/scripts/get_maintainer.pl --nogit --nogit-fallback --norolestats --l --r --nom" > " > > Could it be that there is an error in MAINTAINERS? Sorry, I don't see what you are asking about. I was asking about motivation behind the series. That is a must in commit logs. thanks, -- js suse labs _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec