From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 6783CC0218A for ; Thu, 30 Jan 2025 17:01:37 +0000 (UTC) Received: from list by lists.xenproject.org with outflank-mailman.879713.1289926 (Exim 4.92) (envelope-from ) id 1tdXuk-0003DP-By; Thu, 30 Jan 2025 17:01:14 +0000 X-Outflank-Mailman: Message body and most headers restored to incoming version Received: by outflank-mailman (output) from mailman id 879713.1289926; Thu, 30 Jan 2025 17:01:14 +0000 Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tdXuk-0003DI-9D; Thu, 30 Jan 2025 17:01:14 +0000 Received: by outflank-mailman (input) for mailman id 879713; Thu, 30 Jan 2025 17:01:13 +0000 Received: from se1-gles-sth1-in.inumbo.com ([159.253.27.254] helo=se1-gles-sth1.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.92) (envelope-from ) id 1tdXuj-0003DC-9z for xen-devel@lists.xenproject.org; Thu, 30 Jan 2025 17:01:13 +0000 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [2a00:1450:4864:20::62e]) by se1-gles-sth1.inumbo.com (Halon) with ESMTPS id cf0b3c29-df2b-11ef-a0e6-8be0dac302b0; Thu, 30 Jan 2025 18:01:12 +0100 (CET) Received: by mail-ej1-x62e.google.com with SMTP id a640c23a62f3a-a9e44654ae3so172978066b.1 for ; Thu, 30 Jan 2025 09:01:12 -0800 (PST) Received: from [10.156.60.236] (ip-037-024-206-209.um08.pools.vodafone-ip.de. [37.24.206.209]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab6e47a7ebdsm151171066b.19.2025.01.30.09.01.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 Jan 2025 09:01:06 -0800 (PST) X-BeenThere: xen-devel@lists.xenproject.org List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xenproject.org Precedence: list Sender: "Xen-devel" X-Inumbo-ID: cf0b3c29-df2b-11ef-a0e6-8be0dac302b0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1738256472; x=1738861272; darn=lists.xenproject.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=H/qZZhv7zDkl6dxtuVktJfjHqNt+FWfiYLykCxjLw8E=; b=M5odwVHP21Gelb90mGVyvkn2/vq653+B0kcRuwgKwaRY9sJoPP4ox99JkGhEeOe46U Mgh/I8Pc0Ur0ktum2yaArwiVn0HWfzVAVHCIPSkHAlGTRPMbgjt1i5/R6EOuiLpYeC3E 27Zl8QQNvvptSZgbxoP9shKM8SRmpXW6ai4IDk6D04b2kQL43T7NcQ7EXefmbjVowUkD Mi3HEUxmvT0JAm8kpVyKmm/XeedfRSW1G1DFyx67me5lDUbNkfYaERQ11EDsVstORN6K 8sfg9wmIHWWDGMymmAbGqE7zNGM9dH0lruDYuc+wW2r0AXROx698sNPHqfjvq8UwsV5W 2c2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1738256472; x=1738861272; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=H/qZZhv7zDkl6dxtuVktJfjHqNt+FWfiYLykCxjLw8E=; b=T7nyoXTeIEqO0xLhUHT7VguIHrOyo3sXFTKJajr2koqUB4wxbVquf+peF3glufDST4 0rLA4ZbtxleGth+AmYG2Lw+xLTw9qp4r/rkd5u0yNq+if0iX8wrt18aBD0Ndt0SvET1i qm5vDvlj9Z2ci1wnVmxmALkwBES26dyQ7LAcSfHQvf3DCqA2UfIa1jIG6YZ4izcbOn5D 4YF+UFTnyFEK5nrmTf7UJQ7b/C9VDTOLK10l7eSuIqLJrhZYrskiOE9LxOiiMhVP9sqf jHR4dIx692pqVapBhf22zdIXgsyat+7cXUneItRapeh/GjPH/f4tAFuw5nZhZeabRwQP ISdA== X-Forwarded-Encrypted: i=1; AJvYcCVrniZc3/L0gFmfXWj5URzbrYszlVipQH4OmyXH7trw8hm62uc1tcRv/vgMXAv5Ii8pXDU2/k5zOd8=@lists.xenproject.org X-Gm-Message-State: AOJu0YxWHgJOAW21UQelqbGYRbp4dFVRjvu1rG4x9mLdFltV/t1dIb+t ztN81bNw87Q/BVgwXXgxkkontV0Mf/1kERdbU6azCTW3eAEsY8cp+/M7inC/BQ== X-Gm-Gg: ASbGncukKEOwg6ZhOiov/lzaBjRuxC7sZ3ElX7jVzogPm5OUz2u8KwfLRojz56rC8b5 +KGFSuVNKGBT5Tx8+xhiY4BaXXIaumbsn8AD8pQxHc5qcgbPiF8gGzD5w5qiZnNSZtqj26RobaR DItD8h4ALkRslH/Qv/U4agmAqUSsFQTNKDsozvV6G3Gw5UGLJmLnMPIylcD6dEb1wLfHwLgPKsC 0r4zpV3ylVCkJnuKXjw3rKGen/qIlTcworE4mRKS10EQVtsMdTnmKduGq0JvnsVB335+S7aUgqY D4BQftlcbmkGkCt/wulFsS8H2c7Hws/+HSiKNWYbP7+7IrJ7r/eXInGXk7JtEMz4QFLVcdRwGqJ x X-Google-Smtp-Source: AGHT+IGhfuAItdSHr2MvZhq+UICA5QmfbL77u6Bzy9o9QGkgc7O2vmchyiShAsWBvacRT3kjV1Q8ag== X-Received: by 2002:a17:907:c24c:b0:ab6:e10e:2f5 with SMTP id a640c23a62f3a-ab6e10e06e6mr426508966b.37.1738256466723; Thu, 30 Jan 2025 09:01:06 -0800 (PST) Message-ID: <6806b3cd-aebd-4c18-ba34-783d6faa9529@suse.com> Date: Thu, 30 Jan 2025 18:01:04 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 13/15] x86/hyperlaunch: add memory parsing to domain config To: "Daniel P. Smith" Cc: jason.andryuk@amd.com, christopher.w.clark@gmail.com, stefano.stabellini@amd.com, Andrew Cooper , =?UTF-8?Q?Roger_Pau_Monn=C3=A9?= , Stefano Stabellini , Julien Grall , Bertrand Marquis , Michal Orzel , xen-devel@lists.xenproject.org References: <20241226165740.29812-1-dpsmith@apertussolutions.com> <20241226165740.29812-14-dpsmith@apertussolutions.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: <20241226165740.29812-14-dpsmith@apertussolutions.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 26.12.2024 17:57, Daniel P. Smith wrote: > --- a/xen/arch/x86/dom0_build.c > +++ b/xen/arch/x86/dom0_build.c > @@ -609,6 +609,14 @@ int __init construct_dom0(struct boot_domain *bd) > > process_pending_softirqs(); > > + /* If param dom0_size was not set and HL config provided memory size */ > + if ( !get_memsize(&dom0_size, LONG_MAX) && bd->mem_pages ) > + dom0_size.nr_pages = bd->mem_pages; > + if ( !get_memsize(&dom0_min_size, LONG_MAX) && bd->min_pages ) > + dom0_size.nr_pages = bd->min_pages; > + if ( !get_memsize(&dom0_max_size, LONG_MAX) && bd->max_pages ) > + dom0_size.nr_pages = bd->max_pages; Again I don't think it should be mix-and-match: Either everything is taken from DT, or everything is taken from the command line. Yet I'm open to be convinced otherwise. > --- a/xen/include/xen/libfdt/libfdt-xen.h > +++ b/xen/include/xen/libfdt/libfdt-xen.h > @@ -37,6 +37,15 @@ static inline int __init fdt_prop_as_u32( > return fdt_cell_as_u32((fdt32_t *)prop->data, val); > } > > +static inline int __init fdt_prop_as_u64( > + const struct fdt_property *prop, uint64_t *val) > +{ > + if ( !prop || fdt32_to_cpu(prop->len) < sizeof(u64) ) No new uses of u64 (and alike) please. Jan