From: David Ahern <dsahern@gmail.com>
To: Chris Mi <chrism@mellanox.com>, netdev@vger.kernel.org
Cc: gerlitz.or@gmail.com, stephen@networkplumber.org,
marcelo.leitner@gmail.com, phil@nwl.cc
Subject: Re: [patch iproute2 v10 0/2] tc: Add batchsize feature to batch mode
Date: Mon, 15 Jan 2018 09:40:39 -0700 [thread overview]
Message-ID: <680aeeb2-b151-c746-bb3b-502491908373@gmail.com> (raw)
In-Reply-To: <20180112051316.30220-1-chrism@mellanox.com>
On 1/11/18 10:13 PM, Chris Mi wrote:
> Currently in tc batch mode, only one command is read from the batch
> file and sent to kernel to process. With this patchset, at most 128
> commands can be accumulated before sending to kernel.
>
> We introduced a new function in patch 1 to support for sending
> multiple messages. In patch 2, we add this support for filter
> add/delete/change/replace and actions add/change/replace commands.
>
> But please note that kernel still processes the requests one by one.
> To process the requests in parallel in kernel is another effort.
> The time we're saving in this patchset is the user mode and kernel mode
> context switch. So this patchset works on top of the current kernel.
>
> Using the following script in kernel, we can generate 1,000,000 rules.
> tools/testing/selftests/tc-testing/tdc_batch.py
>
> Without this patchset, 'tc -b $file' exection time is:
>
> real 0m15.555s
> user 0m7.211s
> sys 0m8.284s
>
> With this patchset, 'tc -b $file' exection time is:
>
> real 0m12.360s
> user 0m6.082s
> sys 0m6.213s
>
> The insertion rate is improved more than 10%.
LGTM. Applied to iproute2-next.
next prev parent reply other threads:[~2018-01-15 16:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-12 5:13 [patch iproute2 v10 0/2] tc: Add batchsize feature to batch mode Chris Mi
2018-01-12 5:13 ` [patch iproute2 v10 1/2] lib/libnetlink: Add a new function rtnl_talk_iov Chris Mi
2018-01-12 5:13 ` [patch iproute2 v10 2/2] tc: Add batchsize feature for filter and actions Chris Mi
2018-01-15 16:40 ` David Ahern [this message]
2018-01-16 1:44 ` [patch iproute2 v10 0/2] tc: Add batchsize feature to batch mode Chris Mi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=680aeeb2-b151-c746-bb3b-502491908373@gmail.com \
--to=dsahern@gmail.com \
--cc=chrism@mellanox.com \
--cc=gerlitz.or@gmail.com \
--cc=marcelo.leitner@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=phil@nwl.cc \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.