From: Krzysztof Kozlowski <krzk@kernel.org>
To: muhammad.nazim.amirul.nazle.asmade@altera.com,
dinguyen@kernel.org, maxime.chevallier@bootlin.com
Cc: rmk+kernel@armlinux.org.uk, krzk+dt@kernel.org,
conor+dt@kernel.org, robh@kernel.org, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
andrew+netdev@lunn.ch, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v5 3/4] dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible
Date: Mon, 17 Aug 2026 17:46:59 +0200 [thread overview]
Message-ID: <68178381-808a-4c0e-9bbc-5943f333dba4@kernel.org> (raw)
In-Reply-To: <20260817030213.6769-4-muhammad.nazim.amirul.nazle.asmade@altera.com>
On 17/08/2026 05:02, muhammad.nazim.amirul.nazle.asmade@altera.com wrote:
> From: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
>
> The Agilex5 SoCDK TSN Config2 gmac1 path includes an FPGA soft-IP
> GMII-to-RGMII converter between the DWXGMAC and the PHY. The converter
> provides the RGMII TX/RX delays and presents GMII toward the MAC, unlike
> a plain altr,socfpga-stmmac-agilex5 port with no such converter.
>
> Add altr,socfpga-stmmac-agilex5-tsn for that integration. It is not
> listed as compatible with altr,socfpga-stmmac-agilex5 because the
> converter presents GMII to the MAC and supplies the RGMII delays,
> unlike a plain Agilex5 GMAC port.
>
> Signed-off-by: Nazim Amirul <muhammad.nazim.amirul.nazle.asmade@altera.com>
> ---
> v5: Drop altr,socfpga-stmmac-agilex5 fallback and rewrite commit message
> to explain hardware incompatibility, per Krzysztof Kozlowski.
> v4: No changes from v2.
>
> .../devicetree/bindings/net/altr,socfpga-stmmac.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> index 63084f762373..7db6a7102994 100644
> --- a/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> +++ b/Documentation/devicetree/bindings/net/altr,socfpga-stmmac.yaml
> @@ -24,6 +24,7 @@ select:
> - altr,socfpga-stmmac
> - altr,socfpga-stmmac-a10-s10
> - altr,socfpga-stmmac-agilex5
> + - altr,socfpga-stmmac-agilex5-tsn
>
> required:
> - compatible
> @@ -46,6 +47,9 @@ properties:
> - items:
> - const: altr,socfpga-stmmac-agilex5
> - const: snps,dwxgmac-2.10
> + - items:
> + - const: altr,socfpga-stmmac-agilex5-tsn
So this should be part of enum of earlier list of
altr,socfpga-stmmac-agilex5.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-08-17 15:47 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 3:02 [PATCH v5 0/4] Add Agilex5 SoCDK TSN Config2 board support muhammad.nazim.amirul.nazle.asmade
2026-08-17 3:02 ` [PATCH v5 1/4] dt-bindings: arm: altera: Add Agilex5 SoCDK TSN Config2 board muhammad.nazim.amirul.nazle.asmade
2026-08-17 3:02 ` [PATCH v5 2/4] arm64: dts: socfpga: agilex5: Add " muhammad.nazim.amirul.nazle.asmade
2026-08-18 3:02 ` sashiko-bot
2026-08-17 3:02 ` [PATCH v5 3/4] dt-bindings: net: altr,socfpga-stmmac: Add altr,socfpga-stmmac-agilex5-tsn compatible muhammad.nazim.amirul.nazle.asmade
2026-08-17 15:46 ` Krzysztof Kozlowski [this message]
2026-08-18 3:02 ` sashiko-bot
2026-08-17 3:02 ` [PATCH net-next v5 4/4] net: stmmac: dwmac-socfpga: Add support for Agilex5 TSN GMAC with FPGA converter muhammad.nazim.amirul.nazle.asmade
2026-08-17 15:42 ` Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68178381-808a-4c0e-9bbc-5943f333dba4@kernel.org \
--to=krzk@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dinguyen@kernel.org \
--cc=edumazet@google.com \
--cc=krzk+dt@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=muhammad.nazim.amirul.nazle.asmade@altera.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.