From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arnd Bergmann Subject: Re: [PATCH v3 1/3] tty: serial core: provide a method to search uart by phandle Date: Fri, 16 Oct 2015 21:05:11 +0200 Message-ID: <6829927.BRrJSMeG05@wuerfel> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "H. Nikolaus Schaller" Cc: Jiri Slaby , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jonathan Corbet , Sergei Zviagintsev , Peter Hurley , One Thousand Gnomes , Sebastian Reichel , NeilBrown , Grant Likely , LKML , linux-serial-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Marek Belisko , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-doc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-serial@vger.kernel.org On Friday 16 October 2015 20:08:33 H. Nikolaus Schaller wrote: > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/slaves.txt > @@ -0,0 +1,16 @@ > +Device-Tree bindings for UART slave devices > + > +A node describing a slave device defines a phandle to reference the UART > +the device is connected to. In the (unexpected) case of two or more UARTs > +a list of phandles can be specified. > + > +properties: > + - uart: (list of) phandle(s) of UART(s) the device is connected to > + > + > +example: > + > + gps { > + compatible = "wi2wi,w2sg0004"; > + uart = <&uart1>; > + }; > I would have expected the gps device here to be a child node of the uart in DT. Can you explain why you chose differently? Arnd -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754408AbbJPTFx (ORCPT ); Fri, 16 Oct 2015 15:05:53 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:54004 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752345AbbJPTFk (ORCPT ); Fri, 16 Oct 2015 15:05:40 -0400 From: Arnd Bergmann To: "H. Nikolaus Schaller" Cc: Jiri Slaby , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Jonathan Corbet , Sergei Zviagintsev , Peter Hurley , One Thousand Gnomes , Sebastian Reichel , NeilBrown , Grant Likely , LKML , linux-serial@vger.kernel.org, Marek Belisko , devicetree@vger.kernel.org, linux-doc@vger.kernel.org Subject: Re: [PATCH v3 1/3] tty: serial core: provide a method to search uart by phandle Date: Fri, 16 Oct 2015 21:05:11 +0200 Message-ID: <6829927.BRrJSMeG05@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:xw+zTdXgxHbsimG6lwxjx1cPKvEYcjx4EFNE3Nl8WGdlxgOiYv0 e5VBZKDgIK+In1Lp7I6Zd2ZPMYIRYeJmbT6U0OhtYNfdFe3BPDEc3mLRUhWlndWjVAesJQT CyW0dlaTE+4uBk9wXn04S8iteL8+qIdIaAv9Yzc4Dg3TNDfDb3WHr4rTLPQf9dCSz5NFQxg HqZKQ0f66F7LfmnKRtZ4g== X-UI-Out-Filterresults: notjunk:1;V01:K0:uhn841WQW/4=:gpmZ1uMf8PFZ8doS7wGauQ 7ds78/mRo40KX2B94DR5dQImhd1O1PSnrOscEoMvNEa/TcRJOiBzwfTpxHSbni9lYBoWxcMxe fDZ2hW5f6hp5nC/IdpMaBQZgUduO1y9oNzeui3uB4a2/Anchfh29570MlHKfQ5AAjA95xM2nX wUFO2IRe0BV9HUC8K9YqN/rzwj7ckeVRJ5/8J1IXuhJTk3db4EbVGE88cevn1HFPZmGRzmFCe s0ax7Db+MOIBfiZ20CLKSdV7BT/XjVv9oQ3O2HBL/CX7CZkYcN6uE0ayEyZYTe/BFIlLJxf08 kTVvszilzk8hu/gnzSlWBB5eKwpWp+s1oyteql4Y8z+Vb4oulqiXsL27IOK6TqmECjEz9kIFE 3Kg/6+4qIJ/6iUv/i0RiC/Rg1n8xvzoERKzLsJPnHWtGRKPIve5CJy0IhW3ndH8wa/8XXu8ho TZeuWYmprRhW7/KxmvbIG3JnNYAorUGzmJsDehVx25M9hbLV0WBYHyzgaMwZZomKK+GuVulYj o9SMJ0dyeKp58ziwn8OaWuKuJP0ASPl1tw3Na5UjbltrJlA83YGZ4rSTOmPWj0R4zacqoV+dt /wN3CLmYN+IklxcJ3Roi/PjOaJHYTafaHoJ2Fr2lVVMPIiciyV+Iy0MEmJx5phM8U9Z8AT5Sy Dxt7v+cGgl1VGZUgqlJlpwqeuA8UFtlHCAFaP6sQ57ozE3/UEDeZ9INQzaGQ0y9q3DQTyU3Ny AZf9CW2DphEJC+Bd Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 16 October 2015 20:08:33 H. Nikolaus Schaller wrote: > --- /dev/null > +++ b/Documentation/devicetree/bindings/serial/slaves.txt > @@ -0,0 +1,16 @@ > +Device-Tree bindings for UART slave devices > + > +A node describing a slave device defines a phandle to reference the UART > +the device is connected to. In the (unexpected) case of two or more UARTs > +a list of phandles can be specified. > + > +properties: > + - uart: (list of) phandle(s) of UART(s) the device is connected to > + > + > +example: > + > + gps { > + compatible = "wi2wi,w2sg0004"; > + uart = <&uart1>; > + }; > I would have expected the gps device here to be a child node of the uart in DT. Can you explain why you chose differently? Arnd