From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Wed, 05 Sep 2018 23:50:25 +0300 Subject: [PATCH 3/6] dt-bindings: display: add data-enable polarity property In-Reply-To: References: <20180905052113.21262-1-stefan@agner.ch> <139651706.L0sBFfZMDQ@avalon> Message-ID: <6830776.vZAoroGVFQ@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Stefan, On Wednesday, 5 September 2018 21:10:08 EEST Stefan Agner wrote: > On 05.09.2018 00:07, Laurent Pinchart wrote: > > On Wednesday, 5 September 2018 08:21:10 EEST Stefan Agner wrote: > >> Allow to specify the data-enable polarity required by a dumb VGA > >> DAC converting parallel RGB to VGA. > >> > >> Signed-off-by: Stefan Agner > >> --- > >> > >> .../devicetree/bindings/display/bridge/dumb-vga-dac.txt | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > >> b/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt index > >> 164cbb15f04c..adbd2ca0af2f 100644 > >> --- a/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > >> +++ b/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > >> @@ -18,6 +18,7 @@ graph bindings specified in > >> Documentation/devicetree/bindings/graph.txt. > >> > >> Optional properties: > >> - vdd-supply: Power supply for DAC > >> > >> +- de-active: data-enable pulse is active low/high/ignored > > > > Which value corresponds to low, high and ignored ? > > The wording is taken from > Documentation/devicetree/bindings/display/panel/display-timing.txt. But > I agree, not very useful. > > 0 is low active, 1 is high active, and none is using driver defaults. > > How about: > - de-active: data-enable pulse is 0=active low/1=active high The data enable signal isn't really a pulse. I would word this as - de-active: Polarity of the data enable signal. 0 for active low, 1 for active high, unset for system-specific defaults. > >> Example > >> ------- -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH 3/6] dt-bindings: display: add data-enable polarity property Date: Wed, 05 Sep 2018 23:50:25 +0300 Message-ID: <6830776.vZAoroGVFQ@avalon> References: <20180905052113.21262-1-stefan@agner.ch> <139651706.L0sBFfZMDQ@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Stefan Agner Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, max.krummenacher@toradex.com, kernel@pengutronix.de, marcel.ziswiler@toradex.com, airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, robh+dt@kernel.org, linux-imx@nxp.com, fabio.estevam@nxp.com, sean@poorly.run, shawnguo@kernel.org, linux-arm-kernel@lists.infradead.org List-Id: devicetree@vger.kernel.org SGkgU3RlZmFuLAoKT24gV2VkbmVzZGF5LCA1IFNlcHRlbWJlciAyMDE4IDIxOjEwOjA4IEVFU1Qg U3RlZmFuIEFnbmVyIHdyb3RlOgo+IE9uIDA1LjA5LjIwMTggMDA6MDcsIExhdXJlbnQgUGluY2hh cnQgd3JvdGU6Cj4gPiBPbiBXZWRuZXNkYXksIDUgU2VwdGVtYmVyIDIwMTggMDg6MjE6MTAgRUVT VCBTdGVmYW4gQWduZXIgd3JvdGU6Cj4gPj4gQWxsb3cgdG8gc3BlY2lmeSB0aGUgZGF0YS1lbmFi bGUgcG9sYXJpdHkgcmVxdWlyZWQgYnkgYSBkdW1iIFZHQQo+ID4+IERBQyBjb252ZXJ0aW5nIHBh cmFsbGVsIFJHQiB0byBWR0EuCj4gPj4gCj4gPj4gU2lnbmVkLW9mZi1ieTogU3RlZmFuIEFnbmVy IDxzdGVmYW5AYWduZXIuY2g+Cj4gPj4gLS0tCj4gPj4gCj4gPj4gIC4uLi9kZXZpY2V0cmVlL2Jp bmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2R1bWItdmdhLWRhYy50eHQgICAgICAgICAgfCAxICsKPiA+ PiAgMSBmaWxlIGNoYW5nZWQsIDEgaW5zZXJ0aW9uKCspCj4gPj4gCj4gPj4gZGlmZiAtLWdpdAo+ ID4+IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2R1 bWItdmdhLWRhYy50eHQKPiA+PiBiL0RvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9k aXNwbGF5L2JyaWRnZS9kdW1iLXZnYS1kYWMudHh0IGluZGV4Cj4gPj4gMTY0Y2JiMTVmMDRjLi5h ZGJkMmNhMGFmMmYgMTAwNjQ0Cj4gPj4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2Jp bmRpbmdzL2Rpc3BsYXkvYnJpZGdlL2R1bWItdmdhLWRhYy50eHQKPiA+PiArKysgYi9Eb2N1bWVu dGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvZGlzcGxheS9icmlkZ2UvZHVtYi12Z2EtZGFjLnR4 dAo+ID4+IEBAIC0xOCw2ICsxOCw3IEBAIGdyYXBoIGJpbmRpbmdzIHNwZWNpZmllZCBpbgo+ID4+ IERvY3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9ncmFwaC50eHQuCj4gPj4gCj4gPj4g IE9wdGlvbmFsIHByb3BlcnRpZXM6Cj4gPj4gIC0gdmRkLXN1cHBseTogUG93ZXIgc3VwcGx5IGZv ciBEQUMKPiA+PiAKPiA+PiArLSBkZS1hY3RpdmU6IGRhdGEtZW5hYmxlIHB1bHNlIGlzIGFjdGl2 ZSBsb3cvaGlnaC9pZ25vcmVkCj4gPiAKPiA+IFdoaWNoIHZhbHVlIGNvcnJlc3BvbmRzIHRvIGxv dywgaGlnaCBhbmQgaWdub3JlZCA/Cj4gCj4gVGhlIHdvcmRpbmcgaXMgdGFrZW4gZnJvbQo+IERv Y3VtZW50YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9kaXNwbGF5L3BhbmVsL2Rpc3BsYXktdGlt aW5nLnR4dC4gQnV0Cj4gSSBhZ3JlZSwgbm90IHZlcnkgdXNlZnVsLgo+IAo+IDAgaXMgbG93IGFj dGl2ZSwgMSBpcyBoaWdoIGFjdGl2ZSwgYW5kIG5vbmUgaXMgdXNpbmcgZHJpdmVyIGRlZmF1bHRz Lgo+IAo+IEhvdyBhYm91dDoKPiAtIGRlLWFjdGl2ZTogZGF0YS1lbmFibGUgcHVsc2UgaXMgMD1h Y3RpdmUgbG93LzE9YWN0aXZlIGhpZ2gKClRoZSBkYXRhIGVuYWJsZSBzaWduYWwgaXNuJ3QgcmVh bGx5IGEgcHVsc2UuIEkgd291bGQgd29yZCB0aGlzIGFzCgotIGRlLWFjdGl2ZTogUG9sYXJpdHkg b2YgdGhlIGRhdGEgZW5hYmxlIHNpZ25hbC4gMCBmb3IgYWN0aXZlIGxvdywgMSBmb3IgCmFjdGl2 ZSBoaWdoLCB1bnNldCBmb3Igc3lzdGVtLXNwZWNpZmljIGRlZmF1bHRzLgoKPiA+PiAgRXhhbXBs ZQo+ID4+ICAtLS0tLS0tCgotLSAKUmVnYXJkcywKCkxhdXJlbnQgUGluY2hhcnQKCgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxp bmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 14A40C433F5 for ; Wed, 5 Sep 2018 20:50:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id A89712073D for ; Wed, 5 Sep 2018 20:50:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ideasonboard.com header.i=@ideasonboard.com header.b="Pcn9QpmY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A89712073D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ideasonboard.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727752AbeIFBWQ (ORCPT ); Wed, 5 Sep 2018 21:22:16 -0400 Received: from perceval.ideasonboard.com ([213.167.242.64]:33754 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727234AbeIFBWQ (ORCPT ); Wed, 5 Sep 2018 21:22:16 -0400 Received: from avalon.localnet (unknown [IPv6:2a02:a03f:4407:cd00:1953:677d:5909:a7be]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 3504E119E; Wed, 5 Sep 2018 22:50:19 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1536180619; bh=7rbWdbWTKex0+qtSwIK+amJ0MYKJoWEGQNQ64UinKq8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pcn9QpmYPjmvIO549mCTBOcKr0mTs825e9DvcH256X8W0wL1xJ5f3KIiFH1uoyeK7 cWVL5GmAhT1HTv3BFMVciUDc9EHuJUhHVw4TEzQ2RrmhABRpxYRU2dG1ePhBukZjbn ZGqNPWt0fZw8lleqZrxX0pgNfpczgoYqs8KtYD9I= From: Laurent Pinchart To: Stefan Agner Cc: linus.walleij@linaro.org, airlied@linux.ie, robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, s.hauer@pengutronix.de, p.zabel@pengutronix.de, kernel@pengutronix.de, fabio.estevam@nxp.com, linux-imx@nxp.com, architt@codeaurora.org, a.hajda@samsung.com, gustavo@padovan.org, maarten.lankhorst@linux.intel.com, sean@poorly.run, marcel.ziswiler@toradex.com, max.krummenacher@toradex.com, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/6] dt-bindings: display: add data-enable polarity property Date: Wed, 05 Sep 2018 23:50:25 +0300 Message-ID: <6830776.vZAoroGVFQ@avalon> Organization: Ideas on Board Oy In-Reply-To: References: <20180905052113.21262-1-stefan@agner.ch> <139651706.L0sBFfZMDQ@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Stefan, On Wednesday, 5 September 2018 21:10:08 EEST Stefan Agner wrote: > On 05.09.2018 00:07, Laurent Pinchart wrote: > > On Wednesday, 5 September 2018 08:21:10 EEST Stefan Agner wrote: > >> Allow to specify the data-enable polarity required by a dumb VGA > >> DAC converting parallel RGB to VGA. > >> > >> Signed-off-by: Stefan Agner > >> --- > >> > >> .../devicetree/bindings/display/bridge/dumb-vga-dac.txt | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git > >> a/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > >> b/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt index > >> 164cbb15f04c..adbd2ca0af2f 100644 > >> --- a/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > >> +++ b/Documentation/devicetree/bindings/display/bridge/dumb-vga-dac.txt > >> @@ -18,6 +18,7 @@ graph bindings specified in > >> Documentation/devicetree/bindings/graph.txt. > >> > >> Optional properties: > >> - vdd-supply: Power supply for DAC > >> > >> +- de-active: data-enable pulse is active low/high/ignored > > > > Which value corresponds to low, high and ignored ? > > The wording is taken from > Documentation/devicetree/bindings/display/panel/display-timing.txt. But > I agree, not very useful. > > 0 is low active, 1 is high active, and none is using driver defaults. > > How about: > - de-active: data-enable pulse is 0=active low/1=active high The data enable signal isn't really a pulse. I would word this as - de-active: Polarity of the data enable signal. 0 for active low, 1 for active high, unset for system-specific defaults. > >> Example > >> ------- -- Regards, Laurent Pinchart