From: Thomas Huth <thuth@redhat.com>
To: Cornelia Huck <cornelia.huck@de.ibm.com>
Cc: qemu-devel@nongnu.org, mst@redhat.com
Subject: Re: [Qemu-devel] [PATCH for-2.5] virtio: avoid leading underscores for helpers
Date: Wed, 29 Jul 2015 08:43:08 -0400 (EDT) [thread overview]
Message-ID: <683562692.328057.1438173788965.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <1438172567-28227-1-git-send-email-cornelia.huck@de.ibm.com>
On Wednesday, July 29, 2015 2:22:47 PM, "Cornelia Huck"
<cornelia.huck@de.ibm.com> wrote:
>
> Commit ef546f1275f6563e8934dd5e338d29d9f9909ca6 ("virtio: add
> feature checking helpers") introduced a helper __virtio_has_feature.
> We don't want to use reserved identifiers, though, so let's
> rename __virtio_has_feature to virtio_has_feature and virtio_has_feature
> to virtio_vdev_has_feature.
"virtio_vdev_has_feature" is already a little bit long ... but I also fail
come up with a better name, maybe "virtio_vdev_has_feat" ?
Anyway, the patch also looks fine to me with the long name, so:
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2015-07-29 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 12:22 [Qemu-devel] [PATCH for-2.5] virtio: avoid leading underscores for helpers Cornelia Huck
2015-07-29 12:43 ` Thomas Huth [this message]
2015-07-29 13:05 ` Cornelia Huck
2015-08-13 11:04 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=683562692.328057.1438173788965.JavaMail.zimbra@redhat.com \
--to=thuth@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.