Re: [syzbot] Private message regarding: [syzbot] [ntfs3?] WARNING in ni_rename

[syzbot <syzbot+b0373017f711c06ada64@syzkaller.appspotmail.com>]

For archival purposes, forwarding an incoming command email to
linux-kernel@vger.kernel.org, syzkaller-bugs@googlegroups.com.

***

Subject: Private message regarding: [syzbot] [ntfs3?] WARNING in ni_rename
Author: kapoorarnav43@gmail.com

#syz test: 
git://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master 

From 00325fe8a9658ef0d9e0082dd98c09adc01875fa Mon Sep 17 00:00:00 2001 
From: Arnav Kapoor <kapoorarnav43@gmail.com <https://groups.google.com/>> 
Date: Sun, 29 Jun 2025 15:29:27 +0530 
Subject: [PATCH] ntfs3: log warning instead of WARN_ON in ni_rename cleanup 
failure 

If ni_remove_name fails and undoing ni_add_name also fails, 
replace WARN_ON with a ntfs_warn log and mark the inode bad. 
This keeps the error visible without triggering a kernel warning. 

Reported-by: syzbot+b03730...@syzkaller.appspotmail.com 
<https://groups.google.com/> 
Signed-off-by: Arnav Kapoor <kapoorarnav43@gmail.com 
<https://groups.google.com/>> 
--- 
fs/ntfs3/frecord.c | 2 +- 
1 file changed, 1 insertion(+), 1 deletion(-) 

diff --git a/fs/ntfs3/frecord.c b/fs/ntfs3/frecord.c 
index b7a83200f2cc..xxxxxxxxxxxx 100644 
--- a/fs/ntfs3/frecord.c 
+++ b/fs/ntfs3/frecord.c 
@@ -3029,11 +3029,11 @@ int ni_rename(...) 
if (err && ni_remove_name(new_dir_ni, ni, new_de, &de2, &undo)) { 
ntfs_err(sb, "ni_rename: failed to clean up after add_name failure"); 
*is_bad = true; 
- WARN_ON(err); 
+ ntfs_warn(sb, "ni_rename: incomplete rename cleanup, marking bad"); 
} 

/* 
-- 
2.43.0 


On Tuesday, 1 July 2025 at 05:15:05 UTC+5:30 syzbot wrote:

Hello, 

syzbot tried to test the proposed patch but the build/boot failed: 

failed to apply patch: 
checking file fs/ntfs3/frecord.c 
patch: **** unexpected end of file in patch 



Tested on: 

commit: 1343433e Add linux-next specific files for 20250630 
git tree: linux-next 
kernel config: https://syzkaller.appspot.com/x/.config?x=a3d8d413c6928dae 
dashboard link: https://syzkaller.appspot.com/bug?extid=b0373017f711c06ada64 
compiler: 
patch: https://syzkaller.appspot.com/x/patch.diff?x=174b448c580000