All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Pablo de Lara
	<pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v2] app/test: fix memory needs after RTE_MAX_LCORE was increased to 128
Date: Thu, 11 Dec 2014 02:11:04 +0100	[thread overview]
Message-ID: <6865201.6y9pmue6ZI@xps13> (raw)
In-Reply-To: <1437499.n9ubl6fXCh@xps13>

2014-12-10 15:40, Thomas Monjalon:
> 2014-12-09 10:11, Pablo de Lara:
> > Since commit b91c67e5a693211862aa7dc3b78630b4e856c2af,
> > maximum number of cores is 128, which has increase
> > the total memory necessary for a rte_mempool structure,
> > as the per-lcore local cache has been doubled in size.
> > Therefore, eal_flags unit test was broken since it needed
> > to use more hugepages.
> > 
> > Changes in v2: Increased memory to 18MB, as that is the
> > actual minimum memory necessary (depending on the physical memory segments,
> > DPDK may need less memory)
> > 
> > Signed-off-by: Pablo de Lara <pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 
> Independently of RTE_MAX_LCORE being increased to 128, I still have some
> problems with test_invalid_vdev_flag().
> First, DEFAULT_MEM_SIZE is not used in this function.
> Also, even with your patch, I get this error in my VM:
> 	Cannot get hugepage information
> 
> But if this patch solves an issue for you, I guess it should be applied.
> That said, I would appreciate a complete description of the commands
> you use to launch this test in a VM (starting with the Qemu command).

Applied

I think we should try to improve this test to be able to run it everywhere.

Thanks
-- 
Thomas

  reply	other threads:[~2014-12-11  1:11 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 12:40 [PATCH] app/test: fix memory needs after RTE_MAX_LCORE was increased to 128 Pablo de Lara
     [not found] ` <1417696834-21354-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-04 13:20   ` Thomas Monjalon
2014-12-05 15:57     ` De Lara Guarch, Pablo
2014-12-09 10:11   ` [PATCH v2] " Pablo de Lara
     [not found]     ` <1418119872-15335-1-git-send-email-pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2014-12-10 14:40       ` Thomas Monjalon
2014-12-11  1:11         ` Thomas Monjalon [this message]
2014-12-11  9:56           ` De Lara Guarch, Pablo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6865201.6y9pmue6ZI@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=pablo.de.lara.guarch-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.