From: Thomas Monjalon <thomas@monjalon.net>
To: Gowrishankar <gowrishankar.m@linux.vnet.ibm.com>
Cc: dev@dpdk.org, Chao Zhu <chaozhu@linux.vnet.ibm.com>,
Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [PATCH v2] eal/ppc: fix compilation error with a broken else clause
Date: Tue, 30 Jan 2018 14:46:04 +0100 [thread overview]
Message-ID: <6873526.vGmRUKyOO2@xps> (raw)
In-Reply-To: <d8b28f8d6f340b5b13664362b72cec62dc5ea0ec.1517308613.git.gowrishankar.m@linux.vnet.ibm.com>
30/01/2018 11:53, Gowrishankar:
> From: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
>
> Calling rte_smp_{w/r}mb macro expands into a compound block, which
> would break compiling a else clause following it, if that calling
> place has been terminated already with ";", as in below code.
> This patch adds { } around this macro to allow compiling else too.
>
> Fixes: d23a6bd04d ("eal/ppc: fix memory barrier for IBM POWER")
> Fixes: 05c3fd7110 ("eal/ppc: atomic operations for IBM Power")
>
> Signed-off-by: Gowrishankar Muthukrishnan <gowrishankar.m@linux.vnet.ibm.com>
Applied, thanks
prev parent reply other threads:[~2018-01-30 13:46 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-30 8:48 [PATCH] ring: fix compilation error with a broken else clause Gowrishankar
2018-01-30 8:56 ` Jerin Jacob
2018-01-30 9:09 ` gowrishankar muthukrishnan
2018-01-30 9:13 ` Thomas Monjalon
2018-01-30 10:53 ` [PATCH v2] eal/ppc: " Gowrishankar
2018-01-30 13:46 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6873526.vGmRUKyOO2@xps \
--to=thomas@monjalon.net \
--cc=chaozhu@linux.vnet.ibm.com \
--cc=dev@dpdk.org \
--cc=gowrishankar.m@linux.vnet.ibm.com \
--cc=olivier.matz@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.