From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AA745C6FD18 for ; Tue, 25 Apr 2023 07:37:06 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id C4B4B860FC; Tue, 25 Apr 2023 09:37:03 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=ti.com header.i=@ti.com header.b="PpH5dXaI"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 2481C85B21; Tue, 25 Apr 2023 09:37:02 +0200 (CEST) Received: from fllv0015.ext.ti.com (fllv0015.ext.ti.com [198.47.19.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id A2352860FC for ; Tue, 25 Apr 2023 09:36:58 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=quarantine dis=none) header.from=ti.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=n-francis@ti.com Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33P7akL3001823; Tue, 25 Apr 2023 02:36:46 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1682408206; bh=QoX/bczzT4dpqRIGo8xPOlGUHEjaVxtsVvUcAw8JN4A=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=PpH5dXaIStYoTfixka8BkPbeNcvtpsouNdIZfHPp806Mdu+0J1RtCKzPGaeHOUR+j 5PVcq6GCMSmUKXy0cvDCjsUlcvLmVu2S4kzt9T6nJrj0CfhvDvH2A77YtFjyUjoClC VJd2BgztobQFSSuFbASn9mZ1LbIlkjQg7Scebptk= Received: from DLEE102.ent.ti.com (dlee102.ent.ti.com [157.170.170.32]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33P7akjg065482 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 25 Apr 2023 02:36:46 -0500 Received: from DLEE103.ent.ti.com (157.170.170.33) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Tue, 25 Apr 2023 02:36:46 -0500 Received: from lelv0327.itg.ti.com (10.180.67.183) by DLEE103.ent.ti.com (157.170.170.33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Tue, 25 Apr 2023 02:36:46 -0500 Received: from [172.24.145.195] (ileaxei01-snat.itg.ti.com [10.180.69.5]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33P7agoa110496; Tue, 25 Apr 2023 02:36:43 -0500 Message-ID: <687dad87-b5fa-8694-8323-6f63e46a9bcb@ti.com> Date: Tue, 25 Apr 2023 13:06:42 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 19/19] doc: board: ti: Update documentation for binman flow Content-Language: en-US To: Heinrich Schuchardt , Simon Glass CC: , , , , , , , , Tom Rini References: <20230421123203.1315330-1-n-francis@ti.com> <20230421123203.1315330-20-n-francis@ti.com> <20230424204915.GM1134230@bill-the-cat> <323f74e2-4c31-130f-df9c-6d5517c6f34e@gmx.de> From: Neha Malcom Francis In-Reply-To: <323f74e2-4c31-130f-df9c-6d5517c6f34e@gmx.de> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Heinrich On 25/04/23 11:08, Heinrich Schuchardt wrote: > On 4/24/23 22:49, Tom Rini wrote: >> On Mon, Apr 24, 2023 at 01:42:17PM -0600, Simon Glass wrote: >>> Hi Neha, >>> >>> On Fri, 21 Apr 2023 at 06:33, Neha Malcom Francis >>> wrote: >>>> >>>> Earlier documentation specified builds for generating bootloader images >>>> using an external TI repository k3-image-gen and core-secdev-k3. Modify >>>> this to using the binman flow so that user understands how to build the >>>> final boot images. >>>> >>>> Signed-off-by: Neha Malcom Francis >>>> --- >>>>   doc/board/ti/am62x_sk.rst  | 20 ++++-------- >>>>   doc/board/ti/j721e_evm.rst | 37 ++++++++------------- >>>>   doc/board/ti/k3.rst        | 67 >>>> ++++++++++---------------------------- >>>>   3 files changed, 36 insertions(+), 88 deletions(-) >>> >>> Reviewed-by: Simon Glass >>> >>>> >>>> diff --git a/doc/board/ti/am62x_sk.rst b/doc/board/ti/am62x_sk.rst >>>> index b1b7d99bef..f5e0774899 100644 >>>> --- a/doc/board/ti/am62x_sk.rst >>>> +++ b/doc/board/ti/am62x_sk.rst >>>> @@ -115,23 +115,19 @@ Below is the pictorial representation of boot >>>> flow: >>>> >>>>   Sources: >>>>   -------- >>>> -1. SYSFW: >>>> -       Tree: git://git.ti.com/k3-image-gen/k3-image-gen.git >>>> -       Branch: master >>>> - >>>> -2. ATF: >>>> +1. ATF: >>>>          Tree: https://github.com/ARM-software/arm-trusted-firmware.git >>>>          Branch: master >>>> >>>> -3. OPTEE: >>>> +2. OPTEE: >>>>          Tree: https://github.com/OP-TEE/optee_os.git >>>>          Branch: master >>>> >>>> -4. U-Boot: >>>> +3. U-Boot: >>>>          Tree: https://source.denx.de/u-boot/u-boot >>>>          Branch: master >>>> >>>> -5. TI Linux Firmware: >>>> +4. TI Linux Firmware: >>>>          Tree: >>>> git://git.ti.com/processor-firmware/ti-linux-firmware.git >>>>          Branch: ti-linux-firmware >>>> >>>> @@ -156,18 +152,14 @@ Build procedure: >>>>   .. code-block:: text >>>> >>>>    $ make ARCH=arm CROSS_COMPILE=arm-none-linux-gnueabihf- >>>> am62x_evm_r5_defconfig O=/tmp/r5 >>>> - $ make ARCH=arm CROSS_COMPILE=arm-none-linux-gnueabihf- O=/tmp/r5 >>>> - $ cd >>>> - $ make ARCH=arm CROSS_COMPILE=arm-none-linux-gnueabihf- SOC=am62x >>>> SBL=/tmp/r5/spl/u-boot-spl.bin SYSFW_PATH=>>> ti-linux-firmware>/ti-sysfw/ti-fs-firmware-am62x-gp.bin >>>> - >>>> -Use the tiboot3.bin generated from last command >>>> + $ make ARCH=arm CROSS_COMPILE=arm-none-linux-gnueabihf- O=/tmp/r5 >>>> BINMAN_INDIRS= >>>> >>>>   * 3.2 A53: >>>> >>>>   .. code-block:: text >>>> >>>>    $ make ARCH=arm CROSS_COMPILE=aarch64-none-linux-gnu- >>>> am62x_evm_a53_defconfig O=/tmp/a53 >>>> - $ make ARCH=arm CROSS_COMPILE=aarch64-none-linux-gnu- ATF=>>> ATF dir>/build/k3/lite/release/bl31.bin TEE=>>> dir>/out/arm-plat-k3/core/tee-pager_v2.bin DM=>>> ti-linux-firmware>/ti-dm/am62xx/ipc_echo_testb_mcu1_0_release_strip.xer5f O=/tmp/a53 >>>> + $ make ARCH=arm CROSS_COMPILE=aarch64-none-linux-gnu- BL31=>>> to ATF dir>/build/k3/lite/release/bl31.bin TEE=>>> dir>/out/arm-plat-k3/core/tee-pager_v2.bin >>>> BINMAN_INDIRS= >>>> >>>>   Target Images >>>>   -------------- >>>> diff --git a/doc/board/ti/j721e_evm.rst b/doc/board/ti/j721e_evm.rst >>>> index e898601c41..c90e2b8279 100644 >>>> --- a/doc/board/ti/j721e_evm.rst >>>> +++ b/doc/board/ti/j721e_evm.rst >>>> @@ -130,67 +130,56 @@ support. Below is the pictorial representation >>>> of boot flow: >>>> >>>>   Sources: >>>>   -------- >>>> -1. SYSFW: >>>> -       Tree: git://git.ti.com/k3-image-gen/k3-image-gen.git >>>> -       Branch: master >>>> - >>>> -2. ATF: >>>> +1. ATF: >>>>          Tree: https://github.com/ARM-software/arm-trusted-firmware.git >>>>          Branch: master >>>> >>>> -3. OPTEE: >>>> +2. OPTEE: >>>>          Tree: https://github.com/OP-TEE/optee_os.git >>>>          Branch: master >>>> >>>> -4. DM Firmware: >>>> -       Tree: git://git.ti.com/processor-firmware/ti-linux-firmware.git >>>> -       Branch: ti-linux-firmware >>>> - >>>> -5. U-Boot: >>>> +3. U-Boot: >>>>          Tree: https://source.denx.de/u-boot/u-boot >>>>          Branch: master >>>> >>>> +4. TI Linux Firmware: >>>> +       Tree: git://git.ti.com/processor-firmware/ti-linux-firmware.git >>>> +       Branch: ti-linux-firmware >>>> + >>>>   Build procedure: >>>>   ---------------- >>>> -1. SYSFW: >>>> - >>>> -.. code-block:: bash >>>> - >>>> -    make CROSS_COMPILE=arm-linux-gnueabihf- SOC=j721e >>>> - >>>> -2. ATF: >>>> +1. ATF: >>>> >>>>   .. code-block:: bash >>>> >>>>       make CROSS_COMPILE=aarch64-linux-gnu- ARCH=aarch64 PLAT=k3 >>>> TARGET_BOARD=generic SPD=opteed >>>> >>>> -3. OPTEE: >>>> +2. OPTEE: >>>> >>>>   .. code-block:: bash >>>> >>>>       make PLATFORM=k3-j721e CFG_ARM64_core=y >>>> >>>> -4. U-Boot: >>>> +3. U-Boot: >>>> >>>>   * 4.1 R5: >>>> >>>>   .. code-block:: bash >>>> >>>>       make CROSS_COMPILE=arm-linux-gnueabihf- j721e_evm_r5_defconfig >>>> O=build/r5 > > CROSS_COMPILE is superfluous here. > >>>> -    make CROSS_COMPILE=arm-linux-gnueabihf- O=build/r5 >>>> +    make CROSS_COMPILE=arm-linux-gnueabihf- O=build/r5 >>>> BINMAN_INDIRS= > > Don't we have to indicate the locations of the TF-A binary and SYSFW_PATH? > R5 builds do not require ATF. As for SYSFW_PATH, ti-linux-firmware contains those within ti-sysfw/ which is picked up by binman. >>>> >>>>   * 4.2 A72: >>>> >>>>   .. code-block:: bash >>>> >>>>       make CROSS_COMPILE=aarch64-linux-gnu- j721e_evm_a72_defconfig >>>> O=build/a72 > > CROSS_COMPILE is superfluous here. > >>>> -    make CROSS_COMPILE=aarch64-linux-gnu- ATF=>>> dir>/build/k3/generic/release/bl31.bin TEE=>>> dir>/out/arm-plat-k3/core/tee-pager_v2.bin DM=>>> firmware>/ti-dm/j721e/ipc_echo_testb_mcu1_0_release_strip.xer5f >>>> O=build/a72 >>>> +    make CROSS_COMPILE=aarch64-linux-gnu- BL31=>>> dir>/build/k3/generic/release/bl31.bin TEE=>>> dir>/out/arm-plat-k3/core/tee-pager_v2.bin >>>> BINMAN_INDIRS= > > Where do we indicate SYSFW_PATH? > Please see reply to previous review comment. >>> >>> Is there an 'O=build/a72' missing there? >> >> Not strictly missing, no. One of those style things for Heinrich is, we >> should be consistent in our examples both in terms of O= (when not >> strictly required, it is for the _r5 variant since you must keep some of >> that build for the Cortex-A part, so that you can get something that >> boots the physical machine, in the end). >> >>> You can combine these as well, by using 'j721e_evm_a72_defconfig all' >>> to both configure and build. >>> >>> Also it might be nice to keep the line length shorter if you can. >> >> Other parts for Heinrich to chime in, to have consistent on all the >> board examples. >> > > O= is not really needed outside of 'make tests'. > So I think dropping it from examples is fine if the document in itself > stays consistent. > > We should try to stick to 80 characters per line in documentation for > the sake of readers who read the source (as described in > https://u-boot.readthedocs.io/en/latest/develop/docstyle.html). Even in > HTML pages it is not nice if you have to scroll horizontally to read the > complete command. > > Please, use \ to split the bash command over multiple lines. > Understood, will make those doc changes, thanks! > Best regards > > Heinrich -- Thanking You Neha Malcom Francis