All of lore.kernel.org
 help / color / mirror / Atom feed
From: syzbot <syzbot+8182574047912f805d59@syzkaller.appspotmail.com>
To: ujwal.kundur@gmail.com
Cc: ujwal.kundur@gmail.com, linux-kernel@vger.kernel.org,
	 syzkaller-bugs@googlegroups.com
Subject: Re: team_change_rx flags sleeping with bh disabled
Date: Sun, 27 Jul 2025 10:36:59 -0700	[thread overview]
Message-ID: <688663bb.a00a0220.b12ec.0061.GAE@google.com> (raw)
In-Reply-To: <CALkFLLJ3Vwsb+idOxXrM4mPXOwjf9JwyV1Jg+tFqFhzx3-+v7g@mail.gmail.com>

> #syz test

This crash does not have a reproducer. I cannot test it.

>
> diff --git a/drivers/net/team/team_core.c b/drivers/net/team/team_core.c
> index 8bc56186b2a3..4568075fea6e 100644
> --- a/drivers/net/team/team_core.c
> +++ b/drivers/net/team/team_core.c
> @@ -1778,7 +1778,7 @@ static void team_change_rx_flags(struct
> net_device *dev, int change)
>         struct team_port *port;
>         int inc;
>
> -       mutex_lock(&team->lock);
> +       spin_lock(&team->lock);
>         list_for_each_entry(port, &team->port_list, list) {
>                 if (change & IFF_PROMISC) {
>                         inc = dev->flags & IFF_PROMISC ? 1 : -1;
> @@ -1789,7 +1789,7 @@ static void team_change_rx_flags(struct
> net_device *dev, int change)
>                         dev_set_allmulti(port->dev, inc);
>                 }
>         }
> -       mutex_unlock(&team->lock);
> +       spin_unlock(&team->lock);
>  }
>
>  static void team_set_rx_mode(struct net_device *dev)
> -- 
> 2.30.2

           reply	other threads:[~2025-07-27 17:37 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <CALkFLLJ3Vwsb+idOxXrM4mPXOwjf9JwyV1Jg+tFqFhzx3-+v7g@mail.gmail.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=688663bb.a00a0220.b12ec.0061.GAE@google.com \
    --to=syzbot+8182574047912f805d59@syzkaller.appspotmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=syzkaller-bugs@googlegroups.com \
    --cc=ujwal.kundur@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.