From: David Ahern <dsahern@kernel.org>
To: Petr Machata <petrm@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org
Cc: Simon Horman <horms@kernel.org>, Jonathan Corbet <corbet@lwn.net>,
Przemek Kitszel <przemyslaw.kitszel@intel.com>,
mlxsw@nvidia.com
Subject: Re: [PATCH net] Documentation: networking: Add a caveat to nexthop_compat_mode sysctl
Date: Mon, 9 Dec 2024 09:26:55 -0700 [thread overview]
Message-ID: <688a8d28-fe32-4afd-af0a-5fdbc317e63e@kernel.org> (raw)
In-Reply-To: <b575e32399ccacd09079b2a218255164535123bd.1733740749.git.petrm@nvidia.com>
On 12/9/24 4:05 AM, Petr Machata wrote:
> net.ipv4.nexthop_compat_mode was added when nexthop objects were added to
> provide the view of nexthop objects through the usual lens of the route
> UAPI. As nexthop objects evolved, the information provided through this
> lens became incomplete. For example, details of resilient nexthop groups
> are obviously omitted.
>
> Now that 16-bit nexthop group weights are a thing, the 8-bit UAPI cannot
> convey the >8-bit weight accurately. Instead of inventing workarounds for
> an obsolete interface, just document the expectations of inaccuracy.
>
> Fixes: b72a6a7ab957 ("net: nexthop: Increase weight to u16")
> Signed-off-by: Petr Machata <petrm@nvidia.com>
> ---
> Documentation/networking/ip-sysctl.rst | 6 ++++++
> 1 file changed, 6 insertions(+)
>
Reviewed-by: David Ahern <dsahern@kernel.org>
next prev parent reply other threads:[~2024-12-09 16:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 11:05 [PATCH net] Documentation: networking: Add a caveat to nexthop_compat_mode sysctl Petr Machata
2024-12-09 15:34 ` Ido Schimmel
2024-12-09 16:26 ` David Ahern [this message]
2024-12-11 2:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=688a8d28-fe32-4afd-af0a-5fdbc317e63e@kernel.org \
--to=dsahern@kernel.org \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=mlxsw@nvidia.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=przemyslaw.kitszel@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.