From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6EB74C41514 for ; Sat, 31 Aug 2019 15:54:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4DD9E23429 for ; Sat, 31 Aug 2019 15:54:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728205AbfHaPyR (ORCPT ); Sat, 31 Aug 2019 11:54:17 -0400 Received: from mail-ed1-f65.google.com ([209.85.208.65]:43877 "EHLO mail-ed1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726354AbfHaPyR (ORCPT ); Sat, 31 Aug 2019 11:54:17 -0400 Received: by mail-ed1-f65.google.com with SMTP id w9so1119664edx.10; Sat, 31 Aug 2019 08:54:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AKTao77VaiaPvCbgcc+WiGV1j5w0joNictAVXbGzljc=; b=R4ajDoerMmlECDnQkX99vdNxtcR7cn6zLBKaPiFd6KZCnw06bAe2VDoJ4ArsCyWk8P ZiK8Hbj5v+VF8dctBSwc37WbM8TW8+jThDbNmkiugCVGo3CmL+l8w86zBCAAb5FR60dv VCUMZAudSxbMEMK/JquwOlQE/j7S2pRAcIYJ45HoQcc0E2HiHKnIUKgqmr9O8gg8lR3x ZtVLcXoKlZ1dRPzDopAYXdOb7hi/FOBA+5cMo0Jej3+ZgpMQQV3PMwlfKCyKIG4eLgte VD5WDiaMoCrWLwh8kCl8JGBifF0zOkAZ8crgWekjX0pWD1qDYnKj6v0+1tjW2fBHc3Ud 31QQ== X-Gm-Message-State: APjAAAVv2B3RSpB1gxtnN1XWEGmKpnQvo63WK5qoxTkrWaxACy3R59Cm 5rc35+qpVErn8HRiim3fTKA= X-Google-Smtp-Source: APXvYqyUxiSvMtW/KeHJ5cA0AWsETqOjW7ApTaHBEHBAazWa/5cJ0LHfDHET8v0+ffDbuRqUR6oAiw== X-Received: by 2002:a05:6402:154e:: with SMTP id p14mr21582628edx.101.1567266854794; Sat, 31 Aug 2019 08:54:14 -0700 (PDT) Received: from [10.68.32.192] (broadband-188-32-48-208.ip.moscow.rt.ru. [188.32.48.208]) by smtp.gmail.com with ESMTPSA id i19sm1234644ejf.7.2019.08.31.08.54.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Aug 2019 08:54:14 -0700 (PDT) Subject: Re: [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls To: Markus Elfring , Joe Perches Cc: Andrew Morton , Anton Altaparmakov , Andy Whitcroft , Boris Ostrovsky , Boris Pismenny , "Darrick J. Wong" , "David S. Miller" , Dennis Dalessandro , Dmitry Torokhov , dri-devel@lists.freedesktop.org, Inaky Perez-Gonzalez , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Leon Romanovsky , linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, linux-rdma@vger.kernel.org, linux-wimax@intel.com, linux-xfs@vger.kernel.org, Mike Marciniszyn , netdev@vger.kernel.org, =?UTF-8?Q?Pali_Roh=c3=a1r?= , Rob Clark , Saeed Mahameed , Sean Paul , Alexander Viro , xen-devel@lists.xenproject.org, Enrico Weigelt References: <20190829165025.15750-1-efremov@linux.com> <0d9345ed-f16a-de0b-6125-1f663765eb46@web.de> From: Denis Efremov Message-ID: <689c8baf-2298-f086-3461-5cd1cdd191c6@linux.com> Date: Sat, 31 Aug 2019 18:54:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <0d9345ed-f16a-de0b-6125-1f663765eb46@web.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-arm-msm-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 31.08.2019 12:15, Markus Elfring wrote: >> +# nested likely/unlikely calls >> +        if ($line =~ /\b(?:(?:un)?likely)\s*\(\s*!?\s*(IS_ERR(?:_OR_NULL|_VALUE)?|WARN)/) { >> +            WARN("LIKELY_MISUSE", > > How do you think about to use the specification “(?:IS_ERR(?:_(?:OR_NULL|VALUE))?|WARN)” > in this regular expression? Hmm, (?: <- Catch group is required here, since it is used in diagnostic message, see $1 IS_ERR (?:_ <- Another atomic group just to show that '_' is a common prefix? I'm not sure about this. Usually, Perl interpreter is very good at optimizing such things. You could see this optimization if you run perl with -Mre=debug. (?:OR_NULL|VALUE))?|WARN) Regards, Denis From mboxrd@z Thu Jan 1 00:00:00 1970 From: Denis Efremov Subject: Re: [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls Date: Sat, 31 Aug 2019 18:54:12 +0300 Message-ID: <689c8baf-2298-f086-3461-5cd1cdd191c6@linux.com> References: <20190829165025.15750-1-efremov@linux.com> <0d9345ed-f16a-de0b-6125-1f663765eb46@web.de> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Return-path: In-Reply-To: <0d9345ed-f16a-de0b-6125-1f663765eb46@web.de> Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: Markus Elfring , Joe Perches Cc: Andrew Morton , Anton Altaparmakov , Andy Whitcroft , Boris Ostrovsky , Boris Pismenny , "Darrick J. Wong" , "David S. Miller" , Dennis Dalessandro , Dmitry Torokhov , dri-devel@lists.freedesktop.org, Inaky Perez-Gonzalez , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Leon Romanovsky , linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, linux-rdma@vger.kernel.org, linux-wimax@intel.com List-Id: linux-input@vger.kernel.org On 31.08.2019 12:15, Markus Elfring wrote: >> +# nested likely/unlikely calls >> +        if ($line =~ /\b(?:(?:un)?likely)\s*\(\s*!?\s*(IS_ERR(?:_OR_NULL|_VALUE)?|WARN)/) { >> +            WARN("LIKELY_MISUSE", > > How do you think about to use the specification “(?:IS_ERR(?:_(?:OR_NULL|VALUE))?|WARN)” > in this regular expression? Hmm, (?: <- Catch group is required here, since it is used in diagnostic message, see $1 IS_ERR (?:_ <- Another atomic group just to show that '_' is a common prefix? I'm not sure about this. Usually, Perl interpreter is very good at optimizing such things. You could see this optimization if you run perl with -Mre=debug. (?:OR_NULL|VALUE))?|WARN) Regards, Denis From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AE80DC3A5A6 for ; Sat, 31 Aug 2019 15:55:28 +0000 (UTC) Received: from lists.xenproject.org (lists.xenproject.org [192.237.175.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82F2F21874 for ; Sat, 31 Aug 2019 15:55:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 82F2F21874 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=xen-devel-bounces@lists.xenproject.org Received: from localhost ([127.0.0.1] helo=lists.xenproject.org) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i45hh-0001F3-O6; Sat, 31 Aug 2019 15:54:17 +0000 Received: from all-amaz-eas1.inumbo.com ([34.197.232.57] helo=us1-amaz-eas2.inumbo.com) by lists.xenproject.org with esmtp (Exim 4.89) (envelope-from ) id 1i45hg-0001Ey-O6 for xen-devel@lists.xenproject.org; Sat, 31 Aug 2019 15:54:16 +0000 X-Inumbo-ID: 952ed4d0-cc07-11e9-ae98-12813bfff9fa Received: from mail-ed1-f65.google.com (unknown [209.85.208.65]) by us1-amaz-eas2.inumbo.com (Halon) with ESMTPS id 952ed4d0-cc07-11e9-ae98-12813bfff9fa; Sat, 31 Aug 2019 15:54:15 +0000 (UTC) Received: by mail-ed1-f65.google.com with SMTP id m44so11427628edd.9 for ; Sat, 31 Aug 2019 08:54:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=AKTao77VaiaPvCbgcc+WiGV1j5w0joNictAVXbGzljc=; b=Z7U8G374XV6eWO4Nnm4aY4++WUwpg10LvidVKKGqUuT1EdSdkK1Gtu/MCGJYkXrsqf qXRiwa8IEzXUiqO0/qL/hHHoSF1es5b/2TzJZthQet+inxhgFRso/7jGPrjBKL1R6Zix ZHcg1+XJyBu4JzgYenEJESBvftH/Z8iI4F/V1GprDQYJX0NKyUXW+YnsmrvWmo2a2QeX w2t7rPtf67DZ4NRTv2eG0Pv/UKYxIzBYKD9TBguT6VwB2Lgtkse/CqC/4ydn4u1GtA31 ozdZ4O0SCWeXb5x3qUupyWhu5mIVADzWopURsKgrnobR29BM1aI61fB9v0bfgUuYWJZy 7L5g== X-Gm-Message-State: APjAAAUpSSVG2ts6iCLWSxqBOWMH7kekoNeIN/n+K/RdV+42hPkS94j2 mqjF3vxSxkD62JKl6i+vXI0= X-Google-Smtp-Source: APXvYqyUxiSvMtW/KeHJ5cA0AWsETqOjW7ApTaHBEHBAazWa/5cJ0LHfDHET8v0+ffDbuRqUR6oAiw== X-Received: by 2002:a05:6402:154e:: with SMTP id p14mr21582628edx.101.1567266854794; Sat, 31 Aug 2019 08:54:14 -0700 (PDT) Received: from [10.68.32.192] (broadband-188-32-48-208.ip.moscow.rt.ru. [188.32.48.208]) by smtp.gmail.com with ESMTPSA id i19sm1234644ejf.7.2019.08.31.08.54.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Aug 2019 08:54:14 -0700 (PDT) To: Markus Elfring , Joe Perches References: <20190829165025.15750-1-efremov@linux.com> <0d9345ed-f16a-de0b-6125-1f663765eb46@web.de> From: Denis Efremov Message-ID: <689c8baf-2298-f086-3461-5cd1cdd191c6@linux.com> Date: Sat, 31 Aug 2019 18:54:12 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <0d9345ed-f16a-de0b-6125-1f663765eb46@web.de> Content-Language: en-US Subject: Re: [Xen-devel] [PATCH v3 01/11] checkpatch: check for nested (un)?likely() calls X-BeenThere: xen-devel@lists.xenproject.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Xen developer discussion List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Leon Romanovsky , "Darrick J. Wong" , linux-rdma@vger.kernel.org, Inaky Perez-Gonzalez , Saeed Mahameed , linux-input@vger.kernel.org, xen-devel@lists.xenproject.org, Boris Pismenny , linux-arm-msm@vger.kernel.org, linux-wimax@intel.com, Enrico Weigelt , Alexander Viro , Andy Whitcroft , Boris Ostrovsky , Sean Paul , Anton Altaparmakov , =?UTF-8?B?SsO8cmdlbiBHcm/Dnw==?= , Mike Marciniszyn , linux-ntfs-dev@lists.sourceforge.net, netdev@vger.kernel.org, Dennis Dalessandro , Dmitry Torokhov , linux-kernel@vger.kernel.org, linux-xfs@vger.kernel.org, Rob Clark , =?UTF-8?Q?Pali_Roh=c3=a1r?= , linux-fsdevel@vger.kernel.org, Andrew Morton , "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: xen-devel-bounces@lists.xenproject.org Sender: "Xen-devel" CgpPbiAzMS4wOC4yMDE5IDEyOjE1LCBNYXJrdXMgRWxmcmluZyB3cm90ZToKPj4gKyMgbmVzdGVk IGxpa2VseS91bmxpa2VseSBjYWxscwo+PiArwqDCoMKgwqDCoMKgwqAgaWYgKCRsaW5lID1+IC9c Yig/Oig/OnVuKT9saWtlbHkpXHMqXChccyohP1xzKihJU19FUlIoPzpfT1JfTlVMTHxfVkFMVUUp P3xXQVJOKS8pIHsKPj4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqAgV0FSTigiTElLRUxZX01JU1VT RSIsCj4gCj4gSG93IGRvIHlvdSB0aGluayBhYm91dCB0byB1c2UgdGhlIHNwZWNpZmljYXRpb24g 4oCcKD86SVNfRVJSKD86Xyg/Ok9SX05VTEx8VkFMVUUpKT98V0FSTinigJ0KPiBpbiB0aGlzIHJl Z3VsYXIgZXhwcmVzc2lvbj8KCkhtbSwgCig/OiAgIDwtIENhdGNoIGdyb3VwIGlzIHJlcXVpcmVk IGhlcmUsIHNpbmNlIGl0IGlzIHVzZWQgaW4gZGlhZ25vc3RpYyBtZXNzYWdlLAogICAgICAgICBz ZWUgJDEKICAgSVNfRVJSCiAgICg/Ol8gPC0gQW5vdGhlciBhdG9taWMgZ3JvdXAganVzdCB0byBz aG93IHRoYXQgJ18nIGlzIGEgY29tbW9uIHByZWZpeD8KICAgICAgICAgICBJJ20gbm90IHN1cmUg YWJvdXQgdGhpcy4gVXN1YWxseSwgUGVybCBpbnRlcnByZXRlciBpcyB2ZXJ5IGdvb2QgYXQgb3B0 aW1pemluZyBzdWNoIHRoaW5ncy4KICAgICAgICAgICBZb3UgY291bGQgc2VlIHRoaXMgb3B0aW1p emF0aW9uIGlmIHlvdSBydW4gcGVybCB3aXRoIC1NcmU9ZGVidWcuCiAgICAgKD86T1JfTlVMTHxW QUxVRSkpP3xXQVJOKQoKUmVnYXJkcywKRGVuaXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVsQGxp c3RzLnhlbnByb2plY3Qub3JnCmh0dHBzOi8vbGlzdHMueGVucHJvamVjdC5vcmcvbWFpbG1hbi9s aXN0aW5mby94ZW4tZGV2ZWw=