From: Bart Van Assche <bvanassche@acm.org>
To: Tao Cui <cui.tao@linux.dev>,
axboe@kernel.dk, hch@lst.de,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
Cc: linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
Tao Cui <cuitao@kylinos.cn>
Subject: Re: [PATCH v3] loop: defer the queue limits clear to a workqueue
Date: Fri, 18 Sep 2026 15:33:26 -0700 [thread overview]
Message-ID: <68a0902e-00c2-4d7d-9714-531226bab73c@acm.org> (raw)
In-Reply-To: <20260903013800.1036691-1-cui.tao@linux.dev>
On 9/2/26 6:38 PM, Tao Cui wrote:
> + struct work_struct clear_limits_work;
> + atomic_t clear_limits_mode;
> + atomic_t rebind_gen;
> + atomic_t clear_limits_gen;
Three new atomic variables? That's too much because it makes it much
harder than necessary to verify the code changes. Please change the
atomic variables to non-atomic and use a new mutex to serialize accesses
to the new variables.
Thanks,
Bart.
prev parent reply other threads:[~2026-09-18 22:33 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 1:38 [PATCH v3] loop: defer the queue limits clear to a workqueue Tao Cui
2026-09-18 22:33 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68a0902e-00c2-4d7d-9714-531226bab73c@acm.org \
--to=bvanassche@acm.org \
--cc=axboe@kernel.dk \
--cc=cui.tao@linux.dev \
--cc=cuitao@kylinos.cn \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.