Re: [PATCH mptcp-net v2] mptcp: fix corrupt receiver key in MPC + data + checksum

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]

On Tue, 26 Oct 2021, Mat Martineau wrote:

> On Tue, 26 Oct 2021, Davide Caratti wrote:
>
>> using packetdrill it's possible to observe that the receiver key contains
>> random values when clients transmit MP_CAPABLE with data and checksum (as
>> specified in RFC8684 §3.1). Fix the layout of mptcp_out_options, to avoid
>> using the skb extension copy when writing the MP_CAPABLE sub-option.
>> 
>> Fixes: d7b269083786 ("mptcp: shrink mptcp_out_options struct")
>> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/233
>> Reported-by: Poorva Sonparote <psonparo@redhat.com>
>> Signed-off-by: Davide Caratti <dcaratti@redhat.com>
>> ---
>> 
>> Notes:
>>    v1:
>>     - fix metadata in the commit message (Mat Martineau)
>>     - adjust comment in mptcp_established_options_mp() (Mat Martineau)
>>     - fix sparse warning in __mptcp_make_csum() (Mat Martineau / patchew 
>> CI)
>> 
>
> Thanks Davide, v2 looks good and I confirmed the correct keys in MPC+data 
> with 'mptcp_connect.sh -C'.
>
> Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>
>

Matthieu -

One more thing: If your schedule allows, could you apply this early 
Wednesday? That way CI can complete, and then there's a chance to sync up 
on IRC when our timezones overlap. Hopefully I can send this to netdev in 
the morning (my time), probably the last chance to get it merged for 
v5.15.

--
Mat Martineau
Intel