From: Yang Shi <yang.shi@linux.alibaba.com>
To: Vlastimil Babka <vbabka@suse.cz>, Michal Hocko <mhocko@kernel.org>
Cc: akpm@linux-foundation.org, mgorman@techsingularity.net,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] mm: mempolicy: handle vma with unmovable pages mapped correctly in mbind
Date: Wed, 19 Jun 2019 09:39:48 -0700 [thread overview]
Message-ID: <68b67faf-d1c3-bc36-3db4-c86c6dfd8f11@linux.alibaba.com> (raw)
In-Reply-To: <2c30d86f-43e4-f43c-411d-c916fb1de44e@suse.cz>
On 6/19/19 1:18 AM, Vlastimil Babka wrote:
> On 6/18/19 7:06 PM, Yang Shi wrote:
>> The BUG_ON was removed by commit
>> d44d363f65780f2ac2ec672164555af54896d40d ("mm: don't assume anonymous
>> pages have SwapBacked flag") since 4.12.
> Perhaps that commit should be sent to stable@ ? Although with
> VM_BUG_ON() this is less critical than plain BUG_ON().
I don't think we have to. I agree it is less critical, VM_DEBUG should
be not enabled for production environment.
And, it doesn't actually break anything since split_huge_page would just
return error, and those unmovable pages are silently ignored by isolate.
prev parent reply other threads:[~2019-06-19 16:39 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-17 18:48 [PATCH] mm: mempolicy: handle vma with unmovable pages mapped correctly in mbind Yang Shi
2019-06-18 13:02 ` Michal Hocko
2019-06-18 17:06 ` Yang Shi
2019-06-18 18:28 ` Michal Hocko
2019-06-18 21:13 ` Yang Shi
2019-06-19 5:21 ` Michal Hocko
2019-06-19 8:22 ` Vlastimil Babka
2019-06-19 16:21 ` Yang Shi
2019-06-19 18:19 ` Yang Shi
2019-06-20 7:18 ` Vlastimil Babka
2019-06-20 16:08 ` Yang Shi
2019-06-21 11:33 ` Vlastimil Babka
2019-06-21 18:23 ` Yang Shi
2019-06-19 8:18 ` Vlastimil Babka
2019-06-19 16:39 ` Yang Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68b67faf-d1c3-bc36-3db4-c86c6dfd8f11@linux.alibaba.com \
--to=yang.shi@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.