Re: [PATCH 11/33] gdbstub: Store @can_reverse in GDBState

[Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>]

On 6/30/2026 7:00 PM, Philippe Mathieu-Daudé wrote:
> Call gdb_can_reverse() once in gdb_init_gdbserver_state() and
> store the result in GDBState.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@oss.qualcomm.com>
> ---

Reviewed-by: Daniel Henrique Barboza <daniel.barboza@oss.qualcomm.com>

>   gdbstub/internals.h | 1 +
>   gdbstub/gdbstub.c   | 5 +++--
>   2 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/gdbstub/internals.h b/gdbstub/internals.h
> index 9b25bf58b8e..9a1b8d9dd8a 100644
> --- a/gdbstub/internals.h
> +++ b/gdbstub/internals.h
> @@ -85,6 +85,7 @@ typedef struct GDBState {
>       GByteArray *mem_buf;
>       int sstep_flags;
>       int supported_sstep_flags;
> +    bool can_reverse;
>       /*
>        * Whether we are allowed to send a stop reply packet at this moment.
>        * Must be set off after sending the stop reply itself.
> diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
> index 1e0a6638bff..0037704d522 100644
> --- a/gdbstub/gdbstub.c
> +++ b/gdbstub/gdbstub.c
> @@ -75,6 +75,7 @@ void gdb_init_gdbserver_state(void)
>       accel_get_gdbstub_config(&gdbserver_state.supported_sstep_flags);
>       gdbserver_state.sstep_flags = SSTEP_ENABLE | SSTEP_NOIRQ | SSTEP_NOTIMER;
>       gdbserver_state.sstep_flags &= gdbserver_state.supported_sstep_flags;
> +    gdbserver_state.can_reverse = gdb_can_reverse();
>   }
>   
>   /* writes 2*len+1 bytes in buf */
> @@ -1376,7 +1377,7 @@ static void handle_step(GArray *params, void *user_ctx)
>   
>   static void handle_backward(GArray *params, void *user_ctx)
>   {
> -    if (!gdb_can_reverse()) {
> +    if (!gdbserver_state.can_reverse) {
>           gdb_put_packet("E22");
>           return;
>       }
> @@ -1684,7 +1685,7 @@ static void handle_query_supported(GArray *params, void *user_ctx)
>           g_string_append(gdbserver_state.str_buf, ";qXfer:features:read+");
>       }
>   
> -    if (gdb_can_reverse()) {
> +    if (gdbserver_state.can_reverse) {
>           g_string_append(gdbserver_state.str_buf,
>               ";ReverseStep+;ReverseContinue+");
>       }