All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christian Marangi <ansuelsmth@gmail.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
	Lorenzo Bianconi <lorenzo@kernel.org>,
	Sean Wang <sean.wang@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>,
	AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Benjamin Larsson <benjamin.larsson@genexis.eu>,
	linux-mediatek@lists.infradead.org, linux-gpio@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, stable@vger.kernel.org
Subject: Re: [PATCH] pinctrl: airoha: fix wrong MDIO function bitmaks
Date: Mon, 8 Sep 2025 23:05:07 +0200	[thread overview]
Message-ID: <68bf4509.050a0220.345893.9bb4@mx.google.com> (raw)
In-Reply-To: <CACRpkdYuT0x3JSFWHMF5thH0UyNF1Cse+W9joE12yQ0iAAXjuw@mail.gmail.com>

On Mon, Sep 08, 2025 at 11:03:31PM +0200, Linus Walleij wrote:
> On Mon, Sep 8, 2025 at 9:14 PM Christian Marangi <ansuelsmth@gmail.com> wrote:
> 
> > The usage of GPIO might be confusing but this is just to instruct the
> > SoC to not mess with those 2 PIN and as Benjamin reported it's also an
> > Errata of 7581. The FORCE_GPIO_EN doesn't set them as GPIO function
> > (that is configured by a different register) but it's really to actually
> > ""enable"" those lines.
> >
> > Normally the SoC should autodetect this by HW but it seems AN7581 have
> > problem with this and require this workaround to force enable the 2 pin.
> 
> In reply to Andrews comment I copied the two above paragraphs into the
> commit message in the applied patch.
> 

Thanks for handling this and adding the extra info, I was about to send v2.

-- 
	Ansuel


      reply	other threads:[~2025-09-09  6:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-08 11:37 [PATCH] pinctrl: airoha: fix wrong MDIO function bitmaks Christian Marangi
2025-09-08 12:12 ` Benjamin Larsson
2025-09-08 13:04 ` Linus Walleij
2025-09-08 16:54 ` Andrew Lunn
2025-09-08 17:48   ` Christian Marangi
2025-09-08 19:06     ` Andrew Lunn
2025-09-08 19:14       ` Christian Marangi
2025-09-08 20:07         ` Andrew Lunn
2025-09-08 21:03         ` Linus Walleij
2025-09-08 21:05           ` Christian Marangi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=68bf4509.050a0220.345893.9bb4@mx.google.com \
    --to=ansuelsmth@gmail.com \
    --cc=andrew@lunn.ch \
    --cc=angelogioacchino.delregno@collabora.com \
    --cc=benjamin.larsson@genexis.eu \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mediatek@lists.infradead.org \
    --cc=lorenzo@kernel.org \
    --cc=matthias.bgg@gmail.com \
    --cc=sean.wang@kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.