From: Christian Marangi <ansuelsmth@gmail.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Uwe Kleine-König" <ukleinek@kernel.org>,
linux-kernel@vger.kernel.org, linux-pwm@vger.kernel.org,
"Benjamin Larsson" <benjamin.larsson@genexis.eu>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Lorenzo Bianconi" <lorenzo@kernel.org>
Subject: Re: [PATCH v23] pwm: airoha: Add support for EN7581 SoC
Date: Tue, 9 Sep 2025 13:51:11 +0200 [thread overview]
Message-ID: <68c014b1.050a0220.1de3c.3050@mx.google.com> (raw)
In-Reply-To: <aMANiyqxneM1QxQ-@smile.fi.intel.com>
On Tue, Sep 09, 2025 at 02:20:43PM +0300, Andy Shevchenko wrote:
> On Mon, Sep 08, 2025 at 08:48:38PM +0200, Christian Marangi wrote:
> > On Fri, Aug 01, 2025 at 11:15:41AM +0200, Uwe Kleine-König wrote:
> > > On Tue, Jul 08, 2025 at 04:50:52PM +0200, Christian Marangi wrote:
>
> > > > + * Period goes at 4ns step, normalize it to check if we can
> > >
> > > 4 ms or 4 ns?
> >
> > 4ms you are right
>
> One small but important side note (to Uwe as well, however he seems
> follows what I am about to say). Recently I discovered a nice wrap-up [1]
> on the writing values with units. And I think we should try to follow it
> (at bare minimum to be consistent with chosen — Journalism vs. Scientific —
> style).
>
> [1]: https://poynton.ca/notes/units/
>
Just to be more precise, on comments we should use NUMBER SPACE UNIT? I
think for variables it's problematic.
--
Ansuel
next prev parent reply other threads:[~2025-09-09 11:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-08 14:50 [PATCH v23] pwm: airoha: Add support for EN7581 SoC Christian Marangi
2025-08-01 9:15 ` Uwe Kleine-König
2025-09-08 18:48 ` Christian Marangi
2025-09-09 10:26 ` Uwe Kleine-König
2025-09-09 11:48 ` Christian Marangi
2025-09-09 11:20 ` Andy Shevchenko
2025-09-09 11:51 ` Christian Marangi [this message]
2025-09-09 13:16 ` Andy Shevchenko
2025-09-26 17:41 ` Uwe Kleine-König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68c014b1.050a0220.1de3c.3050@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=benjamin.larsson@genexis.eu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=lorenzo@kernel.org \
--cc=ukleinek@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.