From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF35DCAC592 for ; Mon, 22 Sep 2025 11:36:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Subject:Cc:To:From:Date:Message-ID:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=oAYqFXyWYf/ovOGnjUFnZWmVgk9QvSIoobQEOgia090=; b=dzFSior5vxEqJK6aOMwiurwuRg s6pSRVcZJE4dA11XbDxpG9GIvYvMhY4FJR+1Z7uc0VLQBzlzClBc1LUmmMnM5WwnGtOlFJd/0MKHp BchmBpih3pUaO8M3ue/TW+rL4vdFbzXcLv1OlEcNiF9KW0jEDfyrpKLf1xJIQk7vmL4vgUTYRD2HE dXsJ22nDTrr+qGFGbjTonzy31IDjfy3mwC+s+UiWvV7gbnWKD5RFkwu8esLf1tbNVSfXLGB/gSI9A JIY0eTPHACK1M74iyj3fP1rQKPtxccHNKkxfh8aisqsn4k2Bjcgv+BJme6iYMRYylOUYJijKqoBLg 1/YVzaMA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1v0eqh-0000000AEPh-19E2; Mon, 22 Sep 2025 11:36:51 +0000 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1v0eqe-0000000AEOb-38IN for linux-arm-kernel@lists.infradead.org; Mon, 22 Sep 2025 11:36:49 +0000 Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-467f6fd4e82so10124295e9.2 for ; Mon, 22 Sep 2025 04:36:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1758541007; x=1759145807; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=oAYqFXyWYf/ovOGnjUFnZWmVgk9QvSIoobQEOgia090=; b=MwO4f7zz7nY6rzH3e6UbF90Nd69oZ9seNPZUkgZwtKIn8N0+1YItGpFACP1Nerp/nN PiOMY54D0QrvObmzTtKnmBJ61tlXW0F0muCOP/j5EatGcaj9OXB1dgWgBqFcx7MeKqBU gdysV28G0iFFt/yVqZjCncKUxVRIFb/NvDyX7JXDPRaAq6qeRfmqEcBJUt6kbIWp0wme vHMHKXa1P4FjY3vOkoMhVL3BWidnFRWm3yKsAxHkDlz6InlXfPaGrOZxgEuslm/er4bc QcfxCX6VDfuESZEzmEBcv8l08U6pXyXpgJQDsCQN/OnjVjaLv8x1PdfzIgMBypK4j/+j haRQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758541007; x=1759145807; h=in-reply-to:content-disposition:mime-version:references:subject:cc :to:from:date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=oAYqFXyWYf/ovOGnjUFnZWmVgk9QvSIoobQEOgia090=; b=Fkigck5w81jpaNOoNU5Q+WC4kjJfFwKOoEvzFN2JHuBnL63eENzl0SBa307CUEyz/6 sXO0C/ZGZOI3YaSzmw0gtEWZLU2HxcI/QW57/F/pZ2hX1hiFEosWbdkR0LhnvRrs35Sv LXsnWnMm1QUKbDokkzCwCwroVMocuBce5sSj/C8VwxZg5Ll85HT4INQQg2BSRkVRfoMD U6TUOj9Y0lxJuFVvA94/gVXSEwrwUIMbK32x8U+S9936OjxR2aoPffuylOW7fdHQm4bo TpYyCb0njrLoF5C2tPnzyX8s/9C07WurZPO1IEkGOP24WzHECHEofXSZb0Jg7WqeSspq MGQw== X-Forwarded-Encrypted: i=1; AJvYcCWzvbUholP2ZFLh1VvuujcVhDJ3V+DbjGCoQHMudJtUWE4LC5KAwg/jVA869LbtPfgoUUjhv23EcyI3uKbgj7sm@lists.infradead.org X-Gm-Message-State: AOJu0YyZCZkWBHeMH4+fWWn/OqXoIciI5ITEn6Tf5NZH6+osfhvrQ0uh dPdLdQk0pLqUmtGqQcLUk1i/xYQOCyIGm9BSXeNqEHLkmvJSmBzlfUFp X-Gm-Gg: ASbGnctp8CMxAYkjN3YwFY6bbTjKA6GXO6TjTd1RddAyDnsJIUujxmsdqd8e2GCCRXI Ql6gBcqhaMZB9bcrWo0pJlP7cklYVLWPdWuJPgcu4YorLip3RPtPCY021xxCYST8b0UfMKW8p8P GJeD1gDu7j9Yu8A78031NMl3kx+q1oUa/MGyCL3t6rp99HR3rr3N5QmUY41LcJyzGB9ArOPYVRW 7w5pF7DHMk4VT9eN3gSWSrJhw7fCX5wl+BOQ9GOBdVWW/rICLB7Su26jys07mfm1kn6u2o/awBX Wo/tsyAhc1Y+zdXug/AWORje0ZkL/hq+cC+bpGTKpP5ZY7yS76SB2wYNbcanjUt8Wd5r/dCA9rM ptIjei3IE9qHNO5phrsVjG6q0i80NkxTbmYVZL5p44HChQczOf7gx7MV6/RmKF1F+WTC5sg== X-Google-Smtp-Source: AGHT+IFxQTXNVAZvfC1AemnurHgjd7bW6AIxc0GLyxTk076fV2qzgcWwb7RLdq+XPS4PWKkuqKxXTg== X-Received: by 2002:a05:600c:a48:b0:45d:d19c:32fc with SMTP id 5b1f17b1804b1-467e78caa13mr132278155e9.10.1758541006439; Mon, 22 Sep 2025 04:36:46 -0700 (PDT) Received: from Ansuel-XPS. (host-95-249-236-54.retail.telecomitalia.it. [95.249.236.54]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45f326133a8sm132690315e9.6.2025.09.22.04.36.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Sep 2025 04:36:45 -0700 (PDT) Message-ID: <68d134ce.050a0220.375eef.da87@mx.google.com> X-Google-Original-Message-ID: Date: Mon, 22 Sep 2025 13:36:40 +0200 From: Christian Marangi To: AngeloGioacchino Del Regno Cc: Ryder Lee , Jianjun Wang , Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Manivannan Sadhasivam , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matthias Brugger , linux-pci@vger.kernel.org, linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, upstream@airoha.com Subject: Re: [PATCH 1/2] dt-bindings: PCI: mediatek-gen3: Add support for Airoha AN7583 References: <20250920092612.21464-1-ansuelsmth@gmail.com> <40efb310-e63b-47ea-b62b-cc3d614c47b4@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <40efb310-e63b-47ea-b62b-cc3d614c47b4@collabora.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250922_043648_807563_0E4C73D6 X-CRM114-Status: GOOD ( 21.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Sep 22, 2025 at 01:34:06PM +0200, AngeloGioacchino Del Regno wrote: > Il 20/09/25 11:25, Christian Marangi ha scritto: > > Introduce Airoha AN7583 SoC compatible in mediatek-gen3 PCIe controller > > binding. > > > > This differ from the Airoha EN7581 SoC by the fact that only one Gen3 > > PCIe controller is present on the SoC. > > > > Signed-off-by: Christian Marangi > > --- > > .../bindings/pci/mediatek-pcie-gen3.yaml | 21 +++++++++++++++++++ > > 1 file changed, 21 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > index 0278845701ce..3f556d1327a6 100644 > > --- a/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > +++ b/Documentation/devicetree/bindings/pci/mediatek-pcie-gen3.yaml > > @@ -59,6 +59,7 @@ properties: > > - const: mediatek,mt8192-pcie > > - const: mediatek,mt8196-pcie > > "an" comes before "en", please move it here. > > Also, for consistency with all of the other compatibles, this should be just > "airoha,an7583-pcie": please rename it. > Thanks for the review. The "gen3" wasn't added randomly. On AN7583 they put both gen2 and gen3 PCIe. One line is gen3, the other gen2. So either we differenciate for gen2 or we add the gen3 tag. I decided to add it here to follow the naming pattern with mediatek-pcie-gen3. If you have better idea on this, I'm all open. > > - const: airoha,en7581-pcie > > + - const: airoha,an7583-pcie-gen3 > > > > > reg: > > maxItems: 1 > > @@ -298,6 +299,26 @@ allOf: > > - const: phy-lane1 > > - const: phy-lane2 > > + - if: > > + properties: > > + compatible: > > + const: airoha,an7583-pcie-gen3 > > same for this if block, please put it before en7583. > > Everything else looks good. > > Cheers, > Angelo > > > + then: > > + properties: > > + clocks: > > + maxItems: 1 > > + > > + clock-names: > > + items: > > + - const: sys-ck > > + > > + resets: > > + minItems: 1 > > + > > + reset-names: > > + items: > > + - const: phy-lane0 > > + > > unevaluatedProperties: false > > examples: > > > -- Ansuel