From: Stephen Boyd <sboyd@kernel.org>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH 3/3] spmi: pmic-arb: Convert to platform remove callback returning void
Date: Tue, 28 Mar 2023 21:12:34 -0700 [thread overview]
Message-ID: <68dff3033e46b89691fea06ce8c3754a.sboyd@kernel.org> (raw)
In-Reply-To: <20230306073446.2194048-4-u.kleine-koenig@pengutronix.de>
Quoting Uwe Kleine-König (2023-03-05 23:34:46)
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Applied to spmi-next
prev parent reply other threads:[~2023-03-29 4:12 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-06 7:34 [PATCH 0/3] spmi: Convert to platform remove callback returning void Uwe Kleine-König
2023-03-06 7:34 ` Uwe Kleine-König
2023-03-06 7:34 ` [PATCH 1/3] spmi: hisi-spmi-controller: " Uwe Kleine-König
2023-03-29 4:13 ` Stephen Boyd
2023-03-06 7:34 ` [PATCH 2/3] spmi: mtk-pmif: " Uwe Kleine-König
2023-03-06 7:34 ` Uwe Kleine-König
2023-03-16 9:04 ` AngeloGioacchino Del Regno
2023-03-16 9:04 ` AngeloGioacchino Del Regno
2023-03-29 4:12 ` Stephen Boyd
2023-03-29 4:12 ` Stephen Boyd
2023-03-06 7:34 ` [PATCH 3/3] spmi: pmic-arb: " Uwe Kleine-König
2023-03-29 4:12 ` Stephen Boyd [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68dff3033e46b89691fea06ce8c3754a.sboyd@kernel.org \
--to=sboyd@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.