From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BAB60C433DB for ; Wed, 17 Feb 2021 16:11:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7D95364E33 for ; Wed, 17 Feb 2021 16:11:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233833AbhBQQLG (ORCPT ); Wed, 17 Feb 2021 11:11:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41854 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233677AbhBQQKt (ORCPT ); Wed, 17 Feb 2021 11:10:49 -0500 Received: from mail-pj1-x1034.google.com (mail-pj1-x1034.google.com [IPv6:2607:f8b0:4864:20::1034]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7B3D7C061574 for ; Wed, 17 Feb 2021 08:10:09 -0800 (PST) Received: by mail-pj1-x1034.google.com with SMTP id fy5so1730735pjb.5 for ; Wed, 17 Feb 2021 08:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=twn7H61LwoasXev40PwLZ/u/tW+/PTLk2sNN/MHHJFM=; b=sI43mdtN9/WupK0RaIZVzokjDtXExKNt0RsvM1sZrEOG905NdrUNTWYlFplavSmYBT DI+aOOE/g5PdB+Vs/MBXYbdzEdoRK6tGKwL04c9e+Pr5acz8VnIIEw6+n0TCdQqjoTEH 00XLMmPARctOGwMYFsR/AqghKqgQfrae/k+5Q2Hk39cpq23zPW6mTUMPzHZbHwwmui2J ygmeb7I0CJrHM/J5zH74+VwETy7CM7yGjpp6aoh5T/BPSMI1NWN3ND8ERbZfwiJCbfEZ C4EvyiC/+q90paXXx90gaDtENU3+EfKGh0ov73I+5EpLqmwJYG+cGiBkwAQbLfwb6oDr Rqyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=twn7H61LwoasXev40PwLZ/u/tW+/PTLk2sNN/MHHJFM=; b=NsOk++m5PiFp+g2Jk/++UVDVEV5+g4Dbg5bkbBbQpxnbNNxVtAEsf1o0gh630+3r2w LBlCI/XGlq4szmdKFd8CzXoTeusr8jGSF3G+w11yZdTlKrg9c/VHYjcyZWVbtVxdZmie LlOVRDR41d8A/mKFCWBN2WoTm2hEV/VxZCvqFNi0MjuZNnDnTIC+y585HuwnoOao7LcE CGQ8UnHTZNtTvGVozPukVxSUAHyLVelcWPnYOvhCDnaPWfn0Knjk+Adk5Gp3ikCToCXi IdrH+eMGrMxbR2zZdfjPSGvp7AHXX3eNArfSmydX7pOgnMAf4vMROrjBCGA3MWgWvkay 3vOg== X-Gm-Message-State: AOAM533rcfTDcWCGEvTk58OphH7M9s+3QCNRVz0fX1PF9lR5WnG3jddc 8CnaRNGzhdZdFa9cRclI7sU= X-Google-Smtp-Source: ABdhPJwd0B2BYwZK7t1opg93RJ/2yPdvJ/QA/ll57kwYHLt+i9zoW6kJpz3SilXUpZ4Jsv4ux7FMTg== X-Received: by 2002:a17:90a:77c4:: with SMTP id e4mr9529684pjs.185.1613578209165; Wed, 17 Feb 2021 08:10:09 -0800 (PST) Received: from [192.168.1.8] ([50.47.106.83]) by smtp.gmail.com with ESMTPSA id f2sm3339169pfk.63.2021.02.17.08.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 08:10:08 -0800 (PST) Message-ID: <68ec72635c83f5e984e19b3227ab2c5d8d2b4892.camel@gmail.com> Subject: Re: [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device From: Deepak Rawat To: Simon Ser Cc: linux-hyperv@vger.kernel.org, dri-devel@lists.freedesktop.org, Wei Hu , Haiyang Zhang , Dexuan Cui , Michael Kelley , Gerd Hoffmann , Thomas Zimmermann , Sam Ravnborg Date: Wed, 17 Feb 2021 08:10:08 -0800 In-Reply-To: References: <20210216003959.802492-1-drawat.floss@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.38.4 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-hyperv@vger.kernel.org On Wed, 2021-02-17 at 13:22 +0000, Simon Ser wrote: > On Tuesday, February 16th, 2021 at 1:39 AM, Deepak Rawat < > drawat.floss@gmail.com> wrote: > > > +static int hyperv_conn_init(struct hyperv_drm_device *hv) > > +{ > > +       drm_connector_helper_add(&hv->connector, > > &hyperv_connector_helper_funcs); > > +       return drm_connector_init(&hv->dev, &hv->connector, > > +                                 &hyperv_connector_funcs, > > +                                 DRM_MODE_CONNECTOR_VGA); > > +} > > Nit: shouldn't this be DRM_MODE_CONNECTOR_Virtual? Thanks Simon for the review, I think it make sense to use DRM_MODE_CONNECTOR_Virtual. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6190EC433E0 for ; Wed, 17 Feb 2021 16:10:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1C9F864E2F for ; Wed, 17 Feb 2021 16:10:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1C9F864E2F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 908F76E125; Wed, 17 Feb 2021 16:10:11 +0000 (UTC) Received: from mail-pj1-x1033.google.com (mail-pj1-x1033.google.com [IPv6:2607:f8b0:4864:20::1033]) by gabe.freedesktop.org (Postfix) with ESMTPS id 705426E122 for ; Wed, 17 Feb 2021 16:10:09 +0000 (UTC) Received: by mail-pj1-x1033.google.com with SMTP id c19so1733385pjq.3 for ; Wed, 17 Feb 2021 08:10:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=message-id:subject:from:to:cc:date:in-reply-to:references :user-agent:mime-version:content-transfer-encoding; bh=twn7H61LwoasXev40PwLZ/u/tW+/PTLk2sNN/MHHJFM=; b=sI43mdtN9/WupK0RaIZVzokjDtXExKNt0RsvM1sZrEOG905NdrUNTWYlFplavSmYBT DI+aOOE/g5PdB+Vs/MBXYbdzEdoRK6tGKwL04c9e+Pr5acz8VnIIEw6+n0TCdQqjoTEH 00XLMmPARctOGwMYFsR/AqghKqgQfrae/k+5Q2Hk39cpq23zPW6mTUMPzHZbHwwmui2J ygmeb7I0CJrHM/J5zH74+VwETy7CM7yGjpp6aoh5T/BPSMI1NWN3ND8ERbZfwiJCbfEZ C4EvyiC/+q90paXXx90gaDtENU3+EfKGh0ov73I+5EpLqmwJYG+cGiBkwAQbLfwb6oDr Rqyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:user-agent:mime-version:content-transfer-encoding; bh=twn7H61LwoasXev40PwLZ/u/tW+/PTLk2sNN/MHHJFM=; b=irvqJc1CSB3XH34NtcbjJCPP7F+WQuo12MTB7IlORi7A7zR+gSKfXZvnIbh9+VF7MH trQHOdxngZA9uVn2Byc90xPNUuoLv/QtNIGiHIvgLWK5rvORsiRJctNoSbzVXd15CUht MCcAR5R3V64Jf2U6kfyggxT1Ut7C+8TOPhB5fdiHlW4ogXICun2XKm7ugI3xaUWQULck Jao2d6uNczP9s2TDyVsVkxhf+p1WRj+A/aro2uaperkRVeTKSrqNYh/xMMaRYyq5kbzY OCimTMO/UwJl5DRTd2UO9HDNTo6j3BGujS3ZyRoaJKb15LtNgEjxYGj9l4T3hSH9x0qO K0Ug== X-Gm-Message-State: AOAM531tf0eTzUHmfLD1tk/1o0k+amv0fN70v56MbKshhvI4DqkGn1yu /nzvXa2YSE7d/yxkKpxBprM= X-Google-Smtp-Source: ABdhPJwd0B2BYwZK7t1opg93RJ/2yPdvJ/QA/ll57kwYHLt+i9zoW6kJpz3SilXUpZ4Jsv4ux7FMTg== X-Received: by 2002:a17:90a:77c4:: with SMTP id e4mr9529684pjs.185.1613578209165; Wed, 17 Feb 2021 08:10:09 -0800 (PST) Received: from [192.168.1.8] ([50.47.106.83]) by smtp.gmail.com with ESMTPSA id f2sm3339169pfk.63.2021.02.17.08.10.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Feb 2021 08:10:08 -0800 (PST) Message-ID: <68ec72635c83f5e984e19b3227ab2c5d8d2b4892.camel@gmail.com> Subject: Re: [PATCH v3 1/2] drm/hyperv: Add DRM driver for hyperv synthetic video device From: Deepak Rawat To: Simon Ser Date: Wed, 17 Feb 2021 08:10:08 -0800 In-Reply-To: References: <20210216003959.802492-1-drawat.floss@gmail.com> User-Agent: Evolution 3.38.4 MIME-Version: 1.0 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hyperv@vger.kernel.org, Wei Hu , Haiyang Zhang , Dexuan Cui , dri-devel@lists.freedesktop.org, Michael Kelley , Gerd Hoffmann , Thomas Zimmermann , Sam Ravnborg Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" T24gV2VkLCAyMDIxLTAyLTE3IGF0IDEzOjIyICswMDAwLCBTaW1vbiBTZXIgd3JvdGU6Cj4gT24g VHVlc2RheSwgRmVicnVhcnkgMTZ0aCwgMjAyMSBhdCAxOjM5IEFNLCBEZWVwYWsgUmF3YXQgPAo+ IGRyYXdhdC5mbG9zc0BnbWFpbC5jb20+IHdyb3RlOgo+IAo+ID4gK3N0YXRpYyBpbnQgaHlwZXJ2 X2Nvbm5faW5pdChzdHJ1Y3QgaHlwZXJ2X2RybV9kZXZpY2UgKmh2KQo+ID4gK3sKPiA+ICvCoMKg wqDCoMKgwqDCoGRybV9jb25uZWN0b3JfaGVscGVyX2FkZCgmaHYtPmNvbm5lY3RvciwKPiA+ICZo eXBlcnZfY29ubmVjdG9yX2hlbHBlcl9mdW5jcyk7Cj4gPiArwqDCoMKgwqDCoMKgwqByZXR1cm4g ZHJtX2Nvbm5lY3Rvcl9pbml0KCZodi0+ZGV2LCAmaHYtPmNvbm5lY3RvciwKPiA+ICvCoMKgwqDC oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg ICZoeXBlcnZfY29ubmVjdG9yX2Z1bmNzLAo+ID4gK8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgRFJNX01PREVfQ09OTkVDVE9S X1ZHQSk7Cj4gPiArfQo+IAo+IE5pdDogc2hvdWxkbid0IHRoaXMgYmUgRFJNX01PREVfQ09OTkVD VE9SX1ZpcnR1YWw/CgpUaGFua3MgU2ltb24gZm9yIHRoZSByZXZpZXcsIEkgdGhpbmsgaXQgbWFr ZSBzZW5zZSB0byB1c2UKRFJNX01PREVfQ09OTkVDVE9SX1ZpcnR1YWwuCgoKCl9fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxp c3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNr dG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo=