From: Christian Marangi <ansuelsmth@gmail.com>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Frank Wunderlich <frank-w@public-files.de>
Subject: Re: [net-next PATCH] net: phy: as21xxx: fill in inband caps and better handle inband
Date: Thu, 16 Oct 2025 17:30:23 +0200 [thread overview]
Message-ID: <68f10f91.050a0220.3778ad.a4b3@mx.google.com> (raw)
In-Reply-To: <aPEOBRytURg6vKqN@shell.armlinux.org.uk>
On Thu, Oct 16, 2025 at 04:23:49PM +0100, Russell King (Oracle) wrote:
> On Thu, Oct 16, 2025 at 05:20:07PM +0200, Christian Marangi wrote:
> > +static int as21xxx_config_inband(struct phy_device *phydev,
> > + unsigned int modes)
> > +{
> > + if (modes == LINK_INBAND_ENABLE)
> > + return aeon_dpc_ra_enable(phydev);
>
> So what happens when phylink requests inband to be disabled?
>
> I really don't like implementations that enable something but then
> provide no way to disable it.
>
On firmware load it's disabled by default. Can phylink ask to disable
inband at runtime?
I will try to check if there is a way to disable it.
> --
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!
--
Ansuel
prev parent reply other threads:[~2025-10-16 15:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-16 15:20 [net-next PATCH] net: phy: as21xxx: fill in inband caps and better handle inband Christian Marangi
2025-10-16 15:23 ` Russell King (Oracle)
2025-10-16 15:30 ` Christian Marangi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68f10f91.050a0220.3778ad.a4b3@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=frank-w@public-files.de \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.