Re: [PATCH mptcp-net] selftests: mptcp: gives slow test-case more time

[Mat Martineau <mathew.j.martineau@linux.intel.com>]

On Mon, 24 Oct 2022, Paolo Abeni wrote:

> On slow or busy VM, some test-cases still fail because the
> data transfer completes before the endpoint manipulation
> actually took effect.
>
> Address the issue by artificially increasing the runtime for
> the relevant test-cases.
>
> Fixes: ef360019db40 ("selftests: mptcp: signal addresses testcases")
> Closes: https://github.com/multipath-tcp/mptcp_net-next/issues/309
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
> ---
> tools/testing/selftests/net/mptcp/mptcp_join.sh | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/net/mptcp/mptcp_join.sh b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> index f3dd5f2a0272..2eeaf4aca644 100755
> --- a/tools/testing/selftests/net/mptcp/mptcp_join.sh
> +++ b/tools/testing/selftests/net/mptcp/mptcp_join.sh
> @@ -2152,7 +2152,7 @@ remove_tests()
> 		pm_nl_set_limits $ns2 1 3
> 		pm_nl_add_endpoint $ns2 10.0.3.2 flags subflow
> 		pm_nl_add_endpoint $ns2 10.0.4.2 flags subflow
> -		run_tests $ns1 $ns2 10.0.1.1 0 -1 -2 slow
> +		run_tests $ns1 $ns2 10.0.1.1 0 -1 -2 speed_10
> 		chk_join_nr 3 3 3
> 		chk_add_nr 1 1
> 		chk_rm_nr 2 2
> @@ -2165,7 +2165,7 @@ remove_tests()
> 		pm_nl_add_endpoint $ns1 10.0.3.1 flags signal
> 		pm_nl_add_endpoint $ns1 10.0.4.1 flags signal
> 		pm_nl_set_limits $ns2 3 3
> -		run_tests $ns1 $ns2 10.0.1.1 0 -3 0 slow
> +		run_tests $ns1 $ns2 10.0.1.1 0 -3 0 speed_10
> 		chk_join_nr 3 3 3
> 		chk_add_nr 3 3
> 		chk_rm_nr 3 3 invert
> @@ -2178,7 +2178,7 @@ remove_tests()
> 		pm_nl_add_endpoint $ns1 10.0.3.1 flags signal
> 		pm_nl_add_endpoint $ns1 10.0.14.1 flags signal
> 		pm_nl_set_limits $ns2 3 3
> -		run_tests $ns1 $ns2 10.0.1.1 0 -3 0 slow
> +		run_tests $ns1 $ns2 10.0.1.1 0 -3 0 speed_10
> 		chk_join_nr 1 1 1
> 		chk_add_nr 3 3
> 		chk_rm_nr 3 1 invert
> -- 
> 2.37.3

Looks good to me:

Reviewed-by: Mat Martineau <mathew.j.martineau@linux.intel.com>

Do you want me to get this in to the export branch soon, or should we 
leave it queued for Matthieu?


--
Mat Martineau
Intel