From mboxrd@z Thu Jan 1 00:00:00 1970 From: Heiko Stuebner Subject: Re: [PATCH 02/41] drm/rockchip: Get rid of some unnecessary code Date: Tue, 12 Dec 2017 13:25:14 +0100 Message-ID: <6912304.Ixds0LLa6k@phil> References: <20170310043305.17216-1-seanpaul@chromium.org> <20170310043305.17216-3-seanpaul@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20170310043305.17216-3-seanpaul@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: linux-rockchip@lists.infradead.org Cc: David Airlie , dri-devel@lists.freedesktop.org, Tomasz Figa , linux-arm-kernel@lists.infradead.org, Mark Yao List-Id: linux-rockchip.vger.kernel.org QW0gRG9ubmVyc3RhZywgOS4gTcOkcnogMjAxNywgMjM6MzI6MTcgQ0VUIHNjaHJpZWIgU2VhbiBQ YXVsOgo+IEZyb206IFRvbWFzeiBGaWdhIDx0ZmlnYUBjaHJvbWl1bS5vcmc+Cj4gCj4gQ3VycmVu dCBjb2RlIGltcGxlbWVudHMgcHJlcGFyZV9mYiBhbmQgY2xlYW51cF9mYiBjYWxsYmFja3Mgb25s eSB0bwo+IGdyYWIvcmVsZWFzZSBmYiByZWZlcmVuY2VzLCB3aGljaCBpcyBhbHJlYWR5IGRvbmUg YnkgYXRvbWljIGZyYW1ld29yawo+IHdoZW4gY3JlYXRpbmcvZGVzdHJ5b2luZyBwbGFuZSBzdGF0 ZS4gQWxzbyB0aGVyZSBhcmUgc29tZSB1bnVzZWQgZmllbGRzCj4gdm9wIGFuZCB2b3Bfd2luIHN0 cnVjdHMuIExldCdzIHJlbW92ZSB0aGVzZSB1bnVzZWQgYml0cy4KPiAKPiBTaWduZWQtb2ZmLWJ5 OiBUb21hc3ogRmlnYSA8dGZpZ2FAY2hyb21pdW0ub3JnPgo+IFNpZ25lZC1vZmYtYnk6IFNlYW4g UGF1bCA8c2VhbnBhdWxAY2hyb21pdW0ub3JnPgoKVGhlcmUgc2VlbXMgdG8gYmUgYSBzbGlnaHQg ZGlzY3JlcGFuY3kgYmV0d2VlbiBwYXRjaCBtZXNzYWdlIGFuZCBjb2RlLgpUaGUgY29tbWl0IG1l c3NhZ2UgdGFsa3MgYWJvdXQgKl9mYi1jYWxsYmFja3MsIHdoaWxlIHRoZSBwYXRjaCByZW1vdmVz CmEgc2VlbWluZ2x5IHVuc3VzZWQgbXV0ZXgsIHdoaWNoIEkgZ3Vlc3MgZmFsbHMgdW5kZXIgdGhl ICJzb21lIHVudXNlZCBmaWVsZHMiCnBhcnQuCgpJbiBhbnkgY2FzZSwgSSBkaWRuJ3Qgc2VlIGFu eSBpbGwgZWZmZWN0cyB3aGVuIHRlc3RpbmcgdGhpcyBwYXRjaCwgc28KVGVzdGVkLWJ5OiBIZWlr byBTdHVlYm5lciA8aGVpa29Ac250ZWNoLmRlPgoKPiAtLS0KPiAgZHJpdmVycy9ncHUvZHJtL3Jv Y2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYyB8IDUgLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDUg ZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9yb2NrY2hpcC9y b2NrY2hpcF9kcm1fdm9wLmMgYi9kcml2ZXJzL2dwdS9kcm0vcm9ja2NoaXAvcm9ja2NoaXBfZHJt X3ZvcC5jCj4gaW5kZXggMjE1MWUxY2VlNGI0Li4wNTM5YWZiNmI3YzggMTAwNjQ0Cj4gLS0tIGEv ZHJpdmVycy9ncHUvZHJtL3JvY2tjaGlwL3JvY2tjaGlwX2RybV92b3AuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9yb2NrY2hpcC9yb2NrY2hpcF9kcm1fdm9wLmMKPiBAQCAtMTA4LDkgKzEwOCw2 IEBAIHN0cnVjdCB2b3Agewo+ICAJc3RydWN0IGRybV9kZXZpY2UgKmRybV9kZXY7Cj4gIAlib29s IGlzX2VuYWJsZWQ7Cj4gIAo+IC0JLyogbXV0ZXggdnN5bmNfIHdvcmsgKi8KPiAtCXN0cnVjdCBt dXRleCB2c3luY19tdXRleDsKPiAtCWJvb2wgdnN5bmNfd29ya19wZW5kaW5nOwo+ICAJc3RydWN0 IGNvbXBsZXRpb24gZHNwX2hvbGRfY29tcGxldGlvbjsKPiAgCj4gIAkvKiBwcm90ZWN0ZWQgYnkg ZGV2LT5ldmVudF9sb2NrICovCj4gQEAgLTE1OTIsOCArMTU4OSw2IEBAIHN0YXRpYyBpbnQgdm9w X2JpbmQoc3RydWN0IGRldmljZSAqZGV2LCBzdHJ1Y3QgZGV2aWNlICptYXN0ZXIsIHZvaWQgKmRh dGEpCj4gIAlzcGluX2xvY2tfaW5pdCgmdm9wLT5yZWdfbG9jayk7Cj4gIAlzcGluX2xvY2tfaW5p dCgmdm9wLT5pcnFfbG9jayk7Cj4gIAo+IC0JbXV0ZXhfaW5pdCgmdm9wLT52c3luY19tdXRleCk7 Cj4gLQo+ICAJcmV0ID0gZGV2bV9yZXF1ZXN0X2lycShkZXYsIHZvcC0+aXJxLCB2b3BfaXNyLAo+ ICAJCQkgICAgICAgSVJRRl9TSEFSRUQsIGRldl9uYW1lKGRldiksIHZvcCk7Cj4gIAlpZiAocmV0 KQo+IAoKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmRy aS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRw czovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: heiko@sntech.de (Heiko Stuebner) Date: Tue, 12 Dec 2017 13:25:14 +0100 Subject: [PATCH 02/41] drm/rockchip: Get rid of some unnecessary code In-Reply-To: <20170310043305.17216-3-seanpaul@chromium.org> References: <20170310043305.17216-1-seanpaul@chromium.org> <20170310043305.17216-3-seanpaul@chromium.org> Message-ID: <6912304.Ixds0LLa6k@phil> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Am Donnerstag, 9. M?rz 2017, 23:32:17 CET schrieb Sean Paul: > From: Tomasz Figa > > Current code implements prepare_fb and cleanup_fb callbacks only to > grab/release fb references, which is already done by atomic framework > when creating/destryoing plane state. Also there are some unused fields > vop and vop_win structs. Let's remove these unused bits. > > Signed-off-by: Tomasz Figa > Signed-off-by: Sean Paul There seems to be a slight discrepancy between patch message and code. The commit message talks about *_fb-callbacks, while the patch removes a seemingly unsused mutex, which I guess falls under the "some unused fields" part. In any case, I didn't see any ill effects when testing this patch, so Tested-by: Heiko Stuebner > --- > drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > index 2151e1cee4b4..0539afb6b7c8 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c > @@ -108,9 +108,6 @@ struct vop { > struct drm_device *drm_dev; > bool is_enabled; > > - /* mutex vsync_ work */ > - struct mutex vsync_mutex; > - bool vsync_work_pending; > struct completion dsp_hold_completion; > > /* protected by dev->event_lock */ > @@ -1592,8 +1589,6 @@ static int vop_bind(struct device *dev, struct device *master, void *data) > spin_lock_init(&vop->reg_lock); > spin_lock_init(&vop->irq_lock); > > - mutex_init(&vop->vsync_mutex); > - > ret = devm_request_irq(dev, vop->irq, vop_isr, > IRQF_SHARED, dev_name(dev), vop); > if (ret) >