From mboxrd@z Thu Jan  1 00:00:00 1970
From: Thomas Monjalon <thomas.monjalon@6wind.com>
Subject: Re: [PATCH v2 06/11] app/test: use linked list to store
	PCI drivers
Date: Thu, 12 May 2016 23:44:50 +0200
Message-ID: <6917242.TZ3GTNlPop@xps13>
References: <1462904011-29838-1-git-send-email-viktorin@rehivetech.com>
 <1659775.2ddTAuyrkI@xps13> <20160512230044.654b1588@jvn>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7Bit
Cc: dev@dpdk.org, David Marchand <david.marchand@6wind.com>,
 Bruce Richardson <bruce.richardson@intel.com>
To: Jan Viktorin <viktorin@rehivetech.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42])
 by dpdk.org (Postfix) with ESMTP id 270895A1F
 for <dev@dpdk.org>; Thu, 12 May 2016 23:44:52 +0200 (CEST)
Received: by mail-wm0-f42.google.com with SMTP id n129so161152wmn.1
 for <dev@dpdk.org>; Thu, 12 May 2016 14:44:52 -0700 (PDT)
In-Reply-To: <20160512230044.654b1588@jvn>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

2016-05-12 23:00, Jan Viktorin:
> On Thu, 12 May 2016 18:08:16 +0200
> Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> 
> > 2016-05-12 17:53, Jan Viktorin:
> > > On Thu, 12 May 2016 17:31:28 +0200
> > > Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> > >   
> > > > 2016-05-10 20:13, Jan Viktorin:  
> > > > > The test unregisters all real drivers before starting into an array. This
> > > > > inflexiable as we can use a linked list for this purpose.    
> > > > 
> > > > I don't understand this. Maybe some words are missing.  
> > > 
> > > Better?
> > > 
> > > The test unregisters all real drivers before starting (stored into an array).
> > > This is inflexiable (due to its fixed size) and we can use a linked list for
> > > this purpose.    
> > 
> > Better with a past tense? "The test was unregistering..."
> 
> No. This patch does not change the semantics (well, it does, because
> the list of drivers become global but that's all). The test still
> unregisters the drivers. That is the important fact to consider.
> 
> Perhaps:
> 
> The test unregisters all drivers before start. The drivers were stored
> into a fixed-sized array. This is inflexible. This patch change this to
> utilize a linked list for the same purpose.

Yes better. Thanks