From: Christian Marangi <ansuelsmth@gmail.com>
To: Chukun Pan <amadeus@jmu.edu.cn>
Cc: Lorenzo Bianconi <lorenzo@kernel.org>,
Linus Walleij <linus.walleij@linaro.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
angelogioacchino.delregno@collabora.com,
Sean Wang <sean.wang@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH 1/1] pinctrl: airoha: fix pinctrl function mismatch issue
Date: Sat, 15 Nov 2025 20:54:52 +0100 [thread overview]
Message-ID: <6918da93.df0a0220.10a972.69d2@mx.google.com> (raw)
In-Reply-To: <20251115100000.177791-1-amadeus@jmu.edu.cn>
On Sat, Nov 15, 2025 at 06:00:00PM +0800, Chukun Pan wrote:
> The blamed commit made the following changes:
>
> -#define PINCTRL_FUNC_DESC(id)...
> - .desc = PINCTRL_PINFUNCTION(#id, ...
> +#define PINCTRL_FUNC_DESC(id, table)...
> + .desc = PINCTRL_PINFUNCTION(#id, ...
>
> - PINCTRL_FUNC_DESC(pon)...
> + PINCTRL_FUNC_DESC("pon", pon)...
>
> It's clear that the id of funcs doesn't match the definition.
> Remove redundant #string from the definition to fix this issue:
> pinctrl-airoha ...: invalid function mdio in map table
>
> Fixes: 4043b0c45f85 ("pinctrl: airoha: generalize pins/group/function/confs handling")
> Signed-off-by: Chukun Pan <amadeus@jmu.edu.cn>
Acked-by: Christian Marangi <ansuelsmth@gmail.com>
> ---
> drivers/pinctrl/mediatek/pinctrl-airoha.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/mediatek/pinctrl-airoha.c b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> index bfcedc7f920b..18c952e44229 100644
> --- a/drivers/pinctrl/mediatek/pinctrl-airoha.c
> +++ b/drivers/pinctrl/mediatek/pinctrl-airoha.c
> @@ -35,7 +35,7 @@
>
> #define PINCTRL_FUNC_DESC(id, table) \
> { \
> - .desc = PINCTRL_PINFUNCTION(#id, table##_groups, \
> + .desc = PINCTRL_PINFUNCTION(id, table##_groups, \
> ARRAY_SIZE(table##_groups)),\
> .groups = table##_func_group, \
> .group_size = ARRAY_SIZE(table##_func_group), \
> --
> 2.25.1
>
--
Ansuel
next prev parent reply other threads:[~2025-11-15 19:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-15 10:00 [PATCH 1/1] pinctrl: airoha: fix pinctrl function mismatch issue Chukun Pan
2025-11-15 19:54 ` Christian Marangi [this message]
2025-11-18 23:02 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6918da93.df0a0220.10a972.69d2@mx.google.com \
--to=ansuelsmth@gmail.com \
--cc=amadeus@jmu.edu.cn \
--cc=angelogioacchino.delregno@collabora.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=sean.wang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.