From: Lizhi Hou <lizhi.hou@amd.com>
To: Jeffrey Hugo <quic_jhugo@quicinc.com>, <ogabbay@kernel.org>,
<dri-devel@lists.freedesktop.org>
Cc: <linux-kernel@vger.kernel.org>, <min.ma@amd.com>,
<max.zhen@amd.com>, <sonal.santan@amd.com>, <king.tam@amd.com>,
<mario.limonciello@amd.com>, Xiaoming Ren <xiaoming.ren@amd.com>
Subject: Re: [PATCH V2 3/8] accel/amdxdna: Add RyzenAI-npu6 support
Date: Fri, 13 Dec 2024 08:47:14 -0800 [thread overview]
Message-ID: <691cccca-eaf3-6384-5ca4-54c2d3548bf7@amd.com> (raw)
In-Reply-To: <96368cf8-792b-598c-0c82-e6d2f46cfb74@quicinc.com>
On 12/13/24 08:37, Jeffrey Hugo wrote:
> On 12/6/2024 2:59 PM, Lizhi Hou wrote:
>> Add NPU6 registers and other private configurations.
>>
>> Co-developed-by: Xiaoming Ren <xiaoming.ren@amd.com>
>> Signed-off-by: Xiaoming Ren <xiaoming.ren@amd.com>
>> Signed-off-by: Lizhi Hou <lizhi.hou@amd.com>
>> ---
>> drivers/accel/amdxdna/Makefile | 3 +-
>> drivers/accel/amdxdna/npu6_regs.c | 121 ++++++++++++++++++++++++++++++
>
> This looks like dead code to me. I would expect somewhere else in the
> driver, dev_npu6_info would be used, but that is not the case. What
> am I missing?
You are correct. I miss merged one line to the patch in amdxdna_idx[]..
Thanks a lot.
Lizhi
>
> -Jeff
next prev parent reply other threads:[~2024-12-13 16:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 21:59 [PATCH V2 0/8] AMD NPU driver improvements Lizhi Hou
2024-12-06 21:59 ` [PATCH V2 1/8] accel/amdxdna: Add device status for aie2 devices Lizhi Hou
2024-12-11 0:31 ` Mario Limonciello
2024-12-13 16:31 ` Jeffrey Hugo
2024-12-06 21:59 ` [PATCH V2 2/8] accel/amdxdna: Replace mmput with mmput_async to avoid dead lock Lizhi Hou
2024-12-13 16:33 ` Jeffrey Hugo
2024-12-06 21:59 ` [PATCH V2 3/8] accel/amdxdna: Add RyzenAI-npu6 support Lizhi Hou
2024-12-11 0:30 ` Mario Limonciello
2024-12-13 16:37 ` Jeffrey Hugo
2024-12-13 16:47 ` Lizhi Hou [this message]
2024-12-06 21:59 ` [PATCH V2 4/8] accel/amdxdna: Replace idr api with xarray Lizhi Hou
2024-12-13 16:42 ` Jeffrey Hugo
2024-12-13 16:50 ` Lizhi Hou
2024-12-06 21:59 ` [PATCH V2 5/8] accel/amdxdna: Add query firmware version Lizhi Hou
2024-12-11 0:28 ` Mario Limonciello
2024-12-13 16:48 ` Jeffrey Hugo
2024-12-06 21:59 ` [PATCH V2 6/8] accel/amdxdna: Enhance power management settings Lizhi Hou
2024-12-11 0:28 ` Mario Limonciello
2024-12-11 5:28 ` Lizhi Hou
2024-12-11 20:55 ` Mario Limonciello
2024-12-13 16:55 ` Jeffrey Hugo
2024-12-13 17:31 ` Lizhi Hou
2024-12-06 22:00 ` [PATCH V2 7/8] accel/amdxdna: Read firmware interface version from registers Lizhi Hou
2024-12-11 0:20 ` Mario Limonciello
2024-12-11 5:32 ` Lizhi Hou
2024-12-13 16:58 ` Jeffrey Hugo
2024-12-13 17:02 ` Lizhi Hou
2024-12-13 17:11 ` Jeffrey Hugo
2024-12-06 22:00 ` [PATCH V2 8/8] accel/amdxdna: Add include interrupt.h to amdxdna_mailbox.c Lizhi Hou
2024-12-10 20:54 ` Mario Limonciello
2024-12-13 16:20 ` Jeffrey Hugo
2024-12-13 16:42 ` Lizhi Hou
2024-12-13 17:00 ` [PATCH V2 0/8] AMD NPU driver improvements Jeffrey Hugo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=691cccca-eaf3-6384-5ca4-54c2d3548bf7@amd.com \
--to=lizhi.hou@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=king.tam@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=max.zhen@amd.com \
--cc=min.ma@amd.com \
--cc=ogabbay@kernel.org \
--cc=quic_jhugo@quicinc.com \
--cc=sonal.santan@amd.com \
--cc=xiaoming.ren@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.