Re: [bug report] soc: qcom: smem: better track SMEM uninitialized state

[Christian Marangi <ansuelsmth@gmail.com>]

On Fri, Nov 21, 2025 at 11:48:07AM +0300, Dan Carpenter wrote:
> Hello Christian Marangi,
> 
> Commit 7a94d5f31b54 ("soc: qcom: smem: better track SMEM
> uninitialized state") from Oct 31, 2025 (linux-next), leads to the
> following Smatch static checker warning:
> 
> 	drivers/soc/qcom/smem.c:519 qcom_smem_alloc()
> 	warn: '__smem' can also be NULL
> 
> drivers/soc/qcom/smem.c
>     509 int qcom_smem_alloc(unsigned host, unsigned item, size_t size)
>     510 {
>     511         struct smem_partition *part;
>     512         unsigned long flags;
>     513         int ret;
>     514 
>     515         if (IS_ERR(__smem))
>     516                 return PTR_ERR(__smem);
> 
> We recently changed this from being NULL at the start to being -EPROBE_DEFER
> but the qcom_smem_remove() function still sets it to NULL and the
> qcom_smem_is_available() still expects it to be NULL at the start so it
> needs to be updated as well.
> 
>     517 
>     518         if (item < SMEM_ITEM_LAST_FIXED) {
> --> 519                 dev_err(__smem->dev,
>     520                         "Rejecting allocation of static entry %d\n", item);
>     521                 return -EINVAL;
>     522         }
> 

Hi,

I remember editing qcom_smem_is_available but probably it got lost when
amending the changes.

Creating a fix patch just now. Can you help me with what link I should
put in the Closes tag?

-- 
	Ansuel