From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 660B82D2384 for ; Tue, 9 Dec 2025 15:10:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765293005; cv=none; b=GtFILS1q9olI8v1bYSe/8MZD60Fq2ZmnthmooQ1PE+asGkvF5jJR6yZnIx01Tz510uJ4INcOOX6w85LMtL1N6oEs51sCdGAdPbFSA78u03/GSlmHSpJHaSzRJFexk8+wSP0UZ4UIQW6PcMutfk+GVDkP1z3t1pNTBGwYsZyHtM8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1765293005; c=relaxed/simple; bh=n98qB+D9RodVAMA9Yr3Y1FmphUQuhvYLQGVcyxQC5wY=; h=Message-ID:Date:From:To:Cc:Subject:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=HF8hNL3rJMHiTQLCkgkb2jr2GH/QAYjUaQr+1yO3ufAt1sqw8XlYALfTcLiwiJSTCEt0EYI5zRwoBfq+78WC2K1bolj2sFiysmUbgu+Mkel6VV++FduMAgKcOFo533xFUCcdrsl35R7nTIXAwUtw2nSjL8PYcM3+rC3/8e+hM6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=d9xdPgP8; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="d9xdPgP8" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-477770019e4so61363325e9.3 for ; Tue, 09 Dec 2025 07:10:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1765293002; x=1765897802; darn=vger.kernel.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=SsNgmAoYWKU/AFwmHkvit6WU/mtJt1cuhchvTJvbCPI=; b=d9xdPgP8GmNVt7lPUa4J2cJcqMJoUtfvh6NZtWaVDr33KdVgDsu8CLlKuxmF2J74hf H805r19D7mGucCohSDLFpzMKeDj74UMZfLAMsR1eugZ5+A1GxrNCGmqxduWuP7NZm0UQ YOPHD6H55Q12338afhnl7GEcrUJ6HcrcbYpHKRfmRddE2Ei0ZnfUwXdwaVBdsuzydMmi 1WsONhqZtAGXczJQRrEMBajUpFrH/uBQGlm9M/mUXHUUKCEqbCxLlumPv0SmSGQBhB1u vIhAcJNBwxSeIzC1i0nZp+OeANTDX8i+JbJkGsIM+GQGTXDDsv0xZbFN5PJvQqZhD08G FJjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1765293002; x=1765897802; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:subject:cc:to:from:date:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SsNgmAoYWKU/AFwmHkvit6WU/mtJt1cuhchvTJvbCPI=; b=GdJrrTLohkiDpRlhFmXA7Q/wfBQetU8jc8GCoBVD0Dq1EbAmlyGkzozaDfvbZQ5Axa LLZzw9TgCVoZ024Hfy/XKMBwNJ/UNjh2xvHAA3eGOU/xmfco7xu8Uz6vORCDlARrI0yI B6pkbfLyiiVOyY/vJSGXhjNpD0fJ+4sy31LfAfYkfNfpWrkxQ6t/jviFykuJ71aXvxfK T7q3YNFTmIDo0nWOGjMpEAA5UBd7IPoYBOYy3kD9kLZPzFl3kxPxs6UbbakZSUZTePNz OEm2iKWwA/rdttCToSCD7yLXoY6ibKIcrqMyPhZEvJN4OBxWFmeFjcbUx3mltg4Ub1kE 58YA== X-Forwarded-Encrypted: i=1; AJvYcCXtXH90wVS9I1vmkgmndrkBstw3dia0e1Kbk3eIoPkuCECf2yx/eqmWF6u43+GYDFauHqB6tOnbWljZKcE=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9Egrj7EW4dM5+dJKEbzsv8f6ykkzpFWZ1d4XElAkO99493uDD bomDS5qcQtzaiJnF2bXpXntvS2uY+SflqmaQ41MHc2whpN3xJR2ROfCW X-Gm-Gg: ASbGnctH9c5gRfqWULh4aVXUgYEYD21/6Dp2NWPkJyH2u44W/vdSOe62uxYsr7+QztX YjT2PSTooPg6R2pIVF3AkT+6b9xRssy2BIFNHLIwDj8faZT/6/ugnCYdjN4wRwfU3Nw8r2/gUv8 bDE7hsAI0x8RkKlxAJjbastMyrIxvni9B8Nix27kERjy5aY3KdF4C/LgWp8HzHd4IlmmtM9n1UM VQdrKJAblEtd1w44CDlZCxaeDSxhFL2WbP/Vbcwl2+EWO4TfW7zgkil8D6b69gfL5OACLu+AqRP 9UhWh58PPK9vS3xZ3Zl+cuAgGTlTCrT5mG9jJrLf4ZLsiN8QfuYDwiM9tJrBUxn8Zok6Gn3jzpx AEnnA8Qfeu/VavAM9B71hSZ+RIaAJufVXr2yQXxr1lTL4Fm0PafQmV54v7Lw1u9UnnRpuA6D5Jc g/uVVvY6VTZzQnB2DJYuJJxS0rXKXsuVeULeyzRNjfLCPSpA3IXg== X-Google-Smtp-Source: AGHT+IFNQsp0UjknerK+4Q6wt1rk9LYqS45+7M+dIMP2AvhftSNQmdbF3Fc5WZnVEQT7vGPwHU3VOA== X-Received: by 2002:a05:600c:3b05:b0:46e:3d41:6001 with SMTP id 5b1f17b1804b1-47939e59557mr115411265e9.34.1765293001503; Tue, 09 Dec 2025 07:10:01 -0800 (PST) Received: from Ansuel-XPS. (93-34-88-81.ip49.fastwebnet.it. [93.34.88.81]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47a7d3a75a3sm19857495e9.6.2025.12.09.07.10.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Dec 2025 07:10:01 -0800 (PST) Message-ID: <69383bc9.050a0220.3cbaa0.7757@mx.google.com> X-Google-Original-Message-ID: Date: Tue, 9 Dec 2025 16:09:57 +0100 From: Christian Marangi To: Andy Shevchenko Cc: Ilpo =?iso-8859-1?Q?J=E4rvinen?= , Andrew Morton , LKML Subject: Re: [PATCH] resource: add WARN_ON_ONCE for resource_size() and document misusage References: <20251208202921.16819-1-ansuelsmth@gmail.com> <2c80f567-d632-b37e-c419-db059b1f2771@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Dec 09, 2025 at 05:07:09PM +0200, Andy Shevchenko wrote: > On Tue, Dec 09, 2025 at 12:25:38PM +0200, Ilpo Järvinen wrote: > > On Mon, 8 Dec 2025, Christian Marangi wrote: > > ... > > > > static inline resource_size_t resource_size(const struct resource *res) > > > { > > > + WARN_ON_ONCE(!res->flags); > > > > As lkp also found out, you need to add #include > > Since it's header, we may use better one from asm, i.e. asm/bug.h. > This will give finer granularity and less possible tangled dependencies > in the future. > Will change in v3 I assume minor touch up to wording might be needed so it's not a problem. > > > return res->end - res->start + 1; > > > } > > > -- > With Best Regards, > Andy Shevchenko > > -- Ansuel