Re: Can we autogenerate smb2_error_map_table[]?

[ChenXiaoSong <chenxiaosong.chenxiaosong@linux.dev>]

Sounds good, it could reduce a lot of code. What do others think?

Thanks,
ChenXiaoSong.

On 12/11/25 7:03 AM, David Howells wrote:
> Hi Chenxiaosong,
> 
> Can I suggest that rather than doing your "[PATCH v4 05/10] smb/client: sort
> smb2_error_map_table array", we autogenerate the table from the header file,
> putting all the info there?
> 
> One problem that we have is that we have multiple copies of the error table -
> and keeping them up to date and strictly ordered is problematic (hence your
> kunit test).  Further, each error number is mapped to an error string with the
> name of the symbol (I think they're all exactly equivalent).
> 
> So, for example, I do this for the ASN.1 Object Identifier (OID) registry.  I
> have a perl script:
> 
> 	lib/build_OID_registry
> 
> that parses the enum here:
> 
> 	include/linux/oid_registry.h
> 
> including the comments and generating tables for looking up OIDs:
> 
> 	enum OID {
> 		OID_id_dsa_with_sha1,		/* 1.2.840.10030.4.3 */
> 		OID_id_dsa,			/* 1.2.840.10040.4.1 */
> 
> This is built by rules in lib/Makefile:
> 
> 	#
> 	# Build a fast OID lookip registry from include/linux/oid_registry.h
> 	#
> 	obj-$(CONFIG_OID_REGISTRY) += oid_registry.o
> 
> 	$(obj)/oid_registry.o: $(obj)/oid_registry_data.c
> 
> 	$(obj)/oid_registry_data.c: $(srctree)/include/linux/oid_registry.h \
> 				    $(src)/build_OID_registry
> 		$(call cmd,build_OID_registry)
> 
> 	quiet_cmd_build_OID_registry = GEN     $@
> 	      cmd_build_OID_registry = perl $(src)/build_OID_registry $< $@
> 
> 	clean-files	+= oid_registry_data.c
> 
> Now, looking at smb2status.h, for example, we have a lot of:
> 
> 	#define STATUS_SUCCESS cpu_to_le32(0x00000000)
> 	#define STATUS_WAIT_0 cpu_to_le32(0x00000000)
> 	#define STATUS_WAIT_1 cpu_to_le32(0x00000001)
> 	...
> 
> and we could generate two parts of the table from this.  The third part could
> be placed in the header as well:
> 
> 	#define STATUS_SUCCESS	cpu_to_le32(0x00000000)	// 0
> 	#define STATUS_WAIT_0	cpu_to_le32(0x00000000)	// -EIO
> 	#define STATUS_WAIT_1	cpu_to_le32(0x00000001)	// -EIO
> 	...
> 
> (There's also the possibility that we don't necessarily want to list all
> statuses in the table.)
> 
> David