From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Laurent Pinchart To: Kieran Bingham Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org Subject: Re: [PATCH v3 10/11] media: vsp1: Support Interlaced display pipelines Date: Thu, 24 May 2018 13:08:55 +0300 Message-ID: <6945038.6Y03vj1EZt@avalon> In-Reply-To: <8df5710f-77c0-f466-e9ed-ffde4dd2f8d9@ideasonboard.com> References: <1784754.iAtk829Up8@avalon> <8df5710f-77c0-f466-e9ed-ffde4dd2f8d9@ideasonboard.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Kieran, On Thursday, 3 May 2018 16:45:30 EEST Kieran Bingham wrote: > On 03/05/18 12:13, Laurent Pinchart wrote: [snip] > >>> diff --git a/drivers/media/platform/vsp1/vsp1_rwpf.h > >>> b/drivers/media/platform/vsp1/vsp1_rwpf.h index > >>> 70742ecf766f..8d6e42f27908 100644 > >>> --- a/drivers/media/platform/vsp1/vsp1_rwpf.h > >>> +++ b/drivers/media/platform/vsp1/vsp1_rwpf.h > >>> @@ -42,6 +42,7 @@ struct vsp1_rwpf { > >>> > >>> struct v4l2_pix_format_mplane format; > >>> const struct vsp1_format_info *fmtinfo; > >>> unsigned int brx_input; > >>> > >>> + bool interlaced; > > > > kerneldoc might be nice :-) > > There's no existing kerneldoc on struct vsp1_rwpf ? I'm glad we agree it should be added :-) > >>> unsigned int alpha; > > > > [snip] > > > >>> diff --git a/include/media/vsp1.h b/include/media/vsp1.h > >>> index 678c24de1ac6..c10883f30980 100644 > >>> --- a/include/media/vsp1.h > >>> +++ b/include/media/vsp1.h > >>> @@ -50,6 +50,7 @@ int vsp1_du_setup_lif(struct device *dev, unsigned int > >>> pipe_index, > >>> * @dst: destination rectangle on the display (integer coordinates) > >>> * @alpha: alpha value (0: fully transparent, 255: fully opaque) > >>> * @zpos: Z position of the plane (from 0 to number of planes minus 1) > >>> + * @interlaced: true for interlaced pipelines > > > > Maybe "true if the pipeline outputs an interlaced stream" ? > > That's fine - but I've neglected to incorporate this into my v4 repost :-( > > If by any magic - v4 is suitable for integration already, and you're happy > to take it into your tree - please feel free to update this comment. > > Otherwise it will be in any next update. I'll check v4 now. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 10/11] media: vsp1: Support Interlaced display pipelines Date: Thu, 24 May 2018 13:08:55 +0300 Message-ID: <6945038.6Y03vj1EZt@avalon> References: <1784754.iAtk829Up8@avalon> <8df5710f-77c0-f466-e9ed-ffde4dd2f8d9@ideasonboard.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5C8F389EB7 for ; Thu, 24 May 2018 10:09:03 +0000 (UTC) In-Reply-To: <8df5710f-77c0-f466-e9ed-ffde4dd2f8d9@ideasonboard.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Kieran Bingham Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org SGkgS2llcmFuLAoKT24gVGh1cnNkYXksIDMgTWF5IDIwMTggMTY6NDU6MzAgRUVTVCBLaWVyYW4g QmluZ2hhbSB3cm90ZToKPiBPbiAwMy8wNS8xOCAxMjoxMywgTGF1cmVudCBQaW5jaGFydCB3cm90 ZToKCltzbmlwXQoKPiA+Pj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNw MS92c3AxX3J3cGYuaAo+ID4+PiBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX3J3 cGYuaCBpbmRleAo+ID4+PiA3MDc0MmVjZjc2NmYuLjhkNmU0MmYyNzkwOCAxMDA2NDQKPiA+Pj4g LS0tIGEvZHJpdmVycy9tZWRpYS9wbGF0Zm9ybS92c3AxL3ZzcDFfcndwZi5oCj4gPj4+ICsrKyBi L2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vdnNwMS92c3AxX3J3cGYuaAo+ID4+PiBAQCAtNDIsNiAr NDIsNyBAQCBzdHJ1Y3QgdnNwMV9yd3BmIHsKPiA+Pj4gCj4gPj4+ICAJc3RydWN0IHY0bDJfcGl4 X2Zvcm1hdF9tcGxhbmUgZm9ybWF0Owo+ID4+PiAgCWNvbnN0IHN0cnVjdCB2c3AxX2Zvcm1hdF9p bmZvICpmbXRpbmZvOwo+ID4+PiAgCXVuc2lnbmVkIGludCBicnhfaW5wdXQ7Cj4gPj4+IAo+ID4+ PiArCWJvb2wgaW50ZXJsYWNlZDsKPiA+IAo+ID4ga2VybmVsZG9jIG1pZ2h0IGJlIG5pY2UgOi0p Cj4gCj4gVGhlcmUncyBubyBleGlzdGluZyBrZXJuZWxkb2Mgb24gc3RydWN0IHZzcDFfcndwZiA/ CgpJJ20gZ2xhZCB3ZSBhZ3JlZSBpdCBzaG91bGQgYmUgYWRkZWQgOi0pCgo+ID4+PiAgCXVuc2ln bmVkIGludCBhbHBoYTsKPiA+IAo+ID4gW3NuaXBdCj4gPiAKPiA+Pj4gZGlmZiAtLWdpdCBhL2lu Y2x1ZGUvbWVkaWEvdnNwMS5oIGIvaW5jbHVkZS9tZWRpYS92c3AxLmgKPiA+Pj4gaW5kZXggNjc4 YzI0ZGUxYWM2Li5jMTA4ODNmMzA5ODAgMTAwNjQ0Cj4gPj4+IC0tLSBhL2luY2x1ZGUvbWVkaWEv dnNwMS5oCj4gPj4+ICsrKyBiL2luY2x1ZGUvbWVkaWEvdnNwMS5oCj4gPj4+IEBAIC01MCw2ICs1 MCw3IEBAIGludCB2c3AxX2R1X3NldHVwX2xpZihzdHJ1Y3QgZGV2aWNlICpkZXYsIHVuc2lnbmVk IGludAo+ID4+PiBwaXBlX2luZGV4LAo+ID4+PiAgICogQGRzdDogZGVzdGluYXRpb24gcmVjdGFu Z2xlIG9uIHRoZSBkaXNwbGF5IChpbnRlZ2VyIGNvb3JkaW5hdGVzKQo+ID4+PiAgICogQGFscGhh OiBhbHBoYSB2YWx1ZSAoMDogZnVsbHkgdHJhbnNwYXJlbnQsIDI1NTogZnVsbHkgb3BhcXVlKQo+ ID4+PiAgICogQHpwb3M6IFogcG9zaXRpb24gb2YgdGhlIHBsYW5lIChmcm9tIDAgdG8gbnVtYmVy IG9mIHBsYW5lcyBtaW51cyAxKQo+ID4+PiArICogQGludGVybGFjZWQ6IHRydWUgZm9yIGludGVy bGFjZWQgcGlwZWxpbmVzCj4gPiAKPiA+IE1heWJlICJ0cnVlIGlmIHRoZSBwaXBlbGluZSBvdXRw dXRzIGFuIGludGVybGFjZWQgc3RyZWFtIiA/Cj4gCj4gVGhhdCdzIGZpbmUgLSBidXQgSSd2ZSBu ZWdsZWN0ZWQgdG8gaW5jb3Jwb3JhdGUgdGhpcyBpbnRvIG15IHY0IHJlcG9zdCA6LSgKPiAKPiBJ ZiBieSBhbnkgbWFnaWMgLSB2NCBpcyBzdWl0YWJsZSBmb3IgaW50ZWdyYXRpb24gYWxyZWFkeSwg YW5kIHlvdSdyZSBoYXBweQo+IHRvIHRha2UgaXQgaW50byB5b3VyIHRyZWUgLSBwbGVhc2UgZmVl bCBmcmVlIHRvIHVwZGF0ZSB0aGlzIGNvbW1lbnQuCj4gCj4gT3RoZXJ3aXNlIGl0IHdpbGwgYmUg aW4gYW55IG5leHQgdXBkYXRlLgoKSSdsbCBjaGVjayB2NCBub3cuCgotLSAKUmVnYXJkcywKCkxh dXJlbnQgUGluY2hhcnQKCgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0 b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJp LWRldmVsCg==