From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Sun, 05 Feb 2017 17:36:59 +0200 Subject: [PATCH v3 12/24] add mux and video interface bridge entity functions In-Reply-To: <1483755102-24785-13-git-send-email-steve_longerbeam@mentor.com> References: <1483755102-24785-1-git-send-email-steve_longerbeam@mentor.com> <1483755102-24785-13-git-send-email-steve_longerbeam@mentor.com> Message-ID: <6948005.DnfziI9GIJ@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Steve, Thank you for the patch On Friday 06 Jan 2017 18:11:30 Steve Longerbeam wrote: > From: Philipp Zabel > > Signed-off-by: Philipp Zabel > --- > Documentation/media/uapi/mediactl/media-types.rst | 22 ++++++++++++++++++++ > include/uapi/linux/media.h | 6 ++++++ > 2 files changed, 28 insertions(+) > > diff --git a/Documentation/media/uapi/mediactl/media-types.rst > b/Documentation/media/uapi/mediactl/media-types.rst index 3e03dc2..023be29 > 100644 > --- a/Documentation/media/uapi/mediactl/media-types.rst > +++ b/Documentation/media/uapi/mediactl/media-types.rst > @@ -298,6 +298,28 @@ Types and flags used to represent the media graph > elements received on its sink pad and outputs the statistics data on > its source pad. > > + - .. row 29 > + > + .. _MEDIA-ENT-F-MUX: > + > + - ``MEDIA_ENT_F_MUX`` > + > + - Video multiplexer. An entity capable of multiplexing must have at > + least two sink pads and one source pad, and must pass the video > + frame(s) received from the active sink pad to the source pad. > Video > + frame(s) from the inactive sink pads are discarded. Apart from the comment made by Hans regarding the macro name, this looks good to me. > + - .. row 30 > + > + .. _MEDIA-ENT-F-VID-IF-BRIDGE: > + > + - ``MEDIA_ENT_F_VID_IF_BRIDGE`` > + > + - Video interface bridge. A video interface bridge entity must have > at > + least one sink pad and one source pad. It receives video frame(s) > on > + its sink pad in one bus format (HDMI, eDP, MIPI CSI-2, ...) and > + converts them and outputs them on its source pad in another bus > format > + (eDP, MIPI CSI-2, parallel, ...). The first sentence mentions *at least* one sink pad and one source pad, and the second one refers to "its sink pad" and "its source pad". This is a bit confusing. An easy option would be to require a single sink and a single source pad, but that would exclude bridges that combine a multiplexer. I also wonder whether "bridge" is the appropriate word here. Transceiver might be a better choice, to insist on the fact that one of the two pads corresponds to a physical interface that has special electrical properties (such as HDMI, eDP, or CSI-2 that all require PHYs). > .. tabularcolumns:: |p{5.5cm}|p{12.0cm}| > > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index 4890787..08a8bfa 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -105,6 +105,12 @@ struct media_device_info { > #define MEDIA_ENT_F_PROC_VIDEO_STATISTICS (MEDIA_ENT_F_BASE + 0x4006) > > /* > + * Switch and bridge entitites > + */ > +#define MEDIA_ENT_F_MUX (MEDIA_ENT_F_BASE + 0x5001) > +#define MEDIA_ENT_F_VID_IF_BRIDGE (MEDIA_ENT_F_BASE + 0x5002) > + > +/* > * Connectors > */ > /* It is a responsibility of the entity drivers to add connectors and links > */ -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v3 12/24] add mux and video interface bridge entity functions Date: Sun, 05 Feb 2017 17:36:59 +0200 Message-ID: <6948005.DnfziI9GIJ@avalon> References: <1483755102-24785-1-git-send-email-steve_longerbeam@mentor.com> <1483755102-24785-13-git-send-email-steve_longerbeam@mentor.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1483755102-24785-13-git-send-email-steve_longerbeam@mentor.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" To: Steve Longerbeam Cc: mark.rutland@arm.com, andrew-ct.chen@mediatek.com, minghsiu.tsai@mediatek.com, nick@shmanahar.org, songjun.wu@microchip.com, hverkuil@xs4all.nl, robert.jarzmik@free.fr, devel@driverdev.osuosl.org, markus.heiser@darmarit.de, laurent.pinchart+renesas@ideasonboard.com, linux@armlinux.org.uk, geert@linux-m68k.org, linux-media@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de, arnd@arndb.de, mchehab@kernel.org, bparrot@ti.com, robh+dt@kernel.org, horms+renesas@verge.net.au, tiffany.lin@mediatek.com, linux-arm-kernel@lists.infradead.org, niklas.soderlund+renesas@ragnatech.se, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, jean-christophe.trotin@st.com, p.zabel@pengutronix.de, fabio.estevam@nxp.com, shawnguo@kernel.org, sudipm.mukherjee@gmail.com List-Id: devicetree@vger.kernel.org Hi Steve, Thank you for the patch On Friday 06 Jan 2017 18:11:30 Steve Longerbeam wrote: > From: Philipp Zabel > > Signed-off-by: Philipp Zabel > --- > Documentation/media/uapi/mediactl/media-types.rst | 22 ++++++++++++++++++++ > include/uapi/linux/media.h | 6 ++++++ > 2 files changed, 28 insertions(+) > > diff --git a/Documentation/media/uapi/mediactl/media-types.rst > b/Documentation/media/uapi/mediactl/media-types.rst index 3e03dc2..023be29 > 100644 > --- a/Documentation/media/uapi/mediactl/media-types.rst > +++ b/Documentation/media/uapi/mediactl/media-types.rst > @@ -298,6 +298,28 @@ Types and flags used to represent the media graph > elements received on its sink pad and outputs the statistics data on > its source pad. > > + - .. row 29 > + > + .. _MEDIA-ENT-F-MUX: > + > + - ``MEDIA_ENT_F_MUX`` > + > + - Video multiplexer. An entity capable of multiplexing must have at > + least two sink pads and one source pad, and must pass the video > + frame(s) received from the active sink pad to the source pad. > Video > + frame(s) from the inactive sink pads are discarded. Apart from the comment made by Hans regarding the macro name, this looks good to me. > + - .. row 30 > + > + .. _MEDIA-ENT-F-VID-IF-BRIDGE: > + > + - ``MEDIA_ENT_F_VID_IF_BRIDGE`` > + > + - Video interface bridge. A video interface bridge entity must have > at > + least one sink pad and one source pad. It receives video frame(s) > on > + its sink pad in one bus format (HDMI, eDP, MIPI CSI-2, ...) and > + converts them and outputs them on its source pad in another bus > format > + (eDP, MIPI CSI-2, parallel, ...). The first sentence mentions *at least* one sink pad and one source pad, and the second one refers to "its sink pad" and "its source pad". This is a bit confusing. An easy option would be to require a single sink and a single source pad, but that would exclude bridges that combine a multiplexer. I also wonder whether "bridge" is the appropriate word here. Transceiver might be a better choice, to insist on the fact that one of the two pads corresponds to a physical interface that has special electrical properties (such as HDMI, eDP, or CSI-2 that all require PHYs). > .. tabularcolumns:: |p{5.5cm}|p{12.0cm}| > > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index 4890787..08a8bfa 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -105,6 +105,12 @@ struct media_device_info { > #define MEDIA_ENT_F_PROC_VIDEO_STATISTICS (MEDIA_ENT_F_BASE + 0x4006) > > /* > + * Switch and bridge entitites > + */ > +#define MEDIA_ENT_F_MUX (MEDIA_ENT_F_BASE + 0x5001) > +#define MEDIA_ENT_F_VID_IF_BRIDGE (MEDIA_ENT_F_BASE + 0x5002) > + > +/* > * Connectors > */ > /* It is a responsibility of the entity drivers to add connectors and links > */ -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:49484 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751344AbdBEPgl (ORCPT ); Sun, 5 Feb 2017 10:36:41 -0500 From: Laurent Pinchart To: Steve Longerbeam Cc: robh+dt@kernel.org, mark.rutland@arm.com, shawnguo@kernel.org, kernel@pengutronix.de, fabio.estevam@nxp.com, linux@armlinux.org.uk, mchehab@kernel.org, hverkuil@xs4all.nl, nick@shmanahar.org, markus.heiser@darmarit.de, p.zabel@pengutronix.de, laurent.pinchart+renesas@ideasonboard.com, bparrot@ti.com, geert@linux-m68k.org, arnd@arndb.de, sudipm.mukherjee@gmail.com, minghsiu.tsai@mediatek.com, tiffany.lin@mediatek.com, jean-christophe.trotin@st.com, horms+renesas@verge.net.au, niklas.soderlund+renesas@ragnatech.se, robert.jarzmik@free.fr, songjun.wu@microchip.com, andrew-ct.chen@mediatek.com, gregkh@linuxfoundation.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, devel@driverdev.osuosl.org Subject: Re: [PATCH v3 12/24] add mux and video interface bridge entity functions Date: Sun, 05 Feb 2017 17:36:59 +0200 Message-ID: <6948005.DnfziI9GIJ@avalon> In-Reply-To: <1483755102-24785-13-git-send-email-steve_longerbeam@mentor.com> References: <1483755102-24785-1-git-send-email-steve_longerbeam@mentor.com> <1483755102-24785-13-git-send-email-steve_longerbeam@mentor.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Steve, Thank you for the patch On Friday 06 Jan 2017 18:11:30 Steve Longerbeam wrote: > From: Philipp Zabel > > Signed-off-by: Philipp Zabel > --- > Documentation/media/uapi/mediactl/media-types.rst | 22 ++++++++++++++++++++ > include/uapi/linux/media.h | 6 ++++++ > 2 files changed, 28 insertions(+) > > diff --git a/Documentation/media/uapi/mediactl/media-types.rst > b/Documentation/media/uapi/mediactl/media-types.rst index 3e03dc2..023be29 > 100644 > --- a/Documentation/media/uapi/mediactl/media-types.rst > +++ b/Documentation/media/uapi/mediactl/media-types.rst > @@ -298,6 +298,28 @@ Types and flags used to represent the media graph > elements received on its sink pad and outputs the statistics data on > its source pad. > > + - .. row 29 > + > + .. _MEDIA-ENT-F-MUX: > + > + - ``MEDIA_ENT_F_MUX`` > + > + - Video multiplexer. An entity capable of multiplexing must have at > + least two sink pads and one source pad, and must pass the video > + frame(s) received from the active sink pad to the source pad. > Video > + frame(s) from the inactive sink pads are discarded. Apart from the comment made by Hans regarding the macro name, this looks good to me. > + - .. row 30 > + > + .. _MEDIA-ENT-F-VID-IF-BRIDGE: > + > + - ``MEDIA_ENT_F_VID_IF_BRIDGE`` > + > + - Video interface bridge. A video interface bridge entity must have > at > + least one sink pad and one source pad. It receives video frame(s) > on > + its sink pad in one bus format (HDMI, eDP, MIPI CSI-2, ...) and > + converts them and outputs them on its source pad in another bus > format > + (eDP, MIPI CSI-2, parallel, ...). The first sentence mentions *at least* one sink pad and one source pad, and the second one refers to "its sink pad" and "its source pad". This is a bit confusing. An easy option would be to require a single sink and a single source pad, but that would exclude bridges that combine a multiplexer. I also wonder whether "bridge" is the appropriate word here. Transceiver might be a better choice, to insist on the fact that one of the two pads corresponds to a physical interface that has special electrical properties (such as HDMI, eDP, or CSI-2 that all require PHYs). > .. tabularcolumns:: |p{5.5cm}|p{12.0cm}| > > diff --git a/include/uapi/linux/media.h b/include/uapi/linux/media.h > index 4890787..08a8bfa 100644 > --- a/include/uapi/linux/media.h > +++ b/include/uapi/linux/media.h > @@ -105,6 +105,12 @@ struct media_device_info { > #define MEDIA_ENT_F_PROC_VIDEO_STATISTICS (MEDIA_ENT_F_BASE + 0x4006) > > /* > + * Switch and bridge entitites > + */ > +#define MEDIA_ENT_F_MUX (MEDIA_ENT_F_BASE + 0x5001) > +#define MEDIA_ENT_F_VID_IF_BRIDGE (MEDIA_ENT_F_BASE + 0x5002) > + > +/* > * Connectors > */ > /* It is a responsibility of the entity drivers to add connectors and links > */ -- Regards, Laurent Pinchart