From: "Falkowski, Maciej" <maciej.falkowski@linux.intel.com>
To: Karol Wachowski <karol.wachowski@linux.intel.com>,
dri-devel@lists.freedesktop.org
Cc: oded.gabbay@gmail.com, jeff.hugo@oss.qualcomm.com, lizhi.hou@amd.com
Subject: Re: [PATCH] accel/ivpu: Fix warning due to undefined CONFIG_PROC_FS
Date: Wed, 12 Nov 2025 09:26:01 +0100 [thread overview]
Message-ID: <694bc833-48c2-4da0-b635-92288f747d95@linux.intel.com> (raw)
In-Reply-To: <20251112071911.1136934-1-karol.wachowski@linux.intel.com>
Reviewed-by: Maciej Falkowski <maciej.falkowski@linux.intel.com>
On 11/12/2025 8:19 AM, Karol Wachowski wrote:
> Change #if to #ifdef CONFIG_PROC_FS to fix warning reported by test robot:
> drivers/accel/ivpu/ivpu_drv.c:458:5: warning: "CONFIG_PROC_FS" is not defined, evaluates to 0 [-Wundef]
>
> Fixes: 63cc028484ab ("accel/ivpu: Add fdinfo support for memory statistics")
> Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
> ---
> drivers/accel/ivpu/ivpu_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/accel/ivpu/ivpu_drv.c b/drivers/accel/ivpu/ivpu_drv.c
> index ce7dbd473059..3d6fccdefdd6 100644
> --- a/drivers/accel/ivpu/ivpu_drv.c
> +++ b/drivers/accel/ivpu/ivpu_drv.c
> @@ -455,7 +455,7 @@ int ivpu_shutdown(struct ivpu_device *vdev)
> static const struct file_operations ivpu_fops = {
> .owner = THIS_MODULE,
> DRM_ACCEL_FOPS,
> -#if CONFIG_PROC_FS
> +#ifdef CONFIG_PROC_FS
> .show_fdinfo = drm_show_fdinfo,
> #endif
> };
> @@ -472,7 +472,7 @@ static const struct drm_driver driver = {
> .ioctls = ivpu_drm_ioctls,
> .num_ioctls = ARRAY_SIZE(ivpu_drm_ioctls),
> .fops = &ivpu_fops,
> -#if CONFIG_PROC_FS
> +#ifdef CONFIG_PROC_FS
> .show_fdinfo = drm_show_memory_stats,
> #endif
>
next prev parent reply other threads:[~2025-11-12 8:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-12 7:19 [PATCH] accel/ivpu: Fix warning due to undefined CONFIG_PROC_FS Karol Wachowski
2025-11-12 7:52 ` Andrzej Kacprowski
2025-11-12 8:26 ` Falkowski, Maciej [this message]
-- strict thread matches above, loose matches on Subject: below --
2025-12-02 17:02 Tommy Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=694bc833-48c2-4da0-b635-92288f747d95@linux.intel.com \
--to=maciej.falkowski@linux.intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jeff.hugo@oss.qualcomm.com \
--cc=karol.wachowski@linux.intel.com \
--cc=lizhi.hou@amd.com \
--cc=oded.gabbay@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.