From: John Garry <john.garry@linux.dev>
To: Tal Zussman <tz2294@columbia.edu>, Jens Axboe <axboe@kernel.dk>,
Christoph Hellwig <hch@lst.de>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
Luis Chamberlain <mcgrof@kernel.org>,
Hannes Reinecke <hare@kernel.org>,
"Matthew Wilcox (Oracle)" <willy@infradead.org>,
Christian Brauner <brauner@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
Keith Busch <kbusch@kernel.org>,
"Martin K. Petersen" <mkp@kernel.org>
Cc: Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-xfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Sashiko <sashiko-bot@kernel.org>
Subject: Re: [PATCH v5 5/9] block: fail a short atomic pin in bio_iov_iter_get_pages()
Date: Fri, 25 Sep 2026 14:37:06 +0100 [thread overview]
Message-ID: <69579dae-285d-472c-ba69-4279e5170502@linux.dev> (raw)
In-Reply-To: <20260923-blkdev-fixes-v5-5-89e60d66eb38@columbia.edu>
On 9/24/26 00:56, Tal Zussman wrote:
> On a partial page pin, __blkdev_direct_IO_simple() and
> __blkdev_direct_IO_async() submit what was pinned with REQ_ATOMIC set
> and leave the rest to the buffered fallback, tearing an IOCB_ATOMIC
> write.
>
> This can be triggered deterministically. A 16K pwritev2(RWF_ATOMIC)
> whose last page is PROT_NONE, on a scsi_debug device with atomic_wr=1,
> completes short with only three of the four pages written, violating
> RWF_ATOMIC semantics.
I don't mean to load more work, but a blktests case for this would be
great. I am consider doing it if you are too busy.
Thanks!
next prev parent reply other threads:[~2026-09-25 13:37 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-23 23:56 [PATCH v5 0/9] block device fixes for large block sizes, IOCB_NOWAIT, and direct I/O Tal Zussman
2026-09-23 23:56 ` [PATCH v5 1/9] block: use iomap_dirty_folio for block devices Tal Zussman
2026-09-23 23:56 ` [PATCH v5 2/9] block: take i_rwsem for the direct I/O write fallback Tal Zussman
2026-09-23 23:56 ` [PATCH v5 3/9] block: take i_rwsem for the splice read path Tal Zussman
2026-09-23 23:56 ` [PATCH v5 4/9] block: honor IOCB_NOWAIT in the block device buffered " Tal Zussman
2026-09-23 23:56 ` [PATCH v5 5/9] block: fail a short atomic pin in bio_iov_iter_get_pages() Tal Zussman
2026-09-25 5:14 ` Hannes Reinecke
2026-09-25 13:37 ` John Garry [this message]
2026-09-29 8:47 ` Tal Zussman
2026-09-23 23:56 ` [PATCH v5 6/9] block: don't fall back to buffered I/O for atomic writes Tal Zussman
2026-09-23 23:56 ` [PATCH v5 7/9] iomap: reject atomic writes in iomap_file_buffered_write() Tal Zussman
2026-09-24 7:25 ` John Garry
2026-09-25 5:14 ` Hannes Reinecke
2026-09-23 23:56 ` [PATCH v5 8/9] block: unpin all pages of a bvec in bio_iov_iter_align_down() Tal Zussman
2026-09-23 23:56 ` [PATCH v5 9/9] block: remove dead metadata handling from the async direct I/O path Tal Zussman
2026-10-07 14:05 ` [PATCH v5 0/9] block device fixes for large block sizes, IOCB_NOWAIT, and direct I/O Jens Axboe
2026-10-09 16:13 ` Tal Zussman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=69579dae-285d-472c-ba69-4279e5170502@linux.dev \
--to=john.garry@linux.dev \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=djwong@kernel.org \
--cc=hare@kernel.org \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mkp@kernel.org \
--cc=sashiko-bot@kernel.org \
--cc=shinichiro.kawasaki@wdc.com \
--cc=tz2294@columbia.edu \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.