Re: [bug report] soc: qcom: icc-bwmon: Add bandwidth monitoring driver

[Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>]

On 07/08/2025 17:58, Dan Carpenter wrote:
> Hello Krzysztof Kozlowski,
> 
> Commit b9c2ae6cac40 ("soc: qcom: icc-bwmon: Add bandwidth monitoring
> driver") from Jul 4, 2022 (linux-next), leads to the following Smatch
> static checker warning:
> 
> 	drivers/soc/qcom/icc-bwmon.c:693 bwmon_intr_thread()
> 	error: 'target_opp' dereferencing possible ERR_PTR()
> 
> drivers/soc/qcom/icc-bwmon.c
>     645 static irqreturn_t bwmon_intr_thread(int irq, void *dev_id)
>     646 {
>     647         struct icc_bwmon *bwmon = dev_id;
>     648         unsigned int irq_enable = 0;
>     649         struct dev_pm_opp *opp, *target_opp;
>     650         unsigned int bw_kbps, up_kbps, down_kbps, meas_kbps;
>     651 
>     652         bw_kbps = bwmon->target_kbps;
>     653         meas_kbps = bwmon->target_kbps;
>     654 
>     655         target_opp = dev_pm_opp_find_bw_ceil(bwmon->dev, &bw_kbps, 0);
>     656         if (IS_ERR(target_opp) && PTR_ERR(target_opp) == -ERANGE)
>     657                 target_opp = dev_pm_opp_find_bw_floor(bwmon->dev, &bw_kbps, 0);
> 
> Smatch thinks both dev_pm_opp_find_bw_ceil() and dev_pm_opp_find_bw_floor()
> can return error pointers.
Indeed, thanks. I'll fix it.

Best regards,
Krzysztof