All of lore.kernel.org
 help / color / mirror / Atom feed
From: Abhijeet Sonar <abhijeet.nkt@gmail.com>
To: phillip.wood@dunelm.org.uk, Karthik Nayak <karthik.188@gmail.com>,
	git@vger.kernel.org
Cc: Paul Millar <paul.millar@desy.de>,
	Junio C Hamano <gitster@pobox.com>, Jeff King <peff@peff.net>
Subject: Re: [PATCH] describe: refresh the index when 'broken' flag is used
Date: Mon, 24 Jun 2024 17:50:42 +0530	[thread overview]
Message-ID: <69662b07-e216-421b-b947-afa52e56d7ec@gmail.com> (raw)
In-Reply-To: <054c6ac1-4714-4600-afa5-7e9b6e9b0e72@gmail.com>

On 24/06/24 16:50, Phillip Wood wrote:

> This is a good description of the problem the patch fixes.

Thanks!

> As we're dealing with a repository that might be broken I suspect we'd 
> be better to run "git update-index --unmerged -q --refresh" as a 
> subprocess in the same way that we run "git diff-index" so that "git 
> describe --broken" does not die if the index cannot be refreshed.

I see, that makes sense.  I will change it to launch `update-index` in a 
sub-process
instead.

>> Also apart from that, we should add a test to capture the changes.
> That would be nice
Got it, I will add some tests as well.

Thanks


  reply	other threads:[~2024-06-24 12:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-06-23 21:42 [PATCH] describe: refresh the index when 'broken' flag is used Abhijeet Sonar
2024-06-23 21:56 ` Abhijeet Sonar
2024-06-24 10:56 ` Karthik Nayak
2024-06-24 11:20   ` Phillip Wood
2024-06-24 12:20     ` Abhijeet Sonar [this message]
2024-06-24 13:48       ` Abhijeet Sonar
2024-06-24 16:34         ` Junio C Hamano
2024-06-24 17:37           ` Abhijeet Sonar
2024-06-24 17:58             ` Junio C Hamano
2024-06-25  6:40               ` Abhijeet Sonar
2024-06-25  6:44               ` [PATCH v2] " Abhijeet Sonar
2024-06-25 12:27                 ` Karthik Nayak
2024-06-25 13:22                   ` Abhijeet Sonar
2024-06-25 12:28     ` [PATCH] " Karthik Nayak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=69662b07-e216-421b-b947-afa52e56d7ec@gmail.com \
    --to=abhijeet.nkt@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=karthik.188@gmail.com \
    --cc=paul.millar@desy.de \
    --cc=peff@peff.net \
    --cc=phillip.wood@dunelm.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.